* [PATCH 2/2] forcedeth: fix tx timeout
@ 2007-03-23 10:50 Ayaz Abdulla
0 siblings, 0 replies; only message in thread
From: Ayaz Abdulla @ 2007-03-23 10:50 UTC (permalink / raw)
To: Jeff Garzik, Manfred Spraul, Andrew Morton, nedev
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
The tx timeout routine was waking the tx queue conditionally. However,
it must call it unconditionally since the dev_watchdog has halted the tx
queue before calling the timeout function.
Signed-Off-By: Ayaz Abdulla <aabdulla@nvidia.com>
[-- Attachment #2: patch-forcedeth-fix-timeout --]
[-- Type: text/plain, Size: 381 bytes --]
--- orig/drivers/net/forcedeth.c 2007-03-11 20:59:06.000000000 -0500
+++ new/drivers/net/forcedeth.c 2007-03-11 20:58:59.000000000 -0500
@@ -2050,9 +2050,10 @@
nv_drain_tx(dev);
nv_init_tx(dev);
setup_hw_rings(dev, NV_SETUP_TX_RING);
- netif_wake_queue(dev);
}
+ netif_wake_queue(dev);
+
/* 4) restart tx engine */
nv_start_tx(dev);
spin_unlock_irq(&np->lock);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-03-23 22:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-23 10:50 [PATCH 2/2] forcedeth: fix tx timeout Ayaz Abdulla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.