* consolekit needs additional privs.
@ 2007-03-23 20:04 Daniel J Walsh
2007-04-11 14:00 ` Christopher J. PeBenito
0 siblings, 1 reply; 3+ messages in thread
From: Daniel J Walsh @ 2007-03-23 20:04 UTC (permalink / raw)
To: Christopher J. PeBenito, SE Linux
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
consolekit uses a pidfile
sends itself signals
reads /var/lib/dbus/machine-id
Needs to search and read users environments
Uses dbus to communicate with unconfined processes.
[-- Attachment #2: consolekit.patch --]
[-- Type: text/x-patch, Size: 2029 bytes --]
--- nsaserefpolicy/policy/modules/services/consolekit.fc 2007-03-20 09:23:13.000000000 -0400
+++ serefpolicy-2.5.10/policy/modules/services/consolekit.fc 2007-03-22 15:06:59.000000000 -0400
@@ -1 +1,2 @@
/usr/sbin/console-kit-daemon -- gen_context(system_u:object_r:consolekit_exec_t,s0)
+/var/run/consolekit.pid -- gen_context(system_u:object_r:consolekit_var_run_t,s0)
--- nsaserefpolicy/policy/modules/services/consolekit.te 2007-03-20 23:38:12.000000000 -0400
+++ serefpolicy-2.5.10/policy/modules/services/consolekit.te 2007-03-22 15:06:59.000000000 -0400
@@ -10,13 +10,16 @@
type consolekit_exec_t;
init_daemon_domain(consolekit_t, consolekit_exec_t)
+# pid files
+type consolekit_var_run_t;
+files_pid_file(consolekit_var_run_t)
+
########################################
#
# consolekit local policy
#
-
allow consolekit_t self:capability { sys_tty_config dac_override sys_nice sys_ptrace };
-allow consolekit_t self:process getsched;
+allow consolekit_t self:process { getsched signal };
allow consolekit_t self:fifo_file rw_fifo_file_perms;
allow consolekit_t self:unix_stream_socket create_stream_socket_perms;
@@ -27,6 +30,10 @@
domain_use_interactive_fds(consolekit_t)
files_read_etc_files(consolekit_t)
+# needs to read /var/lib/dbus/machine-id
+files_read_var_lib_files(consolekit_t)
+
+
libs_use_ld_so(consolekit_t)
libs_use_shared_libs(consolekit_t)
@@ -38,10 +45,25 @@
term_dontaudit_use_generic_ptys(consolekit_t)
')
+# pid file
+allow consolekit_t consolekit_var_run_t:file manage_file_perms;
+allow consolekit_t consolekit_var_run_t:dir rw_dir_perms;
+files_pid_filetrans(consolekit_t,consolekit_var_run_t, file)
+
+# Init script handling
+
+
+domain_ptrace_all_domains(consolekit_t)
+mcs_ptrace_all(consolekit_t)
+
optional_policy(`
dbus_system_bus_client_template(consolekit, consolekit_t)
dbus_send_system_bus(consolekit_t)
dbus_connect_system_bus(consolekit_t)
hal_dbus_chat(consolekit_t)
+ unconfined_dbus_chat(consolekit_t)
')
+
+term_use_console(consolekit_t)
+
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: consolekit needs additional privs.
2007-03-23 20:04 consolekit needs additional privs Daniel J Walsh
@ 2007-04-11 14:00 ` Christopher J. PeBenito
2007-04-11 14:19 ` Daniel J Walsh
0 siblings, 1 reply; 3+ messages in thread
From: Christopher J. PeBenito @ 2007-04-11 14:00 UTC (permalink / raw)
To: Daniel J Walsh; +Cc: SE Linux
On Fri, 2007-03-23 at 16:04 -0400, Daniel J Walsh wrote:
> consolekit uses a pidfile
>
> sends itself signals
>
> reads /var/lib/dbus/machine-id
Should this have its own type?
> Needs to search and read users environments
>
> Uses dbus to communicate with unconfined processes.
Merged. Other comments inline:
>
>
>
>
>
> differences
> between files
> attachment
> (consolekit.patch), "consolekit.patch"
>
> --- nsaserefpolicy/policy/modules/services/consolekit.fc 2007-03-20 09:23:13.000000000 -0400
> +++ serefpolicy-2.5.10/policy/modules/services/consolekit.fc 2007-03-22 15:06:59.000000000 -0400
> @@ -1 +1,2 @@
> /usr/sbin/console-kit-daemon -- gen_context(system_u:object_r:consolekit_exec_t,s0)
> +/var/run/consolekit.pid -- gen_context(system_u:object_r:consolekit_var_run_t,s0)
> --- nsaserefpolicy/policy/modules/services/consolekit.te 2007-03-20 23:38:12.000000000 -0400
> +++ serefpolicy-2.5.10/policy/modules/services/consolekit.te 2007-03-22 15:06:59.000000000 -0400
> @@ -10,13 +10,16 @@
> type consolekit_exec_t;
> init_daemon_domain(consolekit_t, consolekit_exec_t)
>
> +# pid files
> +type consolekit_var_run_t;
> +files_pid_file(consolekit_var_run_t)
> +
> ########################################
> #
> # consolekit local policy
> #
> -
> allow consolekit_t self:capability { sys_tty_config dac_override sys_nice sys_ptrace };
> -allow consolekit_t self:process getsched;
> +allow consolekit_t self:process { getsched signal };
> allow consolekit_t self:fifo_file rw_fifo_file_perms;
> allow consolekit_t self:unix_stream_socket create_stream_socket_perms;
>
> @@ -27,6 +30,10 @@
> domain_use_interactive_fds(consolekit_t)
>
> files_read_etc_files(consolekit_t)
> +# needs to read /var/lib/dbus/machine-id
> +files_read_var_lib_files(consolekit_t)
> +
> +
>
> libs_use_ld_so(consolekit_t)
> libs_use_shared_libs(consolekit_t)
> @@ -38,10 +45,25 @@
> term_dontaudit_use_generic_ptys(consolekit_t)
> ')
>
> +# pid file
> +allow consolekit_t consolekit_var_run_t:file manage_file_perms;
> +allow consolekit_t consolekit_var_run_t:dir rw_dir_perms;
> +files_pid_filetrans(consolekit_t,consolekit_var_run_t, file)
fixed to use policy pattern
> +# Init script handling
> +
> +
> +domain_ptrace_all_domains(consolekit_t)
> +mcs_ptrace_all(consolekit_t)
are you sure this isn't a dontaudit?
> optional_policy(`
> dbus_system_bus_client_template(consolekit, consolekit_t)
> dbus_send_system_bus(consolekit_t)
> dbus_connect_system_bus(consolekit_t)
>
> hal_dbus_chat(consolekit_t)
> + unconfined_dbus_chat(consolekit_t)
> ')
> +
> +term_use_console(consolekit_t)
> +
>
--
Chris PeBenito
Tresys Technology, LLC
(410) 290-1411 x150
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: consolekit needs additional privs.
2007-04-11 14:00 ` Christopher J. PeBenito
@ 2007-04-11 14:19 ` Daniel J Walsh
0 siblings, 0 replies; 3+ messages in thread
From: Daniel J Walsh @ 2007-04-11 14:19 UTC (permalink / raw)
To: Christopher J. PeBenito; +Cc: SE Linux
Christopher J. PeBenito wrote:
> On Fri, 2007-03-23 at 16:04 -0400, Daniel J Walsh wrote:
>
>> consolekit uses a pidfile
>>
>> sends itself signals
>>
>> reads /var/lib/dbus/machine-id
>>
>
> Should this have its own type?
>
>
I don't think it is security information, and I guess dbus does not
write to it. So adding it's own type would be of limited value, unless
we are worried about consolekit reading other files labeled var_t. I
guess we could label the directory dbus_var_lib_t, if you want.
>> Needs to search and read users environments
>>
>> Uses dbus to communicate with unconfined processes.
>>
>
> Merged. Other comments inline:
>
>
>>
>>
>>
>> differences
>> between files
>> attachment
>> (consolekit.patch), "consolekit.patch"
>>
>> --- nsaserefpolicy/policy/modules/services/consolekit.fc 2007-03-20 09:23:13.000000000 -0400
>> +++ serefpolicy-2.5.10/policy/modules/services/consolekit.fc 2007-03-22 15:06:59.000000000 -0400
>> @@ -1 +1,2 @@
>> /usr/sbin/console-kit-daemon -- gen_context(system_u:object_r:consolekit_exec_t,s0)
>> +/var/run/consolekit.pid -- gen_context(system_u:object_r:consolekit_var_run_t,s0)
>> --- nsaserefpolicy/policy/modules/services/consolekit.te 2007-03-20 23:38:12.000000000 -0400
>> +++ serefpolicy-2.5.10/policy/modules/services/consolekit.te 2007-03-22 15:06:59.000000000 -0400
>> @@ -10,13 +10,16 @@
>> type consolekit_exec_t;
>> init_daemon_domain(consolekit_t, consolekit_exec_t)
>>
>> +# pid files
>> +type consolekit_var_run_t;
>> +files_pid_file(consolekit_var_run_t)
>> +
>> ########################################
>> #
>> # consolekit local policy
>> #
>> -
>> allow consolekit_t self:capability { sys_tty_config dac_override sys_nice sys_ptrace };
>> -allow consolekit_t self:process getsched;
>> +allow consolekit_t self:process { getsched signal };
>> allow consolekit_t self:fifo_file rw_fifo_file_perms;
>> allow consolekit_t self:unix_stream_socket create_stream_socket_perms;
>>
>> @@ -27,6 +30,10 @@
>> domain_use_interactive_fds(consolekit_t)
>>
>> files_read_etc_files(consolekit_t)
>> +# needs to read /var/lib/dbus/machine-id
>> +files_read_var_lib_files(consolekit_t)
>> +
>> +
>>
>> libs_use_ld_so(consolekit_t)
>> libs_use_shared_libs(consolekit_t)
>> @@ -38,10 +45,25 @@
>> term_dontaudit_use_generic_ptys(consolekit_t)
>> ')
>>
>> +# pid file
>> +allow consolekit_t consolekit_var_run_t:file manage_file_perms;
>> +allow consolekit_t consolekit_var_run_t:dir rw_dir_perms;
>> +files_pid_filetrans(consolekit_t,consolekit_var_run_t, file)
>>
>
> fixed to use policy pattern
>
>
>> +# Init script handling
>> +
>> +
>> +domain_ptrace_all_domains(consolekit_t)
>> +mcs_ptrace_all(consolekit_t)
>>
>
> are you sure this isn't a dontaudit?
>
>
No, consolekit actually looks reads the environment variables
associated with a process looking for the settings of
XDG_SESSION_COOKIE, so it needs ptrace. It might only need it for the
userdomains though.
>> optional_policy(`
>> dbus_system_bus_client_template(consolekit, consolekit_t)
>> dbus_send_system_bus(consolekit_t)
>> dbus_connect_system_bus(consolekit_t)
>>
>> hal_dbus_chat(consolekit_t)
>> + unconfined_dbus_chat(consolekit_t)
>> ')
>> +
>> +term_use_console(consolekit_t)
>> +
>>
>>
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-11 14:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-23 20:04 consolekit needs additional privs Daniel J Walsh
2007-04-11 14:00 ` Christopher J. PeBenito
2007-04-11 14:19 ` Daniel J Walsh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.