* Re: [KJ] [PATCH] dvb: remove coding style comments on indentation
2007-03-25 21:19 [KJ] [PATCH] dvb: remove coding style comments on indentation Michael Krufky
@ 2007-03-25 21:35 ` Bernd Petrovitsch
2007-03-25 21:54 ` Michael Krufky
` (6 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Bernd Petrovitsch @ 2007-03-25 21:35 UTC (permalink / raw)
To: kernel-janitors
On Sun, 2007-03-25 at 17:19 -0400, Michael Krufky wrote:
> Charles Clément wrote:
> > Remove comments on setting indentation for emacs in bt8xx driver.
>
> What do we gain by this patch? The "c-basic-offset: 8" helps us
> to enforce tabbing style. Why would anybody want this removed?
I don't know.
Adding "c-indent-tabs-mode: t" is probably even better.
Bernd
--
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [KJ] [PATCH] dvb: remove coding style comments on indentation
2007-03-25 21:19 [KJ] [PATCH] dvb: remove coding style comments on indentation Michael Krufky
2007-03-25 21:35 ` Bernd Petrovitsch
@ 2007-03-25 21:54 ` Michael Krufky
2007-03-25 21:56 ` Charles Clément
` (5 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Michael Krufky @ 2007-03-25 21:54 UTC (permalink / raw)
To: kernel-janitors
Bernd Petrovitsch wrote:
> On Sun, 2007-03-25 at 17:19 -0400, Michael Krufky wrote:
>> Charles Clément wrote:
>>> Remove comments on setting indentation for emacs in bt8xx driver.
>> What do we gain by this patch? The "c-basic-offset: 8" helps us
>> to enforce tabbing style. Why would anybody want this removed?
>
> I don't know.
>
> Adding "c-indent-tabs-mode: t" is probably even better.
>
Then, in my opinion, it would be better to submit a patch that makes that
change, instead of removing them altogether.
Regards,
Mike Krufky
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [KJ] [PATCH] dvb: remove coding style comments on indentation
2007-03-25 21:19 [KJ] [PATCH] dvb: remove coding style comments on indentation Michael Krufky
2007-03-25 21:35 ` Bernd Petrovitsch
2007-03-25 21:54 ` Michael Krufky
@ 2007-03-25 21:56 ` Charles Clément
2007-03-25 22:16 ` Mike Isely
` (4 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Charles Clément @ 2007-03-25 21:56 UTC (permalink / raw)
To: kernel-janitors
On Sun, Mar 25, 2007 at 05:19:34PM -0400, Michael Krufky wrote:
> Charles Clément wrote:
> > Remove comments on setting indentation for emacs in bt8xx driver.
>
> What do we gain by this patch? The "c-basic-offset: 8" helps us
> to enforce tabbing style. Why would anybody want this removed?
>
> Regards,
>
> Mike Krufky
I agree that there is no benefit from the patch itself, but the
Documentation/CodingStyle file already specifies the tabbing style.
I do not think it should be included in multiple source files.
> > Signed-off-by: Charles Clément <caratorn@gmail.com>
> >
> > ---
> > Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bt832.c
> > =================================> > --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bt832.c
> > +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bt832.c
> > @@ -255,11 +255,3 @@ static void __exit bt832_cleanup_module(
> >
> > module_init(bt832_init_module);
> > module_exit(bt832_cleanup_module);
> > -
> > -/*
> > - * Overrides for Emacs so that we follow Linus's tabbing style.
> > - * ---------------------------------------------------------------------------
> > - * Local variables:
> > - * c-basic-offset: 8
> > - * End:
> > - */
> > Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-cards.c
> > =================================> > --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-cards.c
> > +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-cards.c
> > @@ -5044,10 +5044,3 @@ int __devinit bttv_handle_chipset(struct
> > pci_write_config_byte(btv->c.pci, PCI_LATENCY_TIMER, latency);
> > return 0;
> > }
> > -
> > -
> > -/*
> > - * Local variables:
> > - * c-basic-offset: 8
> > - * End:
> > - */
> > Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-driver.c
> > =================================> > --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-driver.c
> > +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-driver.c
> > @@ -4981,9 +4981,3 @@ static void bttv_cleanup_module(void)
> >
> > module_init(bttv_init_module);
> > module_exit(bttv_cleanup_module);
> > -
> > -/*
> > - * Local variables:
> > - * c-basic-offset: 8
> > - * End:
> > - */
> > Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-gpio.c
> > =================================> > --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-gpio.c
> > +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-gpio.c
> > @@ -186,9 +186,3 @@ void bttv_gpio_bits(struct bttv_core *co
> > spin_unlock_irqrestore(&btv->gpio_lock,flags);
> > }
> > EXPORT_SYMBOL(bttv_gpio_bits);
> > -
> > -/*
> > - * Local variables:
> > - * c-basic-offset: 8
> > - * End:
> > - */
> > Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv.h
> > =================================> > --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv.h
> > +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv.h
> > @@ -355,8 +355,3 @@ extern void bttv_input_fini(struct bttv
> > extern void bttv_input_irq(struct bttv *dev);
> >
> > #endif /* _BTTV_H_ */
> > -/*
> > - * Local variables:
> > - * c-basic-offset: 8
> > - * End:
> > - */
> > Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-i2c.c
> > =================================> > --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-i2c.c
> > +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-i2c.c
> > @@ -481,9 +481,3 @@ int __devexit fini_bttv_i2c(struct bttv
> >
> > return i2c_del_adapter(&btv->c.i2c_adap);
> > }
> > -
> > -/*
> > - * Local variables:
> > - * c-basic-offset: 8
> > - * End:
> > - */
> > Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-if.c
> > =================================> > --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-if.c
> > +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-if.c
> > @@ -151,9 +151,3 @@ void bttv_i2c_call(unsigned int card, un
> > return;
> > bttv_call_i2c_clients(&bttvs[card], cmd, arg);
> > }
> > -
> > -/*
> > - * Local variables:
> > - * c-basic-offset: 8
> > - * End:
> > - */
> > Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-input.c
> > =================================> > --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-input.c
> > +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-input.c
> > @@ -348,10 +348,3 @@ void bttv_input_fini(struct bttv *btv)
> > kfree(btv->remote);
> > btv->remote = NULL;
> > }
> > -
> > -
> > -/*
> > - * Local variables:
> > - * c-basic-offset: 8
> > - * End:
> > - */
> > Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttvp.h
> > =================================> > --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttvp.h
> > +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttvp.h
> > @@ -469,9 +469,3 @@ extern struct bttv bttvs[BTTV_MAX];
> > #define btaor(dat,mask,adr) btwrite((dat) | ((mask) & btread(adr)), adr)
> >
> > #endif /* _BTTVP_H_ */
> > -
> > -/*
> > - * Local variables:
> > - * c-basic-offset: 8
> > - * End:
> > - */
> > Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-risc.c
> > =================================> > --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-risc.c
> > +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-risc.c
> > @@ -894,9 +894,3 @@ bttv_overlay_risc(struct bttv *btv,
> > buf->vb.field = ov->field;
> > return 0;
> > }
> > -
> > -/*
> > - * Local variables:
> > - * c-basic-offset: 8
> > - * End:
> > - */
> > Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-vbi.c
> > =================================> > --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-vbi.c
> > +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-vbi.c
> > @@ -446,10 +446,3 @@ bttv_vbi_fmt_reset (struct bttv_vbi_fmt
> > /* See bttv_vbi_fmt_set(). */
> > f->end = tvnorm->vbistart[0] * 2 + 2;
> > }
> > -
> > -/* ----------------------------------------------------------------------- */
> > -/*
> > - * Local variables:
> > - * c-basic-offset: 8
> > - * End:
> > - */
> >
>
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
--
Charles Clément.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [KJ] [PATCH] dvb: remove coding style comments on indentation
2007-03-25 21:19 [KJ] [PATCH] dvb: remove coding style comments on indentation Michael Krufky
` (2 preceding siblings ...)
2007-03-25 21:56 ` Charles Clément
@ 2007-03-25 22:16 ` Mike Isely
2007-03-25 22:17 ` Michael Krufky
` (3 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Mike Isely @ 2007-03-25 22:16 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: TEXT/PLAIN, Size: 3420 bytes --]
The setting I know is called indent-tabs-mode, not c-indent-tabs-mode.
It's also not better or worse than c-basic-offset; it's complementary.
The following all work together:
1. indent-tabs-mode if not nil instructs emacs to fill with tab
characters where it can. If this setting it nil, indentation is done
only with space characters.
2. c-basic-offset specifies the number of columns to indent by -
independant of how / if tabs are being used.
3. tab-width specifies the number of columns defined by a tab character.
Thus for (a contrived) example, if you did this:
indent-tabs-mode t
c-basic-offset 4
tab-width 8
Then every indentation level is 4 columns, and tabs will be used
wherever 8 columns of total indentation can be combined. Said another
way, the first level of indentation would be 4 spaces, the next level
would be 1 tab, the next level would be 1 tab plus 4 spaces, etc.
Obviously that is probably not what anyone would want, but it should
illustrate the relationship among those settings. So just "eliminating"
c-basic-offset and replacing it with indent-tabs-mode doesn't accomplish
what one might expect.
I think it's good form to have all those settings in a source file (with
c-basic-offset set to 8 not four like the example above). It's not
redundant with the documented style. It causes anyone who loads the
file with emacs to automatically adopt the indentation conventions
intended for that source file and that has to be a good thing.
I for one work in environments other than v4l-dvb, and those other
environments don't always have the same coding style. To me it makes
perfect sense that the coding style can be encoded into the source file
itself. Then I don't have to worry about manually reconfiguring my
editor setup when moving in/out of v4l-dvb work. One can argue against
this sort of thing (i.e. I should just worry about this myself and
always manually switch), but then you're just opening the door for more
indentation accidents in the future. I would much prefer these sorts of
things to be in the source file; at least this way it helps to ensure
others (who use emacs) will automatically use the same indentation that
is already in the file.
-Mike
On Sun, 25 Mar 2007, Michael Krufky wrote:
> Bernd Petrovitsch wrote:
> > On Sun, 2007-03-25 at 17:19 -0400, Michael Krufky wrote:
> >> Charles Clément wrote:
> >>> Remove comments on setting indentation for emacs in bt8xx driver.
> >> What do we gain by this patch? The "c-basic-offset: 8" helps us
> >> to enforce tabbing style. Why would anybody want this removed?
> >
> > I don't know.
> >
> > Adding "c-indent-tabs-mode: t" is probably even better.
> >
>
> Then, in my opinion, it would be better to submit a patch that makes that
> change, instead of removing them altogether.
>
> Regards,
>
> Mike Krufky
>
> --
> video4linux-list mailing list
> Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
> https://www.redhat.com/mailman/listinfo/video4linux-list
>
--
| Mike Isely | PGP fingerprint
Spammers Die!! | | 03 54 43 4D 75 E5 CC 92
| isely @ pobox (dot) com | 71 16 01 E2 B5 F5 C1 E8
| |
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [KJ] [PATCH] dvb: remove coding style comments on indentation
2007-03-25 21:19 [KJ] [PATCH] dvb: remove coding style comments on indentation Michael Krufky
` (3 preceding siblings ...)
2007-03-25 22:16 ` Mike Isely
@ 2007-03-25 22:17 ` Michael Krufky
2007-03-25 22:35 ` Bernd Petrovitsch
` (2 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Michael Krufky @ 2007-03-25 22:17 UTC (permalink / raw)
To: kernel-janitors
Charles Clément wrote:
> On Sun, Mar 25, 2007 at 05:19:34PM -0400, Michael Krufky wrote:
>> Charles Clément wrote:
>>> Remove comments on setting indentation for emacs in bt8xx driver.
>> What do we gain by this patch? The "c-basic-offset: 8" helps us
>> to enforce tabbing style. Why would anybody want this removed?
>>
>> Regards,
>>
>> Mike Krufky
>
> I agree that there is no benefit from the patch itself, but the
> Documentation/CodingStyle file already specifies the tabbing style.
> I do not think it should be included in multiple source files.
>
Documentation/CodingStyle is the human-readable file that specifies
the codingstyle, but when I have bttv-cards.c open in emacs, the only
thing telling emacs to enforce codingstyle is the lines that you want
to remove. Emacs doesn't look to Documentation/CodingStyle for
formatting rules -- only people look there. I dont think it causes
any harm to keep these lines in the bottom of a source file -- I'm
against this removal.
-Michael Krufky
>>> Signed-off-by: Charles Clément <caratorn@gmail.com>
>>>
>>> ---
>>> Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bt832.c
>>> =================================>>> --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bt832.c
>>> +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bt832.c
>>> @@ -255,11 +255,3 @@ static void __exit bt832_cleanup_module(
>>>
>>> module_init(bt832_init_module);
>>> module_exit(bt832_cleanup_module);
>>> -
>>> -/*
>>> - * Overrides for Emacs so that we follow Linus's tabbing style.
>>> - * ---------------------------------------------------------------------------
>>> - * Local variables:
>>> - * c-basic-offset: 8
>>> - * End:
>>> - */
>>> Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-cards.c
>>> =================================>>> --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-cards.c
>>> +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-cards.c
>>> @@ -5044,10 +5044,3 @@ int __devinit bttv_handle_chipset(struct
>>> pci_write_config_byte(btv->c.pci, PCI_LATENCY_TIMER, latency);
>>> return 0;
>>> }
>>> -
>>> -
>>> -/*
>>> - * Local variables:
>>> - * c-basic-offset: 8
>>> - * End:
>>> - */
>>> Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-driver.c
>>> =================================>>> --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-driver.c
>>> +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-driver.c
>>> @@ -4981,9 +4981,3 @@ static void bttv_cleanup_module(void)
>>>
>>> module_init(bttv_init_module);
>>> module_exit(bttv_cleanup_module);
>>> -
>>> -/*
>>> - * Local variables:
>>> - * c-basic-offset: 8
>>> - * End:
>>> - */
>>> Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-gpio.c
>>> =================================>>> --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-gpio.c
>>> +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-gpio.c
>>> @@ -186,9 +186,3 @@ void bttv_gpio_bits(struct bttv_core *co
>>> spin_unlock_irqrestore(&btv->gpio_lock,flags);
>>> }
>>> EXPORT_SYMBOL(bttv_gpio_bits);
>>> -
>>> -/*
>>> - * Local variables:
>>> - * c-basic-offset: 8
>>> - * End:
>>> - */
>>> Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv.h
>>> =================================>>> --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv.h
>>> +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv.h
>>> @@ -355,8 +355,3 @@ extern void bttv_input_fini(struct bttv
>>> extern void bttv_input_irq(struct bttv *dev);
>>>
>>> #endif /* _BTTV_H_ */
>>> -/*
>>> - * Local variables:
>>> - * c-basic-offset: 8
>>> - * End:
>>> - */
>>> Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-i2c.c
>>> =================================>>> --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-i2c.c
>>> +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-i2c.c
>>> @@ -481,9 +481,3 @@ int __devexit fini_bttv_i2c(struct bttv
>>>
>>> return i2c_del_adapter(&btv->c.i2c_adap);
>>> }
>>> -
>>> -/*
>>> - * Local variables:
>>> - * c-basic-offset: 8
>>> - * End:
>>> - */
>>> Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-if.c
>>> =================================>>> --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-if.c
>>> +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-if.c
>>> @@ -151,9 +151,3 @@ void bttv_i2c_call(unsigned int card, un
>>> return;
>>> bttv_call_i2c_clients(&bttvs[card], cmd, arg);
>>> }
>>> -
>>> -/*
>>> - * Local variables:
>>> - * c-basic-offset: 8
>>> - * End:
>>> - */
>>> Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-input.c
>>> =================================>>> --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-input.c
>>> +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-input.c
>>> @@ -348,10 +348,3 @@ void bttv_input_fini(struct bttv *btv)
>>> kfree(btv->remote);
>>> btv->remote = NULL;
>>> }
>>> -
>>> -
>>> -/*
>>> - * Local variables:
>>> - * c-basic-offset: 8
>>> - * End:
>>> - */
>>> Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttvp.h
>>> =================================>>> --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttvp.h
>>> +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttvp.h
>>> @@ -469,9 +469,3 @@ extern struct bttv bttvs[BTTV_MAX];
>>> #define btaor(dat,mask,adr) btwrite((dat) | ((mask) & btread(adr)), adr)
>>>
>>> #endif /* _BTTVP_H_ */
>>> -
>>> -/*
>>> - * Local variables:
>>> - * c-basic-offset: 8
>>> - * End:
>>> - */
>>> Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-risc.c
>>> =================================>>> --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-risc.c
>>> +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-risc.c
>>> @@ -894,9 +894,3 @@ bttv_overlay_risc(struct bttv *btv,
>>> buf->vb.field = ov->field;
>>> return 0;
>>> }
>>> -
>>> -/*
>>> - * Local variables:
>>> - * c-basic-offset: 8
>>> - * End:
>>> - */
>>> Index: linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-vbi.c
>>> =================================>>> --- linux-2.6.21-rc4.orig/drivers/media/video/bt8xx/bttv-vbi.c
>>> +++ linux-2.6.21-rc4/drivers/media/video/bt8xx/bttv-vbi.c
>>> @@ -446,10 +446,3 @@ bttv_vbi_fmt_reset (struct bttv_vbi_fmt
>>> /* See bttv_vbi_fmt_set(). */
>>> f->end = tvnorm->vbistart[0] * 2 + 2;
>>> }
>>> -
>>> -/* ----------------------------------------------------------------------- */
>>> -/*
>>> - * Local variables:
>>> - * c-basic-offset: 8
>>> - * End:
>>> - */
>>>
>> _______________________________________________
>> Kernel-janitors mailing list
>> Kernel-janitors@lists.linux-foundation.org
>> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [KJ] [PATCH] dvb: remove coding style comments on indentation
2007-03-25 21:19 [KJ] [PATCH] dvb: remove coding style comments on indentation Michael Krufky
` (4 preceding siblings ...)
2007-03-25 22:17 ` Michael Krufky
@ 2007-03-25 22:35 ` Bernd Petrovitsch
2007-03-25 23:28 ` Mike Isely
2007-03-26 0:06 ` hermann pitton
7 siblings, 0 replies; 10+ messages in thread
From: Bernd Petrovitsch @ 2007-03-25 22:35 UTC (permalink / raw)
To: kernel-janitors
On Sun, 2007-03-25 at 17:16 -0500, Mike Isely wrote:
> The setting I know is called indent-tabs-mode, not c-indent-tabs-mode.
It seems to me that they aer somwhat similar, If I read
http://www.emacswiki.org/cgi-bin/wiki/IndentingC.
> It's also not better or worse than c-basic-offset; it's complementary.
> The following all work together:
[ ... concise description deleted ...]
> illustrate the relationship among those settings. So just "eliminating"
> c-basic-offset and replacing it with indent-tabs-mode doesn't accomplish
> what one might expect.
Sorry, I never meant replacing but adding it to enforce the CodingStyle.
And adding "tab-width: 8" is also not wrong (and *if* there is a correct
default value for tab-width:, it is IMHO 8).
> I think it's good form to have all those settings in a source file (with
> c-basic-offset set to 8 not four like the example above). It's not
/me too.
> redundant with the documented style. It causes anyone who loads the
> file with emacs to automatically adopt the indentation conventions
> intended for that source file and that has to be a good thing.
>
> I for one work in environments other than v4l-dvb, and those other
> environments don't always have the same coding style. To me it makes
> perfect sense that the coding style can be encoded into the source file
> itself. Then I don't have to worry about manually reconfiguring my
Yup. Actually vi/vim supports similar annotations.
Bernd
--
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [KJ] [PATCH] dvb: remove coding style comments on indentation
2007-03-25 21:19 [KJ] [PATCH] dvb: remove coding style comments on indentation Michael Krufky
` (5 preceding siblings ...)
2007-03-25 22:35 ` Bernd Petrovitsch
@ 2007-03-25 23:28 ` Mike Isely
2007-03-26 0:06 ` hermann pitton
7 siblings, 0 replies; 10+ messages in thread
From: Mike Isely @ 2007-03-25 23:28 UTC (permalink / raw)
To: kernel-janitors
On Mon, 26 Mar 2007, Bernd Petrovitsch wrote:
> On Sun, 2007-03-25 at 17:16 -0500, Mike Isely wrote:
> > The setting I know is called indent-tabs-mode, not c-indent-tabs-mode.
>
> It seems to me that they aer somwhat similar, If I read
> http://www.emacswiki.org/cgi-bin/wiki/IndentingC.
I had no idea about that wiki. Very nice. Thanks for pointing it out.
However I don't understand that comment. There is no reference to
c-indent-tabs-mode anywhere on that page except in use in a single
example - and I think that's a typo in the example. And
c-indent-tabs-mode is unrecognized by my GNU emacs version 21
installation.
>
> > It's also not better or worse than c-basic-offset; it's complementary.
> > The following all work together:
> [ ... concise description deleted ...]
> > illustrate the relationship among those settings. So just "eliminating"
> > c-basic-offset and replacing it with indent-tabs-mode doesn't accomplish
> > what one might expect.
>
> Sorry, I never meant replacing but adding it to enforce the CodingStyle.
> And adding "tab-width: 8" is also not wrong (and *if* there is a correct
> default value for tab-width:, it is IMHO 8).
Then there is agreement here that the original proposed patch is not a
good idea.
>
> > I think it's good form to have all those settings in a source file (with
> > c-basic-offset set to 8 not four like the example above). It's not
>
> /me too.
>
> > redundant with the documented style. It causes anyone who loads the
> > file with emacs to automatically adopt the indentation conventions
> > intended for that source file and that has to be a good thing.
> >
> > I for one work in environments other than v4l-dvb, and those other
> > environments don't always have the same coding style. To me it makes
> > perfect sense that the coding style can be encoded into the source file
> > itself. Then I don't have to worry about manually reconfiguring my
>
> Yup. Actually vi/vim supports similar annotations.
I'm not a vi/vim expert, but I've had one coworker who was. Every time
I committed a change with those emacs declarations added, he always
followed up with another commit to add the vi/vim equivalents :-)
-Mike
--
| Mike Isely | PGP fingerprint
Spammers Die!! | | 03 54 43 4D 75 E5 CC 92
| isely @ pobox (dot) com | 71 16 01 E2 B5 F5 C1 E8
| |
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [KJ] [PATCH] dvb: remove coding style comments on indentation
2007-03-25 21:19 [KJ] [PATCH] dvb: remove coding style comments on indentation Michael Krufky
` (6 preceding siblings ...)
2007-03-25 23:28 ` Mike Isely
@ 2007-03-26 0:06 ` hermann pitton
7 siblings, 0 replies; 10+ messages in thread
From: hermann pitton @ 2007-03-26 0:06 UTC (permalink / raw)
To: kernel-janitors
Am Sonntag, den 25.03.2007, 18:28 -0500 schrieb Mike Isely:
> On Mon, 26 Mar 2007, Bernd Petrovitsch wrote:
>
> > On Sun, 2007-03-25 at 17:16 -0500, Mike Isely wrote:
> > > The setting I know is called indent-tabs-mode, not c-indent-tabs-mode.
> >
> > It seems to me that they aer somwhat similar, If I read
> > http://www.emacswiki.org/cgi-bin/wiki/IndentingC.
>
> I had no idea about that wiki. Very nice. Thanks for pointing it out.
>
> However I don't understand that comment. There is no reference to
> c-indent-tabs-mode anywhere on that page except in use in a single
> example - and I think that's a typo in the example. And
> c-indent-tabs-mode is unrecognized by my GNU emacs version 21
> installation.
>
>
> >
> > > It's also not better or worse than c-basic-offset; it's complementary.
> > > The following all work together:
> > [ ... concise description deleted ...]
> > > illustrate the relationship among those settings. So just "eliminating"
> > > c-basic-offset and replacing it with indent-tabs-mode doesn't accomplish
> > > what one might expect.
> >
> > Sorry, I never meant replacing but adding it to enforce the CodingStyle.
> > And adding "tab-width: 8" is also not wrong (and *if* there is a correct
> > default value for tab-width:, it is IMHO 8).
>
> Then there is agreement here that the original proposed patch is not a
> good idea.
>
>
> >
> > > I think it's good form to have all those settings in a source file (with
> > > c-basic-offset set to 8 not four like the example above). It's not
> >
> > /me too.
> >
> > > redundant with the documented style. It causes anyone who loads the
> > > file with emacs to automatically adopt the indentation conventions
> > > intended for that source file and that has to be a good thing.
> > >
> > > I for one work in environments other than v4l-dvb, and those other
> > > environments don't always have the same coding style. To me it makes
> > > perfect sense that the coding style can be encoded into the source file
> > > itself. Then I don't have to worry about manually reconfiguring my
> >
> > Yup. Actually vi/vim supports similar annotations.
>
> I'm not a vi/vim expert, but I've had one coworker who was. Every time
> I committed a change with those emacs declarations added, he always
> followed up with another commit to add the vi/vim equivalents :-)
>
> -Mike
>
Hi,
it is true that this all is not unimportant, but never made some new
hardware/tuner work, it is all only clean up in delay.
If we depend on coding style to test something ... ,
we can close the shop.
Cheers,
Hermann
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 10+ messages in thread