From: Prarit Bhargava <prarit@redhat.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Rick Lindsley <ricklind@us.ibm.com>,
john stultz <johnstul@us.ibm.com>, Ingo Molnar <mingo@elte.hu>,
Linux Kernel <linux-kernel@vger.kernel.org>,
virtualization@lists.osdl.org, Paul Mackerras <paulus@samba.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 1/2] Ignore stolen time in the softlockup watchdog
Date: Tue, 27 Mar 2007 10:39:23 -0400 [thread overview]
Message-ID: <46092C9B.4030700@redhat.com> (raw)
In-Reply-To: <20070327054106.664262413@goop.org>
Jeremy Fitzhardinge wrote:
>
> ---
> kernel/softlockup.c | 28 +++++++++++++++++++---------
> 1 file changed, 19 insertions(+), 9 deletions(-)
>
> ===================================================================
> --- a/kernel/softlockup.c
> +++ b/kernel/softlockup.c
> @@ -17,8 +17,8 @@
>
> static DEFINE_SPINLOCK(print_lock);
>
> -static DEFINE_PER_CPU(unsigned long, touch_timestamp);
> -static DEFINE_PER_CPU(unsigned long, print_timestamp);
> +static DEFINE_PER_CPU(unsigned long long, touch_timestamp);
> +static DEFINE_PER_CPU(unsigned long long, print_timestamp);
> static DEFINE_PER_CPU(struct task_struct *, watchdog_task);
>
> static int did_panic = 0;
> @@ -37,7 +37,7 @@ static struct notifier_block panic_block
>
> void touch_softlockup_watchdog(void)
> {
> - __raw_get_cpu_var(touch_timestamp) = jiffies;
> + __raw_get_cpu_var(touch_timestamp) = sched_clock();
> }
>
I'd like to see this patch implement/fix touch_cpu_softlockup_watchdog
and touch_softlockup_watchdog to mimic touch_nmi_watchdog's behaviour.
See this now obsolete patch: http://lkml.org/lkml/2007/3/15/131
P.
WARNING: multiple messages have this Message-ID (diff)
From: Prarit Bhargava <prarit@redhat.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
virtualization@lists.osdl.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
john stultz <johnstul@us.ibm.com>,
Zachary Amsden <zach@vmware.com>,
James Morris <jmorris@namei.org>, Dan Hecht <dhecht@vmware.com>,
Paul Mackerras <paulus@samba.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Chris Lalancette <clalance@redhat.com>,
Rick Lindsley <ricklind@us.ibm.com>
Subject: Re: [patch 1/2] Ignore stolen time in the softlockup watchdog
Date: Tue, 27 Mar 2007 10:39:23 -0400 [thread overview]
Message-ID: <46092C9B.4030700@redhat.com> (raw)
In-Reply-To: <20070327054106.664262413@goop.org>
Jeremy Fitzhardinge wrote:
>
> ---
> kernel/softlockup.c | 28 +++++++++++++++++++---------
> 1 file changed, 19 insertions(+), 9 deletions(-)
>
> ===================================================================
> --- a/kernel/softlockup.c
> +++ b/kernel/softlockup.c
> @@ -17,8 +17,8 @@
>
> static DEFINE_SPINLOCK(print_lock);
>
> -static DEFINE_PER_CPU(unsigned long, touch_timestamp);
> -static DEFINE_PER_CPU(unsigned long, print_timestamp);
> +static DEFINE_PER_CPU(unsigned long long, touch_timestamp);
> +static DEFINE_PER_CPU(unsigned long long, print_timestamp);
> static DEFINE_PER_CPU(struct task_struct *, watchdog_task);
>
> static int did_panic = 0;
> @@ -37,7 +37,7 @@ static struct notifier_block panic_block
>
> void touch_softlockup_watchdog(void)
> {
> - __raw_get_cpu_var(touch_timestamp) = jiffies;
> + __raw_get_cpu_var(touch_timestamp) = sched_clock();
> }
>
I'd like to see this patch implement/fix touch_cpu_softlockup_watchdog
and touch_softlockup_watchdog to mimic touch_nmi_watchdog's behaviour.
See this now obsolete patch: http://lkml.org/lkml/2007/3/15/131
P.
next prev parent reply other threads:[~2007-03-27 14:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 5:38 [patch 0/2] softlockup watchdog improvements Jeremy Fitzhardinge
2007-03-27 5:38 ` Jeremy Fitzhardinge
2007-03-27 5:38 ` [patch 1/2] Ignore stolen time in the softlockup watchdog Jeremy Fitzhardinge
2007-03-27 7:00 ` Eric Dumazet
2007-03-27 7:12 ` Jeremy Fitzhardinge
2007-03-27 7:12 ` Jeremy Fitzhardinge
2007-03-27 7:50 ` Eric Dumazet
2007-03-27 7:50 ` Eric Dumazet
2007-03-27 14:39 ` Prarit Bhargava [this message]
2007-03-27 14:39 ` Prarit Bhargava
2007-03-27 16:37 ` Jeremy Fitzhardinge
2007-03-27 16:53 ` Prarit Bhargava
2007-03-27 16:53 ` Prarit Bhargava
2007-03-27 17:10 ` Jeremy Fitzhardinge
2007-03-27 17:10 ` Jeremy Fitzhardinge
2007-03-27 17:20 ` Prarit Bhargava
2007-03-27 17:20 ` Prarit Bhargava
2007-03-27 5:38 ` [patch 2/2] percpu enable flag for " Jeremy Fitzhardinge
2007-03-27 5:38 ` Jeremy Fitzhardinge
2007-03-27 14:42 ` Prarit Bhargava
2007-03-27 14:42 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46092C9B.4030700@redhat.com \
--to=prarit@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jeremy@goop.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=ricklind@us.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.