[patch] conntrack tool: Fix loading of protocol helpers

[patch] conntrack tool: Fix loading of protocol helpers

[Thomas Jarosch]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hello,

the pkgconfig changes from August 2006 broke the loading of the protocol 
helpers as dlopen() doesn't search for symbols in the main executable.
As a result the protocol helpers can't find register_proto().

Attached patch fixes the problem.

Does anyone have a short example how to use the -G functionality of the tool?

Have a nice weekend,
Thomas

[-- Attachment #2: conntrack-dlopen-fix.patch --]
[-- Type: text/x-diff, Size: 391 bytes --]

diff -u -r -p conntrack-20070315/src/Makefile.am conntrack.fixed/src/Makefile.am
--- conntrack-20070315/src/Makefile.am	Thu Aug  3 12:37:00 2006
+++ conntrack.fixed/src/Makefile.am	Fri Mar 16 17:39:46 2007
@@ -3,5 +3,5 @@ LIBS = @CONNTRACK_LIBS@
 
 sbin_PROGRAMS = conntrack
 conntrack_SOURCES = conntrack.c
-#conntrack_LDFLAGS = $(all_libraries) -rdynamic
+conntrack_LDFLAGS = -rdynamic
  

Re: [patch] conntrack tool: Fix loading of protocol helpers

[Patrick McHardy]

Thomas Jarosch wrote:
> Hello,
> 
> the pkgconfig changes from August 2006 broke the loading of the protocol 
> helpers as dlopen() doesn't search for symbols in the main executable.
> As a result the protocol helpers can't find register_proto().
> 
> Attached patch fixes the problem.

Applied, thanks again Thomas.

> Does anyone have a short example how to use the -G functionality of the tool?

Not out of my head, sorry.

Re: [patch] conntrack tool: Fix loading of protocol helpers

[Pablo Neira Ayuso]

Thomas Jarosch wrote:
> Does anyone have a short example how to use the -G functionality of the tool?

Have a look at the script called test.sh under SVN, you can find one there.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

Re: [patch] conntrack tool: Fix loading of protocol helpers

[Thomas Jarosch]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

Hello Pablo,

>> Does anyone have a short example how to use the -G functionality of the tool?
>
> Have a look at the script called test.sh under SVN, you can find one there.

Thanks, that's exactly what I've searched for. I didn't notice it because it's called "test.sh". What about the attached patch for the manual page? ;-)

Cheers,
Thomas


[-- Attachment #2: conntrack-man-mention-usage.patch --]
[-- Type: text/x-diff, Size: 415 bytes --]

--- conntrack.8	Mon Dec 26 03:49:34 2005
+++ conntrack.new	Fri Mar 16 20:12:31 2007
@@ -127,6 +127,8 @@
 The exit code is 0 for correct function.  Errors which appear to be caused by
 invalid command line parameters cause an exit code of 2.  Any other errors
 cause an exit code of 1.
+.SH EXAMPLE USAGE
+See the included test.sh script for a extensive usage example.
 .SH BUGS
 Bugs? What's this ;-)
 .SH SEE ALSO

Re: [patch] conntrack tool: Fix loading of protocol helpers

[Pablo Neira Ayuso]

Hi Thomas,

Thomas Jarosch wrote:
>> Have a look at the script called test.sh under SVN, you can find one
>> there.
> 
> Thanks, that's exactly what I've searched for. I didn't notice it
> because it's called "test.sh". What about the attached patch for the
> manual page? ;-)

I'd prefer some examples directly hardcoded to the manpage since test.sh
is not distributed inside a release package, so this could get people
confused. So, would you resend me a patch with some examples? Thanks!

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

Re: [patch] conntrack tool: Fix loading of protocol helpers

[Thomas Jarosch]

Hello Pablo,

On Monday, 19. March 2007, Pablo Neira Ayuso wrote:
> >> Have a look at the script called test.sh under SVN, you can find one
> >> there.
> >
> > Thanks, that's exactly what I've searched for. I didn't notice it
> > because it's called "test.sh". What about the attached patch for the
> > manual page? ;-)
>
> I'd prefer some examples directly hardcoded to the manpage since test.sh
> is not distributed inside a release package, so this could get people
> confused. So, would you resend me a patch with some examples? Thanks!

What about renaming test.sh to example.sh and include it
in the normal distribution?

Cheers,
Thomas

Re: [patch] conntrack tool: Fix loading of protocol helpers

[Pablo Neira Ayuso]

Thomas Jarosch wrote:
>> I'd prefer some examples directly hardcoded to the manpage since test.sh
>> is not distributed inside a release package, so this could get people
>> confused. So, would you resend me a patch with some examples? Thanks!
> 
> What about renaming test.sh to example.sh and include it
> in the normal distribution?

Hm, I don't like it either. Think of packaged versions provided by
vendors, they would have to put the script somewhere in the directory
tree. I still prefer the examples hardcoded in the manpage. Actually, I
usually like finding examples in manpages :)

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris