From: Patrick McHardy <kaber@trash.net>
To: Ole Reinartz <ole.reinartz@gmx.de>
Cc: lartc@mailman.ds9a.nl, Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [LARTC] Problem setting shift value in tcindex filter on big
Date: Mon, 02 Apr 2007 12:13:33 +0000 [thread overview]
Message-ID: <4610F36D.3020108@trash.net> (raw)
In-Reply-To: <460FA944.40902@gmx.de>
Please send bugreports to netdev@vger.kernel.org.
Ole Reinartz wrote:
> I'm trying to get some DiffServ QoS shaping to work on an XScale
> machine, running big endian. I'm setting it up with tc. Using the
> tcindex filter I found that regardless what shift value I enter, only
> '0' is returned when I list the filters afterwards. The very same rules
> work fine on my (little endian) PC.
> Looking at the code (iproute2-2.6.18-061002) I found that tc (in
> tc/f_tcindex.c, line 72 and after) sends the shift value to the kernel
> as an int. The kernel, however, expects it as a 'u16'
> (net/sched/cls_tcindex.c, around line 250 depending on the exact kernel
> version). I checked 2.6 kernel versions back until 2.6.11.
It appears this was broken during some ->change operation fixes
in 2.6.11.
> So... do we have a type mismatch here? As 'shift' is the last parameter
> in the buffer, this works still very well on a little endian machine,
> however on a big endian machine allways 0 is received in the kernel. To
> check that I changed the type of the shift value to unsigned short in
> tc, and that fixed it for me.
> Someone interested in a patch?
Yes, but its the kernel that needs to be fixed to expect a u32.
_______________________________________________
LARTC mailing list
LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/cgi-bin/mailman/listinfo/lartc
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Ole Reinartz <ole.reinartz@gmx.de>
Cc: lartc@mailman.ds9a.nl, Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [LARTC] Problem setting shift value in tcindex filter on big endian machine
Date: Mon, 02 Apr 2007 14:13:33 +0200 [thread overview]
Message-ID: <4610F36D.3020108@trash.net> (raw)
In-Reply-To: <460FA944.40902@gmx.de>
Please send bugreports to netdev@vger.kernel.org.
Ole Reinartz wrote:
> I'm trying to get some DiffServ QoS shaping to work on an XScale
> machine, running big endian. I'm setting it up with tc. Using the
> tcindex filter I found that regardless what shift value I enter, only
> '0' is returned when I list the filters afterwards. The very same rules
> work fine on my (little endian) PC.
> Looking at the code (iproute2-2.6.18-061002) I found that tc (in
> tc/f_tcindex.c, line 72 and after) sends the shift value to the kernel
> as an int. The kernel, however, expects it as a 'u16'
> (net/sched/cls_tcindex.c, around line 250 depending on the exact kernel
> version). I checked 2.6 kernel versions back until 2.6.11.
It appears this was broken during some ->change operation fixes
in 2.6.11.
> So... do we have a type mismatch here? As 'shift' is the last parameter
> in the buffer, this works still very well on a little endian machine,
> however on a big endian machine allways 0 is received in the kernel. To
> check that I changed the type of the shift value to unsigned short in
> tc, and that fixed it for me.
> Someone interested in a patch?
Yes, but its the kernel that needs to be fixed to expect a u32.
next prev parent reply other threads:[~2007-04-02 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-01 12:44 [LARTC] Problem setting shift value in tcindex filter on big endian Ole Reinartz
2007-04-02 12:13 ` Patrick McHardy [this message]
2007-04-02 12:13 ` [LARTC] Problem setting shift value in tcindex filter on big endian machine Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4610F36D.3020108@trash.net \
--to=kaber@trash.net \
--cc=lartc@mailman.ds9a.nl \
--cc=netdev@vger.kernel.org \
--cc=ole.reinartz@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.