All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: virtualization <virtualization@lists.osdl.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Define EFLAGS_IF
Date: Thu, 05 Apr 2007 17:29:52 -0700	[thread overview]
Message-ID: <46159480.20108@zytor.com> (raw)
In-Reply-To: <461592AA.4060103@goop.org>

Jeremy Fitzhardinge wrote:
> 
> That patch got dropped, and replaced by one which pulled all the flags
> definitions out of <asm/processor.h>
> 

Saw that a little too late :)

In general, it would be nice if the various CPU constants were all 
defined in one place, so I'd rather suggest protecting the appropriate 
parts of asm/processor.h with #ifndef __ASSEMBLY__.

	-hpa

WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	virtualization <virtualization@lists.osdl.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Define EFLAGS_IF
Date: Thu, 05 Apr 2007 17:29:52 -0700	[thread overview]
Message-ID: <46159480.20108@zytor.com> (raw)
In-Reply-To: <461592AA.4060103@goop.org>

Jeremy Fitzhardinge wrote:
> 
> That patch got dropped, and replaced by one which pulled all the flags
> definitions out of <asm/processor.h>
> 

Saw that a little too late :)

In general, it would be nice if the various CPU constants were all 
defined in one place, so I'd rather suggest protecting the appropriate 
parts of asm/processor.h with #ifndef __ASSEMBLY__.

	-hpa

  reply	other threads:[~2007-04-06  0:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22  3:16 [PATCH] Define EFLAGS_IF Rusty Russell
2007-03-22  3:24 ` Rusty Russell
2007-03-22  3:52   ` [PATCH] Use X86_EFLAGS_IF in irqflags.h, lguest Rusty Russell
2007-03-22  4:03     ` Keith Owens
2007-04-06  0:20 ` [PATCH] Define EFLAGS_IF H. Peter Anvin
2007-04-06  0:22   ` Jeremy Fitzhardinge
2007-04-06  0:22     ` Jeremy Fitzhardinge
2007-04-06  0:29     ` H. Peter Anvin [this message]
2007-04-06  0:29       ` H. Peter Anvin
2007-04-06  0:48       ` Andi Kleen
2007-04-06  1:06         ` H. Peter Anvin
2007-04-06  2:24           ` Rusty Russell
2007-04-06 10:30           ` Andi Kleen
2007-04-06 15:39             ` H. Peter Anvin
2007-04-09  1:11               ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46159480.20108@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.