All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: John Linville <linville@tuxdriver.com>,
	Michael Buesch <mb@bu3sch.de>,
	Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org,
	Jiri Benc <jbenc@suse.cz>
Subject: Re: [PATCH] mac80211: Report correct wireless statistics
Date: Sun, 08 Apr 2007 22:54:54 -0500	[thread overview]
Message-ID: <4619B90E.1030403@lwfinger.net> (raw)
In-Reply-To: <200704082031.59934.flamingice@sourmilk.net>

Michael Wu wrote:
> On Sunday 08 April 2007 20:02, Larry Finger wrote:
>> Link Quality=219/60  Signal level=-200 dBm  Noise level=-69 dBm
>>
> Try the attached patch without your "bcm43xx-mac80211: Fix error in 
> initiallizing max RSSI and max signal" patch.
> 
> -Michael Wu

Why would I want to do this? If the community agrees on anything, it is that the signal is given in 
dBm (i.e. a negative number) and that the rssi is a positive number. The firmware in the bcm43xx 
chips return a quantity that looks like an rssi with a received packet, and bcm43xx_rssi_postprocess 
turns that into a quantity that looks like dBm. Your patch reverses those designations and mixes up 
the two quantities. Again I ask "Why"?

Larry


  reply	other threads:[~2007-04-09  3:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-08  5:04 [PATCH] mac80211: Report correct wireless statistics Larry Finger
2007-04-08  7:48 ` Tomas Winkler
2007-04-08 15:35 ` Michael Wu
2007-04-08 22:26   ` Larry Finger
2007-04-08 23:02     ` Michael Wu
2007-04-08 23:32       ` Larry Finger
2007-04-08 23:41         ` Michael Wu
2007-04-09  0:02           ` Larry Finger
2007-04-09  0:31             ` Michael Wu
2007-04-09  3:54               ` Larry Finger [this message]
2007-04-09  4:43                 ` Michael Wu
2007-04-09  5:06                   ` Larry Finger
2007-04-09 12:07                   ` Dan Williams
2007-04-09 12:21                     ` Dan Williams
2007-04-09 15:49                     ` Larry Finger
2007-04-09 17:16                       ` Michael Wu
2007-04-09 21:12                         ` Larry Finger
2007-04-09 23:02                           ` Michael Wu
2007-04-10  0:59                             ` Larry Finger
2007-04-13 23:18                               ` Michael Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4619B90E.1030403@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=Bcm43xx-dev@lists.berlios.de \
    --cc=flamingice@sourmilk.net \
    --cc=jbenc@suse.cz \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.