From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Dan Williams <dcbw@redhat.com>,
John Linville <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>,
Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org,
Jiri Benc <jbenc@suse.cz>
Subject: Re: [PATCH] mac80211: Report correct wireless statistics
Date: Mon, 09 Apr 2007 16:12:19 -0500 [thread overview]
Message-ID: <461AAC33.4030409@lwfinger.net> (raw)
In-Reply-To: <200704091316.23661.flamingice@sourmilk.net>
Michael Wu wrote:
> rt2x00 does not use qual. All other drivers in tree that use qual
> (zd1211rw-mac80211, rtl8187) use the current convention.
>
> I don't see anything in those 4 points that would argue against the current
> conventions in mac80211. In fact, it sounds like you are arguing for it since
> jssi, which you said is linear, goes to qual (after my patch is applied)
> which wants a linear number.
The code is internally consistent. Now it is only the usage of the (r)ssi name to describe the
logarithmic numbers that is confusing. Would you entertain a patch that changed (r)ssi to level in
the structs and drivers to reduce the confusion? I have such a patch that works with
bcm43xx-mac80211. In addition, all other drivers compile.
Larry
next prev parent reply other threads:[~2007-04-09 21:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-08 5:04 [PATCH] mac80211: Report correct wireless statistics Larry Finger
2007-04-08 7:48 ` Tomas Winkler
2007-04-08 15:35 ` Michael Wu
2007-04-08 22:26 ` Larry Finger
2007-04-08 23:02 ` Michael Wu
2007-04-08 23:32 ` Larry Finger
2007-04-08 23:41 ` Michael Wu
2007-04-09 0:02 ` Larry Finger
2007-04-09 0:31 ` Michael Wu
2007-04-09 3:54 ` Larry Finger
2007-04-09 4:43 ` Michael Wu
2007-04-09 5:06 ` Larry Finger
2007-04-09 12:07 ` Dan Williams
2007-04-09 12:21 ` Dan Williams
2007-04-09 15:49 ` Larry Finger
2007-04-09 17:16 ` Michael Wu
2007-04-09 21:12 ` Larry Finger [this message]
2007-04-09 23:02 ` Michael Wu
2007-04-10 0:59 ` Larry Finger
2007-04-13 23:18 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461AAC33.4030409@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=dcbw@redhat.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.