All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] Taking a closer look at lm-sensors, Makefile brokeness
Date: Mon, 09 Apr 2007 13:45:06 +0000	[thread overview]
Message-ID: <461A479F.5000405@hhs.nl> (raw)

Hi all,

Because of the integration of the dynamic chip support written by my students, 
I've been taking a (much) closer look at lm-sensors userspace.

The current makefile is broken for use by any serious distribution / any 
distribution will need to patch it.

Why? Well because of the abundant use of ":=" instead of "="

For example the Makefile says:
"PREFIX := /usr/local"

Now when one wants an other prefix, normally in the build script for the distro 
one would invoke make like this:

make PREFIX=/usr

however because of the unnecessary use of :=, this isn;'t work as := will 
overwrite any environment / make commandline settings. This leads to distro's 
using patches to the makefile like the one attached.

Is it ok if I fix this in the 3.0.0 branch?

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

                 reply	other threads:[~2007-04-09 13:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=461A479F.5000405@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.