All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] Taking a closer look at lm-sensors, Makefile brokeness
@ 2007-04-09 13:45 Hans de Goede
  0 siblings, 0 replies; only message in thread
From: Hans de Goede @ 2007-04-09 13:45 UTC (permalink / raw)
  To: lm-sensors

Hi all,

Because of the integration of the dynamic chip support written by my students, 
I've been taking a (much) closer look at lm-sensors userspace.

The current makefile is broken for use by any serious distribution / any 
distribution will need to patch it.

Why? Well because of the abundant use of ":=" instead of "="

For example the Makefile says:
"PREFIX := /usr/local"

Now when one wants an other prefix, normally in the build script for the distro 
one would invoke make like this:

make PREFIX=/usr

however because of the unnecessary use of :=, this isn;'t work as := will 
overwrite any environment / make commandline settings. This leads to distro's 
using patches to the makefile like the one attached.

Is it ok if I fix this in the 3.0.0 branch?

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-04-09 13:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-09 13:45 [lm-sensors] Taking a closer look at lm-sensors, Makefile brokeness Hans de Goede

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.