From: Matt Sealey <matt@genesi-usa.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Olaf Hering <olaf@aepfle.de>,
linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org
Subject: Re: adding Pegasus IDE quirk for pata_via
Date: Mon, 09 Apr 2007 18:39:49 +0100 [thread overview]
Message-ID: <461A7A65.2060505@genesi-usa.com> (raw)
In-Reply-To: <20070409154026.4d8a0774@the-village.bc.nu>
Okay. I'll clean this up and submit a real patch to the Linux IDE mailing list (no point for
PowerPC guys to get any more of these since it is very generic Via IDE stuff now)
--
Matt Sealey <matt@genesi-usa.com>
Genesi, Manager, Developer Relations
Alan Cox wrote:
>> Again some comments would be appreciated from anyone who has a better idea on how this controller
>> works. This simple code addition came out of 2 or 3 days of discussion with the Pegasos designer
>> based on his experiences with the chip and is so simple there cannot be much wrong with it
>> apart from coding style and a distinct lack of testing.
>
> Seems sane to me - as you said the x86 world relies on the BIOS for this
> and in fact pretty much never uses native mode anyway.
>
> Patch looks fine except pci_find_device is obsolete, please use
> pci_get_device and refcount safe APIs.
WARNING: multiple messages have this Message-ID (diff)
From: Matt Sealey <matt@genesi-usa.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linuxppc-dev@ozlabs.org, Olaf Hering <olaf@aepfle.de>,
linux-ide@vger.kernel.org
Subject: Re: adding Pegasus IDE quirk for pata_via
Date: Mon, 09 Apr 2007 18:39:49 +0100 [thread overview]
Message-ID: <461A7A65.2060505@genesi-usa.com> (raw)
In-Reply-To: <20070409154026.4d8a0774@the-village.bc.nu>
Okay. I'll clean this up and submit a real patch to the Linux IDE mailing list (no point for
PowerPC guys to get any more of these since it is very generic Via IDE stuff now)
--
Matt Sealey <matt@genesi-usa.com>
Genesi, Manager, Developer Relations
Alan Cox wrote:
>> Again some comments would be appreciated from anyone who has a better idea on how this controller
>> works. This simple code addition came out of 2 or 3 days of discussion with the Pegasos designer
>> based on his experiences with the chip and is so simple there cannot be much wrong with it
>> apart from coding style and a distinct lack of testing.
>
> Seems sane to me - as you said the x86 world relies on the BIOS for this
> and in fact pretty much never uses native mode anyway.
>
> Patch looks fine except pci_find_device is obsolete, please use
> pci_get_device and refcount safe APIs.
next prev parent reply other threads:[~2007-04-09 17:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 11:16 adding Pegasus IDE quirk for pata_via Olaf Hering
2007-04-04 16:20 ` [PATCH] add correct interrupt property for pegasos ide Olaf Hering
2007-04-04 18:10 ` Bartlomiej Zolnierkiewicz
2007-04-04 18:10 ` Bartlomiej Zolnierkiewicz
2007-04-04 18:11 ` Olaf Hering
2007-04-04 18:42 ` Bartlomiej Zolnierkiewicz
2007-04-05 1:47 ` Benjamin Herrenschmidt
2007-04-05 1:47 ` Benjamin Herrenschmidt
2007-04-05 10:32 ` Olaf Hering
2007-04-05 10:32 ` Olaf Hering
2007-04-05 1:46 ` Benjamin Herrenschmidt
2007-04-05 1:46 ` Benjamin Herrenschmidt
2007-04-05 0:55 ` Stephen Rothwell
2007-04-05 0:55 ` Stephen Rothwell
2007-04-04 23:52 ` adding Pegasus IDE quirk for pata_via Benjamin Herrenschmidt
2007-04-09 13:13 ` Matt Sealey
2007-04-09 14:40 ` Alan Cox
2007-04-09 14:40 ` Alan Cox
2007-04-09 17:39 ` Matt Sealey [this message]
2007-04-09 17:39 ` Matt Sealey
2007-04-10 16:22 ` Olaf Hering
2007-04-10 16:22 ` Olaf Hering
2007-08-16 17:01 ` Olaf Hering
2007-08-16 17:01 ` Olaf Hering
2007-08-16 17:00 ` Olaf Hering
2007-08-17 13:10 ` [PATCH] advertise correct IDE mode on Pegasos2 Olaf Hering
2007-08-17 14:33 ` Olaf Hering
2007-08-17 18:19 ` Matt Sealey
2007-08-17 18:30 ` Olaf Hering
2007-08-17 18:27 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461A7A65.2060505@genesi-usa.com \
--to=matt@genesi-usa.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.