All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Ebbert <cebbert@redhat.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: nigel@nigel.suspend2.net, linux-pm@lists.osdl.org,
	Jiri Slaby <jirislaby@gmail.com>, Pavel Machek <pavel@ucw.cz>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [RFD] swsusp problem: Drivers allocate much memory during suspend
Date: Fri, 13 Apr 2007 17:40:53 -0400	[thread overview]
Message-ID: <461FF8E5.7010202@redhat.com> (raw)
In-Reply-To: <200704132241.52725.rjw@sisk.pl>

Rafael J. Wysocki wrote:
> 
> IMO to really fix the problem, we should let the drivers that need much memory
> for suspending allocate it _before_ the memory shrinker is called.  For this
> purpose we can use notifiers that will be called before we start the shrinking
> of memory.  Namely, if a driver needs to allocate substantial amount of memory
> for suspending, it can register a notifier that will be called before we try to
> shrink memory.  Then, the memory needed by the driver may be allocated in
> this notifier (of course, in that case it will also have to be called if the
> shrinking of memory fails, so that the memory allocated by the driver for
> suspending can be freed) and used in the driver's .suspend() routine.
> 

Can't you just put a "prepare to suspend" function pointer in the
bus_type and device_driver structs?

WARNING: multiple messages have this Message-ID (diff)
From: Chuck Ebbert <cebbert@redhat.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: nigel@nigel.suspend2.net, Pavel Machek <pavel@ucw.cz>,
	Jiri Slaby <jirislaby@gmail.com>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	linux-pm@lists.osdl.org
Subject: Re: [RFD] swsusp problem: Drivers allocate much memory during suspend
Date: Fri, 13 Apr 2007 17:40:53 -0400	[thread overview]
Message-ID: <461FF8E5.7010202@redhat.com> (raw)
In-Reply-To: <200704132241.52725.rjw@sisk.pl>

Rafael J. Wysocki wrote:
> 
> IMO to really fix the problem, we should let the drivers that need much memory
> for suspending allocate it _before_ the memory shrinker is called.  For this
> purpose we can use notifiers that will be called before we start the shrinking
> of memory.  Namely, if a driver needs to allocate substantial amount of memory
> for suspending, it can register a notifier that will be called before we try to
> shrink memory.  Then, the memory needed by the driver may be allocated in
> this notifier (of course, in that case it will also have to be called if the
> shrinking of memory fails, so that the memory allocated by the driver for
> suspending can be freed) and used in the driver's .suspend() routine.
> 

Can't you just put a "prepare to suspend" function pointer in the
bus_type and device_driver structs?


  parent reply	other threads:[~2007-04-13 21:40 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-29  7:44 2.6.21-rc5: swsusp: Not enough free memory Jiri Slaby
2007-03-29  7:44 ` Jiri Slaby
2007-03-29 14:39 ` Rafael J. Wysocki
2007-03-29 14:39   ` Rafael J. Wysocki
2007-03-29 14:39   ` Jiri Slaby
2007-03-29 14:39     ` Jiri Slaby
2007-04-01 18:17   ` Jiri Slaby
2007-04-01 18:17     ` Jiri Slaby
2007-04-01 19:23     ` Rafael J. Wysocki
2007-04-01 19:23       ` Rafael J. Wysocki
2007-04-02  8:24       ` Jiri Slaby
2007-04-02 21:18         ` Rafael J. Wysocki
2007-04-02 21:18           ` Rafael J. Wysocki
2007-04-03  7:37           ` Jiri Slaby
2007-04-03  7:37             ` Jiri Slaby
2007-04-03 10:50             ` Rafael J. Wysocki
2007-04-03 10:50               ` Rafael J. Wysocki
2007-04-03 19:59               ` Jiri Slaby
2007-04-03 19:59                 ` Jiri Slaby
2007-04-09 20:07               ` Jiri Slaby
2007-04-09 20:07                 ` Jiri Slaby
2007-04-09 20:20                 ` Rafael J. Wysocki
2007-04-09 20:20                   ` Rafael J. Wysocki
2007-04-11  7:36                   ` Jiri Slaby
2007-04-11  7:36                     ` Jiri Slaby
2007-04-11  9:55                     ` Rafael J. Wysocki
2007-04-11  9:55                       ` Rafael J. Wysocki
2007-04-11 10:45                       ` Jiri Slaby
2007-04-11 14:40                         ` Rafael J. Wysocki
2007-04-11 14:40                           ` Rafael J. Wysocki
2007-04-11 15:02                           ` Jiri Slaby
2007-04-11 15:02                             ` Jiri Slaby
2007-04-12 21:36                             ` Rafael J. Wysocki
2007-04-13 10:14                               ` Jiri Slaby
2007-04-13 12:00                                 ` Rafael J. Wysocki
2007-04-13 12:00                                   ` Rafael J. Wysocki
2007-04-13 12:21                                   ` Nigel Cunningham
2007-04-13 12:21                                     ` Nigel Cunningham
2007-04-13 20:41                                     ` [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory) Rafael J. Wysocki
2007-04-13 20:41                                       ` Rafael J. Wysocki
2007-04-13 21:34                                       ` Nigel Cunningham
2007-04-13 21:34                                         ` Nigel Cunningham
2007-04-13 21:40                                       ` Chuck Ebbert [this message]
2007-04-13 21:40                                         ` [RFD] swsusp problem: Drivers allocate much memory during suspend Chuck Ebbert
2007-04-13 22:10                                       ` [RFD] swsusp problem: Drivers allocate much memory during suspend (was: Re: 2.6.21-rc5: swsusp: Not enough free memory) Pavel Machek
2007-04-13 22:10                                         ` Pavel Machek
2007-04-13 22:34                                         ` Nigel Cunningham
2007-04-13 22:34                                           ` Nigel Cunningham
2007-04-13 22:38                                           ` Pavel Machek
2007-04-13 22:38                                             ` [linux-pm] " Pavel Machek
2007-04-13 22:43                                             ` Nigel Cunningham
2007-04-13 22:43                                               ` [linux-pm] " Nigel Cunningham
2007-04-13 22:35                                         ` Rafael J. Wysocki
2007-04-13 22:35                                           ` Rafael J. Wysocki
2007-04-13 22:36                                           ` Nigel Cunningham
2007-04-13 22:36                                             ` Nigel Cunningham
2007-04-13 22:40                                           ` Pavel Machek
2007-04-13 22:40                                             ` Pavel Machek
2007-04-13 22:45                                             ` Nigel Cunningham
2007-04-13 22:45                                               ` Nigel Cunningham
2007-04-13 22:57                                               ` Rafael J. Wysocki
2007-04-13 22:57                                                 ` Rafael J. Wysocki
2007-04-13 23:03                                                 ` Nigel Cunningham
2007-04-13 23:03                                                   ` Nigel Cunningham
2007-04-14  9:33                                                   ` Rafael J. Wysocki
2007-04-14  9:33                                                     ` Rafael J. Wysocki
2007-04-14 22:53                                           ` Rafael J. Wysocki
2007-04-14 22:53                                             ` [linux-pm] " Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=461FF8E5.7010202@redhat.com \
    --to=cebbert@redhat.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=nigel@nigel.suspend2.net \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.