diff for duplicates of <4620A13F.6060502@cosmosbay.com> diff --git a/a/1.txt b/N1/1.txt index 5c13a26..52723d7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,34 +1,35 @@ -Milind Arun Choudhary a écrit : -> use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs -> +Milind Arun Choudhary a =E9crit : +> use set_current_state(TASK_*) instead of current->state =3D TASK_*, in fs= +/nfs +> = + > Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com> -> -> +> = + +> = + > --- > idmap.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) -> +> = + > diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c > index 9d4a6b2..054ca15 100644 > --- a/fs/nfs/idmap.c > +++ b/fs/nfs/idmap.c -> @@ -272,7 +272,7 @@ nfs_idmap_id(struct idmap *idmap, struct idmap_hashtable *h, +> @@ -272,7 +272,7 @@ nfs_idmap_id(struct idmap *idmap, struct idmap_hashta= +ble *h, > set_current_state(TASK_UNINTERRUPTIBLE); > mutex_unlock(&idmap->idmap_im_lock); > schedule(); -> - current->state = TASK_RUNNING; +> - current->state =3D TASK_RUNNING; > + set_current_state(TASK_RUNNING); > remove_wait_queue(&idmap->idmap_wq, &wq); > mutex_lock(&idmap->idmap_im_lock); Probably a dumb question, so please forgive me. -Why are you forcing a memory barrier here, (and also on your other patches). +Why are you forcing a memory barrier here, (and also on your other patches= +). Is'nt a __set_current_state(TASK_RUNNING); appropriate ? - - -_______________________________________________ -Kernel-janitors mailing list -Kernel-janitors@lists.linux-foundation.org -https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors diff --git a/a/content_digest b/N1/content_digest index 9def822..88f9147 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020070414084956.GD14084@arun.site\0" "From\0Eric Dumazet <dada1@cosmosbay.com>\0" "Subject\0Re: [KJ] [PATCH 03/04]use set_current_state in fs\0" - "Date\0Sat, 14 Apr 2007 09:39:11 +0000\0" + "Date\0Sat, 14 Apr 2007 11:39:11 +0200\0" "To\0Milind Arun Choudhary <milindchoudhary@gmail.com>\0" "Cc\0kernel-janitors@lists.osdl.org" akpm@linux-foundation.org @@ -10,39 +10,40 @@ " trond.myklebust@fys.uio.no\0" "\00:1\0" "b\0" - "Milind Arun Choudhary a \303\251crit :\n" - "> use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs\n" - "> \n" + "Milind Arun Choudhary a =E9crit :\n" + "> use set_current_state(TASK_*) instead of current->state =3D TASK_*, in fs=\n" + "/nfs\n" + "> =\n" + "\n" "> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>\n" - "> \n" - "> \n" + "> =\n" + "\n" + "> =\n" + "\n" "> ---\n" "> idmap.c | 4 ++--\n" "> 1 files changed, 2 insertions(+), 2 deletions(-)\n" - "> \n" + "> =\n" + "\n" "> diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c\n" "> index 9d4a6b2..054ca15 100644\n" "> --- a/fs/nfs/idmap.c\n" "> +++ b/fs/nfs/idmap.c\n" - "> @@ -272,7 +272,7 @@ nfs_idmap_id(struct idmap *idmap, struct idmap_hashtable *h,\n" + "> @@ -272,7 +272,7 @@ nfs_idmap_id(struct idmap *idmap, struct idmap_hashta=\n" + "ble *h,\n" "> \tset_current_state(TASK_UNINTERRUPTIBLE);\n" "> \tmutex_unlock(&idmap->idmap_im_lock);\n" "> \tschedule();\n" - "> -\tcurrent->state = TASK_RUNNING;\n" + "> -\tcurrent->state =3D TASK_RUNNING;\n" "> +\tset_current_state(TASK_RUNNING);\n" "> \tremove_wait_queue(&idmap->idmap_wq, &wq);\n" "> \tmutex_lock(&idmap->idmap_im_lock);\n" "\n" "Probably a dumb question, so please forgive me.\n" "\n" - "Why are you forcing a memory barrier here, (and also on your other patches).\n" - "\n" - "Is'nt a __set_current_state(TASK_RUNNING); appropriate ?\n" - "\n" + "Why are you forcing a memory barrier here, (and also on your other patches=\n" + ").\n" "\n" - "_______________________________________________\n" - "Kernel-janitors mailing list\n" - "Kernel-janitors@lists.linux-foundation.org\n" - https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors + Is'nt a __set_current_state(TASK_RUNNING); appropriate ? -51b230091024984b85fd2997826b2e4b8dfb2fdaf581734756a0350765894791 +233cbe9a57f400a2641b43217392e741f7fc7c26c763a0e34e021c9aabad9b37
diff --git a/a/1.txt b/N2/1.txt index 5c13a26..6c141ea 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -26,9 +26,3 @@ Probably a dumb question, so please forgive me. Why are you forcing a memory barrier here, (and also on your other patches). Is'nt a __set_current_state(TASK_RUNNING); appropriate ? - - -_______________________________________________ -Kernel-janitors mailing list -Kernel-janitors@lists.linux-foundation.org -https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors diff --git a/a/content_digest b/N2/content_digest index 9def822..865e353 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,12 +1,12 @@ "ref\020070414084956.GD14084@arun.site\0" "From\0Eric Dumazet <dada1@cosmosbay.com>\0" - "Subject\0Re: [KJ] [PATCH 03/04]use set_current_state in fs\0" - "Date\0Sat, 14 Apr 2007 09:39:11 +0000\0" + "Subject\0Re: [KJ][PATCH 03/04]use set_current_state in fs\0" + "Date\0Sat, 14 Apr 2007 11:39:11 +0200\0" "To\0Milind Arun Choudhary <milindchoudhary@gmail.com>\0" "Cc\0kernel-janitors@lists.osdl.org" - akpm@linux-foundation.org nfs@lists.sourceforge.net linux-kernel@vger.kernel.org + akpm@linux-foundation.org " trond.myklebust@fys.uio.no\0" "\00:1\0" "b\0" @@ -37,12 +37,6 @@ "\n" "Why are you forcing a memory barrier here, (and also on your other patches).\n" "\n" - "Is'nt a __set_current_state(TASK_RUNNING); appropriate ?\n" - "\n" - "\n" - "_______________________________________________\n" - "Kernel-janitors mailing list\n" - "Kernel-janitors@lists.linux-foundation.org\n" - https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors + Is'nt a __set_current_state(TASK_RUNNING); appropriate ? -51b230091024984b85fd2997826b2e4b8dfb2fdaf581734756a0350765894791 +9aa9a5e7e65ce8610b52f308eb0ba0e9373f1a236bb692242e3b1eb23034dceb
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.