From: Eric Dumazet <dada1@cosmosbay.com>
To: Milind Arun Choudhary <milindchoudhary@gmail.com>
Cc: kernel-janitors@lists.osdl.org, akpm@linux-foundation.org,
nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org,
trond.myklebust@fys.uio.no
Subject: Re: [KJ] [PATCH 03/04]use set_current_state in fs
Date: Sat, 14 Apr 2007 09:39:11 +0000 [thread overview]
Message-ID: <4620A13F.6060502@cosmosbay.com> (raw)
In-Reply-To: <20070414084956.GD14084@arun.site>
Milind Arun Choudhary a écrit :
> use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs
>
> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
>
>
> ---
> idmap.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
> index 9d4a6b2..054ca15 100644
> --- a/fs/nfs/idmap.c
> +++ b/fs/nfs/idmap.c
> @@ -272,7 +272,7 @@ nfs_idmap_id(struct idmap *idmap, struct idmap_hashtable *h,
> set_current_state(TASK_UNINTERRUPTIBLE);
> mutex_unlock(&idmap->idmap_im_lock);
> schedule();
> - current->state = TASK_RUNNING;
> + set_current_state(TASK_RUNNING);
> remove_wait_queue(&idmap->idmap_wq, &wq);
> mutex_lock(&idmap->idmap_im_lock);
Probably a dumb question, so please forgive me.
Why are you forcing a memory barrier here, (and also on your other patches).
Is'nt a __set_current_state(TASK_RUNNING); appropriate ?
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <dada1@cosmosbay.com>
To: Milind Arun Choudhary <milindchoudhary@gmail.com>
Cc: kernel-janitors@lists.osdl.org, akpm@linux-foundation.org,
nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org,
trond.myklebust@fys.uio.no
Subject: Re: [KJ] [PATCH 03/04]use set_current_state in fs
Date: Sat, 14 Apr 2007 11:39:11 +0200 [thread overview]
Message-ID: <4620A13F.6060502@cosmosbay.com> (raw)
In-Reply-To: <20070414084956.GD14084@arun.site>
Milind Arun Choudhary a =E9crit :
> use set_current_state(TASK_*) instead of current->state =3D TASK_*, in fs=
/nfs
> =
> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
> =
> =
> ---
> idmap.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> =
> diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
> index 9d4a6b2..054ca15 100644
> --- a/fs/nfs/idmap.c
> +++ b/fs/nfs/idmap.c
> @@ -272,7 +272,7 @@ nfs_idmap_id(struct idmap *idmap, struct idmap_hashta=
ble *h,
> set_current_state(TASK_UNINTERRUPTIBLE);
> mutex_unlock(&idmap->idmap_im_lock);
> schedule();
> - current->state =3D TASK_RUNNING;
> + set_current_state(TASK_RUNNING);
> remove_wait_queue(&idmap->idmap_wq, &wq);
> mutex_lock(&idmap->idmap_im_lock);
Probably a dumb question, so please forgive me.
Why are you forcing a memory barrier here, (and also on your other patches=
).
Is'nt a __set_current_state(TASK_RUNNING); appropriate ?
WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <dada1@cosmosbay.com>
To: Milind Arun Choudhary <milindchoudhary@gmail.com>
Cc: kernel-janitors@lists.osdl.org, nfs@lists.sourceforge.net,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
trond.myklebust@fys.uio.no
Subject: Re: [KJ][PATCH 03/04]use set_current_state in fs
Date: Sat, 14 Apr 2007 11:39:11 +0200 [thread overview]
Message-ID: <4620A13F.6060502@cosmosbay.com> (raw)
In-Reply-To: <20070414084956.GD14084@arun.site>
Milind Arun Choudhary a écrit :
> use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs
>
> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
>
>
> ---
> idmap.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
> index 9d4a6b2..054ca15 100644
> --- a/fs/nfs/idmap.c
> +++ b/fs/nfs/idmap.c
> @@ -272,7 +272,7 @@ nfs_idmap_id(struct idmap *idmap, struct idmap_hashtable *h,
> set_current_state(TASK_UNINTERRUPTIBLE);
> mutex_unlock(&idmap->idmap_im_lock);
> schedule();
> - current->state = TASK_RUNNING;
> + set_current_state(TASK_RUNNING);
> remove_wait_queue(&idmap->idmap_wq, &wq);
> mutex_lock(&idmap->idmap_im_lock);
Probably a dumb question, so please forgive me.
Why are you forcing a memory barrier here, (and also on your other patches).
Is'nt a __set_current_state(TASK_RUNNING); appropriate ?
next prev parent reply other threads:[~2007-04-14 9:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-14 8:49 [KJ][PATCH 03/04]use set_current_state in fs Milind Arun Choudhary
2007-04-14 9:01 ` [KJ] [PATCH " Milind Arun Choudhary
2007-04-14 8:49 ` [KJ][PATCH " Milind Arun Choudhary
2007-04-14 9:39 ` Eric Dumazet [this message]
2007-04-14 9:39 ` Eric Dumazet
2007-04-14 9:39 ` [KJ] [PATCH " Eric Dumazet
2007-04-14 10:16 ` [KJ][PATCH " Milind Arun Choudhary
2007-04-14 10:28 ` [KJ] [PATCH " Milind Arun Choudhary
2007-04-14 10:16 ` [KJ][PATCH " Milind Arun Choudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4620A13F.6060502@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milindchoudhary@gmail.com \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.