All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milind Arun Choudhary <milindchoudhary@gmail.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: kernel-janitors@lists.osdl.org, nfs@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	trond.myklebust@fys.uio.no
Subject: Re: [KJ] [PATCH 03/04]use set_current_state in fs
Date: Sat, 14 Apr 2007 10:28:07 +0000	[thread overview]
Message-ID: <20070414101607.GA16817@arun.site> (raw)
In-Reply-To: <4620A13F.6060502@cosmosbay.com>

On 11:39 Sat 14 Apr     , Eric Dumazet wrote:
> Milind Arun Choudhary a écrit :
> >use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs
> Probably a dumb question, so please forgive me.
no.
you have a valid point

My bad :(
I should probably be enjoying my weekend outdoors..
breath some fresh air...
rather than sending such dumb patches..

ummmmmmmm
booting into  windows might help :)

> Why are you  forcing a memory barrier here, (and also on your other 
> patches).
> Is'nt a  __set_current_state(TASK_RUNNING); appropriate ?
it is..

would resend later

Njo!!!
-- 
Milind Arun Choudhary
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Milind Arun Choudhary <milindchoudhary@gmail.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: kernel-janitors@lists.osdl.org, nfs@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	trond.myklebust@fys.uio.no
Subject: Re: [KJ][PATCH 03/04]use set_current_state in fs
Date: Sat, 14 Apr 2007 15:46:07 +0530	[thread overview]
Message-ID: <20070414101607.GA16817@arun.site> (raw)
In-Reply-To: <4620A13F.6060502@cosmosbay.com>

On 11:39 Sat 14 Apr     , Eric Dumazet wrote:
> Milind Arun Choudhary a =E9crit :
> >use set_current_state(TASK_*) instead of current->state =3D TASK_*, =
in fs/nfs
> Probably a dumb question, so please forgive me.
no.
you have a valid point

My bad :(
I should probably be enjoying my weekend outdoors..
breath some fresh air...
rather than sending such dumb patches..

ummmmmmmm
booting into  windows might help :)

> Why are you  forcing a memory barrier here, (and also on your other=20
> patches).
> Is'nt a  __set_current_state(TASK_RUNNING); appropriate ?
it is..

would resend later

Njo!!!
--=20
Milind Arun Choudhary

WARNING: multiple messages have this Message-ID (diff)
From: Milind Arun Choudhary <milindchoudhary@gmail.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: kernel-janitors@lists.osdl.org, nfs@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	trond.myklebust@fys.uio.no
Subject: Re: [KJ][PATCH 03/04]use set_current_state in fs
Date: Sat, 14 Apr 2007 15:46:07 +0530	[thread overview]
Message-ID: <20070414101607.GA16817@arun.site> (raw)
In-Reply-To: <4620A13F.6060502@cosmosbay.com>

On 11:39 Sat 14 Apr     , Eric Dumazet wrote:
> Milind Arun Choudhary a écrit :
> >use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs
> Probably a dumb question, so please forgive me.
no.
you have a valid point

My bad :(
I should probably be enjoying my weekend outdoors..
breath some fresh air...
rather than sending such dumb patches..

ummmmmmmm
booting into  windows might help :)

> Why are you  forcing a memory barrier here, (and also on your other 
> patches).
> Is'nt a  __set_current_state(TASK_RUNNING); appropriate ?
it is..

would resend later

Njo!!!
-- 
Milind Arun Choudhary

  reply	other threads:[~2007-04-14 10:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-14  8:49 [KJ][PATCH 03/04]use set_current_state in fs Milind Arun Choudhary
2007-04-14  9:01 ` [KJ] [PATCH " Milind Arun Choudhary
2007-04-14  8:49 ` [KJ][PATCH " Milind Arun Choudhary
2007-04-14  9:39 ` [KJ] [PATCH " Eric Dumazet
2007-04-14  9:39   ` [KJ][PATCH " Eric Dumazet
2007-04-14  9:39   ` [KJ] [PATCH " Eric Dumazet
2007-04-14 10:16   ` Milind Arun Choudhary [this message]
2007-04-14 10:28     ` Milind Arun Choudhary
2007-04-14 10:16     ` [KJ][PATCH " Milind Arun Choudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070414101607.GA16817@arun.site \
    --to=milindchoudhary@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dada1@cosmosbay.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfs@lists.sourceforge.net \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.