[lm-sensors] kernel/hwmon todo

[lm-sensors] kernel/hwmon todo

[Mark M. Hoffman]

Hi everyone:

Here's a list of kernel patches which are not in Jean's queue[1] and which need
review.  I've only searched the mailing list archives back through March.  I'm
sure I've missed some, or if there are updated patches available for any of
these, please let me know.

Also, some of these patches need a primary reviewer.

[1] http://khali.linux-fr.org/devel/linux-2.6/jdelvare-hwmon/

[PATCH 1/2 RESEND] hwmon: new driver for SMSC DME1737
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019298.html
[PATCH 2/2 RESEND] hwmon: documentation for new SMSC DME1737 driver
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019299.html
primary reviewer: Hans de Goede

PATCH: hwmon-abituguru3-new-driver.patch: Add support for newer uGuru's
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019433.html
primary reviewer: Juerg Haefliger

[PATCH] Apple SMC driver - fix input device
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019462.html

[PATCH 1/2] Apple SMC driver - standardize and sanitize sysfs tree + minor features addition
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019519.html
[PATCH 2/2] Apple SMC driver - implement key enumeration
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019520.html

[PATCH] Add LM93 support
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019526.html
primary reviewer: mmh

Regards,

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[Mark M. Hoffman]

* Mark M. Hoffman <mhoffman@lightlink.com> [2007-04-15 12:13:02 -0400]:
> Hi everyone:
> 
> Here's a list of kernel patches which are not in Jean's queue[1] and which need
> review.  I've only searched the mailing list archives back through March.  I'm
> sure I've missed some, or if there are updated patches available for any of
> these, please let me know.
> 
> Also, some of these patches need a primary reviewer.
> 
> [1] http://khali.linux-fr.org/devel/linux-2.6/jdelvare-hwmon/
> 
> [PATCH 1/2 RESEND] hwmon: new driver for SMSC DME1737
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019298.html
> [PATCH 2/2 RESEND] hwmon: documentation for new SMSC DME1737 driver
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019299.html
> primary reviewer: Hans de Goede
> 
> PATCH: hwmon-abituguru3-new-driver.patch: Add support for newer uGuru's
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019433.html
> primary reviewer: Juerg Haefliger
> 
> [PATCH] Apple SMC driver - fix input device
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019462.html
> 
> [PATCH 1/2] Apple SMC driver - standardize and sanitize sysfs tree + minor features addition
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019519.html
> [PATCH 2/2] Apple SMC driver - implement key enumeration
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019520.html
> 
> [PATCH] Add LM93 support
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019526.html
> primary reviewer: mmh

[PATCH] THMC50 and ADM1022 support for 2.6 kernel (improved)
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019094.html

Regards,

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[Juerg Haefliger]

Hi Mark,


On 4/15/07, Mark M. Hoffman <mhoffman@lightlink.com> wrote:
> * Mark M. Hoffman <mhoffman@lightlink.com> [2007-04-15 12:13:02 -0400]:
> > Hi everyone:
> >
> > Here's a list of kernel patches which are not in Jean's queue[1] and which need
> > review.  I've only searched the mailing list archives back through March.  I'm
> > sure I've missed some, or if there are updated patches available for any of
> > these, please let me know.
> >
> > Also, some of these patches need a primary reviewer.
> >
> > [1] http://khali.linux-fr.org/devel/linux-2.6/jdelvare-hwmon/
> >
> > [PATCH 1/2 RESEND] hwmon: new driver for SMSC DME1737
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019298.html
> > [PATCH 2/2 RESEND] hwmon: documentation for new SMSC DME1737 driver
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019299.html
> > primary reviewer: Hans de Goede

Jean did a 2nd review on these two patches and I need to update and resend them.

...juerg


> > PATCH: hwmon-abituguru3-new-driver.patch: Add support for newer uGuru's
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019433.html
> > primary reviewer: Juerg Haefliger
> >
> > [PATCH] Apple SMC driver - fix input device
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019462.html
> >
> > [PATCH 1/2] Apple SMC driver - standardize and sanitize sysfs tree + minor features addition
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019519.html
> > [PATCH 2/2] Apple SMC driver - implement key enumeration
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019520.html
> >
> > [PATCH] Add LM93 support
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019526.html
> > primary reviewer: mmh
>
> [PATCH] THMC50 and ADM1022 support for 2.6 kernel (improved)
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019094.html
>
> Regards,
>
> --
> Mark M. Hoffman
> mhoffman@lightlink.com
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[Mark M. Hoffman]

Hi Juerg:

* Juerg Haefliger <juergh@gmail.com> [2007-04-15 10:49:49 -0700]:
> > > [PATCH 1/2 RESEND] hwmon: new driver for SMSC DME1737
> > > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019298.html
> > > [PATCH 2/2 RESEND] hwmon: documentation for new SMSC DME1737 driver
> > > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019299.html
> > > primary reviewer: Hans de Goede
> 
> Jean did a 2nd review on these two patches and I need to update and resend them.

ACK.  If you want them to go into 2.6.22 then they'll have to go through Jean.
I guess that Linus' 2.6.22 merge window will open pretty soon.

Regards,

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[Hans de Goede]

Hi Mark, All

First of all, Mark great to hear you're stepping in to become the Maintainer 
and many thanks for this.

Mark M. Hoffman wrote:
> Hi everyone:
> 
> Here's a list of kernel patches which are not in Jean's queue[1] and which need
> review.  I've only searched the mailing list archives back through March.  I'm
> sure I've missed some, or if there are updated patches available for any of
> these, please let me know.
> 

I think you've missed the admXXXX driver backported from 2.4 which was posted a
while ago.

> PATCH: hwmon-abituguru3-new-driver.patch: Add support for newer uGuru's
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019433.html
> primary reviewer: Juerg Haefliger
> 

The biggest problem with this patch currently is the discussion about the 
included chip model/revision/stepping table, which is (somewhat) needed because 
with the uguru being a software solution every motherboard essentially has its 
own version of the chip.

Jean didn't like this much because he believes this kinda info belongs in 
userspace. I've given a long reply to a mail of Jean where I explain why I 
decided to put the table in kernelspace and that I still believe this to be the 
right decision. Unfortunately that mail has gotten 0 replies.

Thanks & Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[David Hubbard]

Hi Mark,

On 4/15/07, Hans de Goede <j.w.r.degoede@hhs.nl> wrote:
> Hi Mark, All
>
> First of all, Mark great to hear you're stepping in to become the Maintainer
> and many thanks for this.

I second (third?) the thanks. I'd be happy to help out where I can (as
a reviewer of patches).

Also, I think you missed the patch I submitted to get rid of i2c-isa
in the w83627ehf driver. It needs a review, and then can be submitted
to the kernel.

David

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[Mark M. Hoffman]

Hi Hans:

* Hans de Goede <j.w.r.degoede@hhs.nl> [2007-04-15 21:46:07 +0200]:
> Hi Mark, All
> 
> First of all, Mark great to hear you're stepping in to become the Maintainer 
> and many thanks for this.
> 
> Mark M. Hoffman wrote:
> > Hi everyone:
> > 
> > Here's a list of kernel patches which are not in Jean's queue[1] and which need
> > review.  I've only searched the mailing list archives back through March.  I'm
> > sure I've missed some, or if there are updated patches available for any of
> > these, please let me know.
> > 
> 
> I think you've missed the admXXXX driver backported from 2.4 which was posted a
> while ago.

Err, I still can't find it.  Can you post a link please?

> > PATCH: hwmon-abituguru3-new-driver.patch: Add support for newer uGuru's
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019433.html
> > primary reviewer: Juerg Haefliger
> > 
> 
> The biggest problem with this patch currently is the discussion about the 
> included chip model/revision/stepping table, which is (somewhat) needed because 
> with the uguru being a software solution every motherboard essentially has its 
> own version of the chip.
> 
> Jean didn't like this much because he believes this kinda info belongs in 
> userspace. I've given a long reply to a mail of Jean where I explain why I 
> decided to put the table in kernelspace and that I still believe this to be the 
> right decision. Unfortunately that mail has gotten 0 replies.

Yes, I remember skimming those discussions.  I will reread that more closely
and reply in the appropriate thread... soonish.  Please be patient.  I can tell
you now that I am inclined to allow such a patch to spend some time in -mm to
either 1) work out the kinks of that approach, or else 2) demonstrate that
userspace would be better.

Regards,

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[Hans de Goede]

Mark M. Hoffman wrote:
> Hi Hans:
> 
> * Hans de Goede <j.w.r.degoede@hhs.nl> [2007-04-15 21:46:07 +0200]:
>> Hi Mark, All
>>
>> First of all, Mark great to hear you're stepping in to become the Maintainer 
>> and many thanks for this.
>>
>> Mark M. Hoffman wrote:
>>> Hi everyone:
>>>
>>> Here's a list of kernel patches which are not in Jean's queue[1] and which need
>>> review.  I've only searched the mailing list archives back through March.  I'm
>>> sure I've missed some, or if there are updated patches available for any of
>>> these, please let me know.
>>>
>> I think you've missed the admXXXX driver backported from 2.4 which was posted a
>> while ago.
> 
> Err, I still can't find it.  Can you post a link please?
> 

Its here:
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019094.html

>>> PATCH: hwmon-abituguru3-new-driver.patch: Add support for newer uGuru's
>>> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-April/019433.html
>>> primary reviewer: Juerg Haefliger
>>>
>> The biggest problem with this patch currently is the discussion about the 
>> included chip model/revision/stepping table, which is (somewhat) needed because 
>> with the uguru being a software solution every motherboard essentially has its 
>> own version of the chip.
>>
>> Jean didn't like this much because he believes this kinda info belongs in 
>> userspace. I've given a long reply to a mail of Jean where I explain why I 
>> decided to put the table in kernelspace and that I still believe this to be the 
>> right decision. Unfortunately that mail has gotten 0 replies.
> 
> Yes, I remember skimming those discussions.  I will reread that more closely
> and reply in the appropriate thread... soonish.  Please be patient.  I can tell
> you now that I am inclined to allow such a patch to spend some time in -mm to
> either 1) work out the kinks of that approach, or else 2) demonstrate that
> userspace would be better.
> 

Ok, notice though that there are no real kinks either way its just a design 
decision really. I'm pretty sure there are no kinks with the current table in 
driver variant, as it has been tested by several people on several different 
mobo's.

As far as I can currently oversee the userspace variant, that shouldn't have 
any issues either, but IMHO is ugly as it creates sysfs files which aren't 
there which then will get picked up by the dynfs support, only to finally get 
ignored by ignore statements in sensor.conf, why create them in the first place 
then?

Anyways this has already been said in the appropriate thread. SO I'm looking 
forward to your reply there. Notice that the thread is "hidden" under the 
subject of "xxx_label sysfs file proposal" or something like that.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[Riku Voipio]

Mark M. Hoffman wrote:
> Hi everyone:
>
> Here's a list of kernel patches which are not in Jean's queue[1] and which need
> review.  I've only searched the mailing list archives back through March.  I'm
> sure I've missed some, or if there are updated patches available for any of
> these, please let me know.
>
>   
[Patch] Add Fintek F75375S driver
http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019107.html

Reviewing would be really appreciated.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[Mark M. Hoffman]

Hi David:

* David Hubbard <david.c.hubbard@gmail.com> [2007-04-15 16:05:39 -0600]:
> Hi Mark,
> 
> On 4/15/07, Hans de Goede <j.w.r.degoede@hhs.nl> wrote:
> > Hi Mark, All
> >
> > First of all, Mark great to hear you're stepping in to become the Maintainer
> > and many thanks for this.
> 
> I second (third?) the thanks. I'd be happy to help out where I can (as
> a reviewer of patches).
> 
> Also, I think you missed the patch I submitted to get rid of i2c-isa
> in the w83627ehf driver. It needs a review, and then can be submitted
> to the kernel.

Sorry, I still can't find this one.  Link please?  Or just resubmit it.

Thanks & regards,

-- 
Mark M. Hoffman
mhoffman@lightlink.com


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[Jean Delvare]

On Sun, 22 Apr 2007 15:15:05 -0400, Mark M. Hoffman wrote:
> * David Hubbard <david.c.hubbard@gmail.com> [2007-04-15 16:05:39 -0600]:
> > Also, I think you missed the patch I submitted to get rid of i2c-isa
> > in the w83627ehf driver. It needs a review, and then can be submitted
> > to the kernel.
> 
> Sorry, I still can't find this one.  Link please?  Or just resubmit it.

http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019363.html

I'd like to see this patch applied quickly so that it makes it into
2.6.22. As Rudolf seems to be busy these days, I'll review it myself
later today.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[David Hubbard]

Hi Jean, Mark,

> > * David Hubbard <david.c.hubbard@gmail.com> [2007-04-15 16:05:39 -0600]:
> > > Also, I think you missed the patch I submitted to get rid of i2c-isa
> > > in the w83627ehf driver. It needs a review, and then can be submitted
> > > to the kernel.
> >
> > Sorry, I still can't find this one.  Link please?  Or just resubmit it.
>
> http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019363.html
>
> I'd like to see this patch applied quickly so that it makes it into
> 2.6.22. As Rudolf seems to be busy these days, I'll review it myself
> later today.

What is the close date for patches to make it into 2.6.22? Jean points
out some good areas for me to change and I'll need until Saturday to
get them tested.

Thanks,
David

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[Jean Delvare]

Hi David,

On Tue, 24 Apr 2007 17:59:56 -0700, David Hubbard wrote:
> Hi Jean, Mark,
> 
> > > * David Hubbard <david.c.hubbard@gmail.com> [2007-04-15 16:05:39 -0600]:
> > > > Also, I think you missed the patch I submitted to get rid of i2c-isa
> > > > in the w83627ehf driver. It needs a review, and then can be submitted
> > > > to the kernel.
> > >
> > > Sorry, I still can't find this one.  Link please?  Or just resubmit it.
> >
> > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019363.html
> >
> > I'd like to see this patch applied quickly so that it makes it into
> > 2.6.22. As Rudolf seems to be busy these days, I'll review it myself
> > later today.
> 
> What is the close date for patches to make it into 2.6.22? Jean points
> out some good areas for me to change and I'll need until Saturday to
> get them tested.

The close date was "the day Linus releases 2.6.21", which happens to be
today. So the w83627ehf driver conversion won't make it into 2.6.22.
This doesn't really matter anyway, as there are 5 other i2c-isa-based
drivers which are not converted yet, so I can't kill i2c-isa before
2.6.23.

So please rework the w83627ehf patch according to my comments as your
time permits, resubmit it, it'll go to -mm early and will get some
testing there before 2.6.23.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] kernel/hwmon todo

[David Hubbard]

Hi Jean,

]> On Tue, 24 Apr 2007 17:59:56 -0700, David Hubbard wrote:
> > Hi Jean, Mark,
> >
> > > > * David Hubbard <david.c.hubbard@gmail.com> [2007-04-15 16:05:39 -0600]:
> > > > > Also, I think you missed the patch I submitted to get rid of i2c-isa
> > > > > in the w83627ehf driver. It needs a review, and then can be submitted
> > > > > to the kernel.
> > > >
> > > > Sorry, I still can't find this one.  Link please?  Or just resubmit it.
> > >
> > > http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019363.html
> > >
> > > I'd like to see this patch applied quickly so that it makes it into
> > > 2.6.22. As Rudolf seems to be busy these days, I'll review it myself
> > > later today.
> >
> > What is the close date for patches to make it into 2.6.22? Jean points
> > out some good areas for me to change and I'll need until Saturday to
> > get them tested.
>
> The close date was "the day Linus releases 2.6.21", which happens to be
> today. So the w83627ehf driver conversion won't make it into 2.6.22.
> This doesn't really matter anyway, as there are 5 other i2c-isa-based
> drivers which are not converted yet, so I can't kill i2c-isa before
> 2.6.23.
>
> So please rework the w83627ehf patch according to my comments as your
> time permits, resubmit it, it'll go to -mm early and will get some
> testing there before 2.6.23.

Thanks!

David

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors