[PATCH] hid: hid bus prototype 20070416

[PATCH] hid: hid bus prototype 20070416

[Li Yu]

[-- Attachment #1: Type: text/plain, Size: 1963 bytes --]

HID bus prototype 20070416

Changelog since 20070408:

    1. HID/Bluetooth work, however we can not forcely remove hidp.ko,
elsewise the kernel oops. It is tested by one Logitech mouse, thanks
yanghong here again. The reason of oops is the user process trap into
kernel by ioctl() on hidp socket, but this implementation code already
be removed out of kernel. Unfortunately, I found the original hidp.ko
also have this problem. It seem we can not forcely close that socket
without touch VFS code.

    2. API Renames, e.g. register_hid_device() ==> hid_register_device().

    3. Add HID_QUIRKS_SKIP.

    4. Other refactorings or cleans.

    NOTE: This patch is only for review. so it just is prototype.

 drivers/hid/Kconfig            |    2
 drivers/hid/Makefile           |   22 +
 drivers/hid/hid-al.c           |  505 +++++++++++++++++++++++++++++++++++++++++
 drivers/hid/hid-core.c         |  154 +++++++++---
 drivers/hid/hid-input.c        |  371 ++++++++++++++----------------
 drivers/hid/hid-inter.h        |   26 ++
 drivers/hid/hidraw.c           |   60 +++-
 drivers/hid/usbhid/Kconfig     |   38 +--
 drivers/hid/usbhid/Makefile    |   42 +--
 drivers/hid/usbhid/hid-core.c  |  261 ++++++++++++---------
 drivers/hid/usbhid/hid-ff.c    |   90 -------
 drivers/hid/usbhid/hid-lgff.c  |   55 ++++
 drivers/hid/usbhid/hid-pb.c    |  334 +++++++++++++++++++++++++++
 drivers/hid/usbhid/hid-pidff.c |   36 ++
 drivers/hid/usbhid/hid-plff.c  |   50 +++-
 drivers/hid/usbhid/hid-tmff.c  |   50 +++-
 drivers/hid/usbhid/hid-zpff.c  |   52 ++++
 drivers/hid/usbhid/hiddev.c    |   95 ++++---
 drivers/hid/usbhid/usbhid.h    |    4
 include/linux/hid.h            |  193 ++++++++++-----
 include/linux/hiddev.h         |   18 -
 include/linux/hidraw.h         |   14 -
 include/linux/input.h          |    2
 net/bluetooth/hidp/Makefile    |   12
 net/bluetooth/hidp/core.c      |  129 +++++++---
 25 files changed, 1940 insertions(+), 675 deletions(-)

[-- Attachment #2: hidbus-070416.patch.gz --]
[-- Type: application/x-gzip, Size: 25025 bytes --]

Re: [PATCH] hid: hid bus prototype 20070416

[Jiri Kosina]

On Mon, 16 Apr 2007, Li Yu wrote:

> HID bus prototype 20070416

Hi Li,

thanks for taking care. Well, the patch is quite huge, do you think you 
could split it into separate independent parts (use quilt or something 
similar for patch management) which could be reviewed independently?

As the code changes are often quite non-trivial, layering is changed, 
lots of files are touched, etc. it would help a lot.

Notes from a quick skim through the patch:

- it seems that you accidentaly deleted the newly added quirk for
   mightymouse in the bluetooth hid code?
- what is the point behind HID_QUIRK_SKIP? Why doesn't HID_QUIRK_IGNORE
   suffice? And why is it defined in so strange way:

@@ -270,6 +271,7 @@ struct hid_item {
  #define HID_QUIRK_LOGITECH_DESCRIPTOR          0x00100000
  #define HID_QUIRK_DUPLICATE_USAGES             0x00200000
  #define HID_QUIRK_RESET_LEDS                   0x00400000
+#define HID_QUIRK_SKIP                         0x80000000

- there are bunches of some easy codingstyle issues (spaces around '=',
   etc)

But doing really thorough review is quite hard, as the patch contains lots 
of unrelated changes. I'll look at it a little bit more, but when you send 
a broken-out version with separate changes, that'd be great.

Thanks,

-- 
Jiri Kosina