From: Jerry Van Baren <gvb.linuxppc.dev@gmail.com>
To: Jon Loeliger <jdl@jdl.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
u-boot-users <u-boot-users@lists.sourceforge.net>
Subject: Re: [U-Boot-Users] [PATCH: dtc take 2] Assemble the blob in memory before writing it out.
Date: Thu, 19 Apr 2007 19:45:45 -0400 [thread overview]
Message-ID: <4627FF29.1050409@gmail.com> (raw)
In-Reply-To: <E1HefA8-0008Tl-VA@jdl.com>
Jon Loeliger wrote:
> So, like, the other day Jerry Van Baren mumbled:
>> Patch #2 and #3...
>> [PATCH dtc take 3] Fix reserve map output for asm format.
>> Tue, 17 Apr 2007 18:14:41 -0400
>> [PATCH: dtc take 2] Assemble the blob in memory before writing it out.
>> Wed, 18 Apr 2007 21:59:51 -0400
>
> [snip]
>
>> AAAARGH! Sorry, I see I left a debug statement in flattree.c around
>> line 390:
>
>> Your option:
>> 1) Take the last two patches as is and remove the fprintf yourself
>
>
> Applied #2 and #3 listed above.
> Cleaned out the debug fprintf().
>
> Thanks,
> jdl
Oh oh, does NOT look good. I lost the rewrite of the header size with
the new, bigger size when -S is specified.
Ahh, I think I see the problem, sloppy programming bites me again.
Modifying "bph.totalsize" worked before I changed to the struct data
blob. Grrrr. I need to figure out the padding and apply it to the bph
before starting the blob assembly. Before the line:
blob = data_append_data(blob, &bph, sizeof(bph));
Patch will take a bit because I have a meeting to go to :-(.
sorry,
gvb
prev parent reply other threads:[~2007-04-19 23:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 1:59 [PATCH: dtc take 2] Assemble the blob in memory before writing it out Jerry Van Baren
2007-04-19 2:05 ` David Gibson
2007-04-19 18:27 ` Jon Loeliger
2007-04-19 18:49 ` [U-Boot-Users] " Jerry Van Baren
2007-04-19 19:03 ` Jon Loeliger
2007-04-19 22:31 ` Jon Loeliger
2007-04-19 23:45 ` Jerry Van Baren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4627FF29.1050409@gmail.com \
--to=gvb.linuxppc.dev@gmail.com \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=u-boot-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.