All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Sieka <tur@semihalf.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, linux-serial@vger.kernel.org,
	Sylvain Munaut <tnt@246tnt.com>, Wolfgang Denk <wd@denx.de>
Subject: Re: [PATCH] Don't shutdown TX on mpc5200 serial port if it is a console
Date: Fri, 20 Apr 2007 15:28:04 +0200	[thread overview]
Message-ID: <4628BFE4.2090801@semihalf.com> (raw)
In-Reply-To: <11770117743675-git-send-email-grant.likely@secretlab.ca>

Grant Likely wrote:
> If the serial port gets shut down, then console output stalls.  9 out
> of 10 kernel hackers agree, this is a bad thing.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> 
> Wolfgang, please verify this new patch.  Sylvain rightly pointed out that
> RX and interrupts should be turned off regardless.  If it works for you,
> please reply with a Signed-of-by line.

Patch verified on a MPC5200B-based board.

Signed-off-by: Bartlomiej Sieka <tur@semihalf.com>


Regards,
Bartlomiej

WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Sieka <tur@semihalf.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] Don't shutdown TX on mpc5200 serial port if it is a console
Date: Fri, 20 Apr 2007 15:28:04 +0200	[thread overview]
Message-ID: <4628BFE4.2090801@semihalf.com> (raw)
In-Reply-To: <11770117743675-git-send-email-grant.likely@secretlab.ca>

Grant Likely wrote:
> If the serial port gets shut down, then console output stalls.  9 out
> of 10 kernel hackers agree, this is a bad thing.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> 
> Wolfgang, please verify this new patch.  Sylvain rightly pointed out that
> RX and interrupts should be turned off regardless.  If it works for you,
> please reply with a Signed-of-by line.

Patch verified on a MPC5200B-based board.

Signed-off-by: Bartlomiej Sieka <tur@semihalf.com>


Regards,
Bartlomiej

  reply	other threads:[~2007-04-20 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-19 19:42 [PATCH] Don't shutdown TX on mpc5200 serial port if it is a console Grant Likely
2007-04-19 19:42 ` Grant Likely
2007-04-20 13:28 ` Bartlomiej Sieka [this message]
2007-04-20 13:28   ` Bartlomiej Sieka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4628BFE4.2090801@semihalf.com \
    --to=tur@semihalf.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-serial@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=tnt@246tnt.com \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.