All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Caulfield <pcaulfie@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [DLM][PATCH] lowcomms init fixes
Date: Mon, 23 Apr 2007 11:19:52 +0100	[thread overview]
Message-ID: <462C8848.7060102@redhat.com> (raw)
In-Reply-To: <20070420225100.GE22226@korben.rdu.redhat.com>

Thanks for finding & fixing those bugs Josef.
I've changed the patch a little, making the comparison always <= max_nodeid, I
prefer max_modeid to be what it says it as and not 1 more than the max node ID.

I'm a little concerned about the need for idr_init() in lowcomms_close(). Surely
if the idr was properly cleaned out it would not be necessary - though somehow
it seems to be, Do you know what's actually happening here ?

Anyway, here's the modified patch. it seems to work for me, but I'd be grateful
if you could run it through your tests too, cos I'm supposed to be working on
something else@the moment!

Steve, can you wait till Josef has tested this patch before adding it to the git
tree? thanks.

--
Patrick

Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street,
Windsor, Berkshire, SL4 ITE, UK.
Registered in England and Wales under Company Registration No. 3798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lowcomms-fix.patch
Type: text/x-patch
Size: 2509 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070423/dea123b8/attachment.bin>

  reply	other threads:[~2007-04-23 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-20 20:25 [Cluster-devel] [DLM][PATCH] lowcomms init fixes Josef Bacik
2007-04-20 22:51 ` Josef Bacik
2007-04-23 10:19   ` Patrick Caulfield [this message]
2007-04-23 15:15     ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=462C8848.7060102@redhat.com \
    --to=pcaulfie@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.