From: Patrick McHardy <kaber@trash.net>
To: "Jorge Boncompte [DTI2]" <jorge@dti2.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] xx_nat_proto_gre: gre_key returns wrong pointer
Date: Tue, 24 Apr 2007 14:50:37 +0200 [thread overview]
Message-ID: <462DFD1D.1060706@trash.net> (raw)
In-Reply-To: <00c501c7829e$6209edd0$061010ac@intranet.dti2.net>
Jorge Boncompte [DTI2] wrote:
> While porting some changes of the 2.6.21-rc7 pptp/proto_gre conntrack
> and nat modules to a 2.4.32 kernel I noticed that the gre_key function
> returns a wrong pointer to the GRE key of a version 0 packet. I fixed it
> the way below but I don't know if it is right way. The gre_csum function
> seems to have the same problem. If the problem is real and the solution
> right I can resend with a signed-off line.
Good catch. I think what it should do is not touch the key/checksum of
version 0 GRE packets at all since the intention is to behave identical
to nf_conntrack_proto_generic/nf_nat_proto_unknown in that case.
Its a bit more complicated to do this because we also need to avoid
altering the tuple in gre_unique_tuple. If you want to give it a try
please go ahead, otherwise I can look into it.
next prev parent reply other threads:[~2007-04-24 12:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 16:18 [PATCH] xx_nat_proto_gre: gre_key returns wrong pointer Jorge Boncompte [DTI2]
2007-04-24 12:50 ` Patrick McHardy [this message]
2007-04-26 17:34 ` Jorge Boncompte [DTI2]
2007-04-27 11:21 ` Patrick McHardy
2007-04-27 11:47 ` [PATCH] xx_nat_proto_gre: do not modify/corrupt GREv0 packets thought NAT Jorge Boncompte [DTI2]
2007-05-02 12:25 ` Patrick McHardy
2007-05-02 13:21 ` Jorge Boncompte [DTI2]
2007-05-02 13:23 ` Patrick McHardy
2007-05-02 13:48 ` Jorge Boncompte [DTI2]
2007-05-02 13:52 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462DFD1D.1060706@trash.net \
--to=kaber@trash.net \
--cc=jorge@dti2.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.