From: Patrick McHardy <kaber@trash.net>
To: "Jorge Boncompte [DTI2]" <jorge@dti2.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] xx_nat_proto_gre: do not modify/corrupt GREv0 packets thought NAT
Date: Wed, 02 May 2007 14:25:27 +0200 [thread overview]
Message-ID: <46388337.3060800@trash.net> (raw)
In-Reply-To: <00ef01c788c1$e32a62e0$061010ac@intranet.dti2.net>
Jorge Boncompte [DTI2] wrote:
> While porting some changes of the 2.6.21-rc7 pptp/proto_gre conntrack
> and nat modules to a 2.4.32 kernel I noticed that the gre_key function
> returns a wrong pointer to the GRE key of a version 0 packet thus
> corrupting
> the packet payload.
> The intended behaviour for GREv0 packets is to act like
> nf_conntrack_proto_generic/nf_nat_proto_unknown so I have ripped the
> offending functions (not used anymore) and modified the xx_nat_proto_gre
> modules to not touch version 0 (non PPTP) packets.
Applied, thanks. I removed the FIXME though since its the intended
behaviour and not something that needs to be fixed. I'll push it
to -stable as well.
next prev parent reply other threads:[~2007-05-02 12:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 16:18 [PATCH] xx_nat_proto_gre: gre_key returns wrong pointer Jorge Boncompte [DTI2]
2007-04-24 12:50 ` Patrick McHardy
2007-04-26 17:34 ` Jorge Boncompte [DTI2]
2007-04-27 11:21 ` Patrick McHardy
2007-04-27 11:47 ` [PATCH] xx_nat_proto_gre: do not modify/corrupt GREv0 packets thought NAT Jorge Boncompte [DTI2]
2007-05-02 12:25 ` Patrick McHardy [this message]
2007-05-02 13:21 ` Jorge Boncompte [DTI2]
2007-05-02 13:23 ` Patrick McHardy
2007-05-02 13:48 ` Jorge Boncompte [DTI2]
2007-05-02 13:52 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46388337.3060800@trash.net \
--to=kaber@trash.net \
--cc=jorge@dti2.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.