* dead CONFIG_ variables: net/ipv4/
@ 2007-05-02 21:15 Robert P. J. Day
2007-05-03 3:23 ` Patrick McHardy
2007-05-29 20:10 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Robert P. J. Day @ 2007-05-02 21:15 UTC (permalink / raw)
To: Linux Kernel Mailing List
again, this list contains some CONFIG_ variables that aren't
technically dead, but *really* should be renamed to not be confused
with Kconfig variables. there are, however, legitimately dead ones in
the following in places:
$ ../dead_config.sh net/ipv4
========== IP_FIB_TRIE_STATS ==========
net/ipv4/fib_trie.c:#undef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
net/ipv4/fib_trie.c:#endif /* CONFIG_IP_FIB_TRIE_STATS */
========== IP_NF_NAT ==========
net/ipv4/netfilter/Kconfig:# If they want FTP, set to $CONFIG_IP_NF_NAT (m or y),
net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c:#if !defined(CONFIG_IP_NF_NAT) && !defined(CONFIG_IP_NF_NAT_MODULE)
net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c:#if !defined(CONFIG_IP_NF_NAT) && !defined(CONFIG_IP_NF_NAT_MODULE)
========== IP_NOSIOCRT ==========
net/ipv4/fib_frontend.c:#ifndef CONFIG_IP_NOSIOCRT
========== IP_PIMSM ==========
net/ipv4/ipmr.c:#define CONFIG_IP_PIMSM 1
net/ipv4/ipmr.c:#ifdef CONFIG_IP_PIMSM
net/ipv4/ipmr.c:#ifdef CONFIG_IP_PIMSM
net/ipv4/ipmr.c:#ifdef CONFIG_IP_PIMSM
net/ipv4/ipmr.c:#ifdef CONFIG_IP_PIMSM
net/ipv4/ipmr.c:#ifdef CONFIG_IP_PIMSM
net/ipv4/ipmr.c:#ifdef CONFIG_IP_PIMSM
net/ipv4/ipmr.c:#ifdef CONFIG_IP_PIMSM
net/ipv4/ipmr.c:#ifdef CONFIG_IP_PIMSM
net/ipv4/ipmr.c:#ifdef CONFIG_IP_PIMSM
net/ipv4/ipmr.c:#ifdef CONFIG_IP_PIMSM
========== IP_ROUTE_PERVASIVE ==========
net/ipv4/fib_semantics.c:#ifdef CONFIG_IP_ROUTE_PERVASIVE
========== IP_VS_DH_TAB_BITS ==========
net/ipv4/ipvs/ip_vs_dh.c:#ifndef CONFIG_IP_VS_DH_TAB_BITS
net/ipv4/ipvs/ip_vs_dh.c:#define CONFIG_IP_VS_DH_TAB_BITS 8
net/ipv4/ipvs/ip_vs_dh.c:#define IP_VS_DH_TAB_BITS CONFIG_IP_VS_DH_TAB_BITS
net/ipv4/ipvs/ip_vs_dh.c:#define IP_VS_DH_TAB_BITS CONFIG_IP_VS_DH_TAB_BITS
net/ipv4/ipvs/ip_vs_dh.c:#define IP_VS_DH_TAB_SIZE (1 << IP_VS_DH_TAB_BITS)
========== IP_VS_LBLCR_DEBUG ==========
net/ipv4/ipvs/ip_vs_lblcr.c:#ifdef CONFIG_IP_VS_LBLCR_DEBUG
net/ipv4/ipvs/ip_vs_lblcr.c:#ifdef CONFIG_IP_VS_LBLCR_DEBUG
net/ipv4/ipvs/ip_vs_lblcr.c:#ifdef CONFIG_IP_VS_LBLCR_DEBUG
net/ipv4/ipvs/ip_vs_lblcr.c:#ifdef CONFIG_IP_VS_LBLCR_DEBUG
========== IP_VS_LBLCR_TAB_BITS ==========
net/ipv4/ipvs/ip_vs_lblcr.c:#ifndef CONFIG_IP_VS_LBLCR_TAB_BITS
net/ipv4/ipvs/ip_vs_lblcr.c:#define CONFIG_IP_VS_LBLCR_TAB_BITS 10
net/ipv4/ipvs/ip_vs_lblcr.c:#define IP_VS_LBLCR_TAB_BITS CONFIG_IP_VS_LBLCR_TAB_BITS
net/ipv4/ipvs/ip_vs_lblcr.c:#define IP_VS_LBLCR_TAB_BITS CONFIG_IP_VS_LBLCR_TAB_BITS
net/ipv4/ipvs/ip_vs_lblcr.c:#define IP_VS_LBLCR_TAB_SIZE (1 << IP_VS_LBLCR_TAB_BITS)
========== IP_VS_LBLC_TAB_BITS ==========
net/ipv4/ipvs/ip_vs_lblc.c:#ifndef CONFIG_IP_VS_LBLC_TAB_BITS
net/ipv4/ipvs/ip_vs_lblc.c:#define CONFIG_IP_VS_LBLC_TAB_BITS 10
net/ipv4/ipvs/ip_vs_lblc.c:#define IP_VS_LBLC_TAB_BITS CONFIG_IP_VS_LBLC_TAB_BITS
net/ipv4/ipvs/ip_vs_lblc.c:#define IP_VS_LBLC_TAB_BITS CONFIG_IP_VS_LBLC_TAB_BITS
net/ipv4/ipvs/ip_vs_lblc.c:#define IP_VS_LBLC_TAB_SIZE (1 << IP_VS_LBLC_TAB_BITS)
========== IP_VS_SH_TAB_BITS ==========
net/ipv4/ipvs/ip_vs_sh.c:#ifndef CONFIG_IP_VS_SH_TAB_BITS
net/ipv4/ipvs/ip_vs_sh.c:#define CONFIG_IP_VS_SH_TAB_BITS 8
net/ipv4/ipvs/ip_vs_sh.c:#define IP_VS_SH_TAB_BITS CONFIG_IP_VS_SH_TAB_BITS
net/ipv4/ipvs/ip_vs_sh.c:#define IP_VS_SH_TAB_BITS CONFIG_IP_VS_SH_TAB_BITS
net/ipv4/ipvs/ip_vs_sh.c:#define IP_VS_SH_TAB_SIZE (1 << IP_VS_SH_TAB_BITS)
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dead CONFIG_ variables: net/ipv4/
2007-05-02 21:15 dead CONFIG_ variables: net/ipv4/ Robert P. J. Day
@ 2007-05-03 3:23 ` Patrick McHardy
2007-05-29 20:10 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Patrick McHardy @ 2007-05-03 3:23 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux Kernel Mailing List, Kernel Netdev Mailing List
Robert P. J. Day wrote:
> again, this list contains some CONFIG_ variables that aren't
> technically dead, but *really* should be renamed to not be confused
> with Kconfig variables. there are, however, legitimately dead ones in
> the following in places:
Please post to netdev for networking related things.
> $ ../dead_config.sh net/ipv4
> ========== IP_NF_NAT ==========
> net/ipv4/netfilter/Kconfig:# If they want FTP, set to $CONFIG_IP_NF_NAT (m or y),
> net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c:#if !defined(CONFIG_IP_NF_NAT) && !defined(CONFIG_IP_NF_NAT_MODULE)
> net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c:#if !defined(CONFIG_IP_NF_NAT) && !defined(CONFIG_IP_NF_NAT_MODULE)
This one is a bug, thanks. Could you post results from the
other net/ subdirectories please?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dead CONFIG_ variables: net/ipv4/
2007-05-02 21:15 dead CONFIG_ variables: net/ipv4/ Robert P. J. Day
2007-05-03 3:23 ` Patrick McHardy
@ 2007-05-29 20:10 ` David Miller
2007-05-29 20:14 ` Robert P. J. Day
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2007-05-29 20:10 UTC (permalink / raw)
To: rpjday; +Cc: linux-kernel
From: "Robert P. J. Day" <rpjday@mindspring.com>
Date: Wed, 2 May 2007 17:15:01 -0400 (EDT)
>
> again, this list contains some CONFIG_ variables that aren't
> technically dead, but *really* should be renamed to not be confused
> with Kconfig variables. there are, however, legitimately dead ones in
> the following in places:
>
> $ ../dead_config.sh net/ipv4
> ========== IP_FIB_TRIE_STATS ==========
> net/ipv4/fib_trie.c:#undef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#endif /* CONFIG_IP_FIB_TRIE_STATS */
Robert Olsson uses this for statistics collection by turning
that #undef there into a #define and other developers could
use this too.
Therefore I'm reluctant to remove this for now.
> ========== IP_NOSIOCRT ==========
> net/ipv4/fib_frontend.c:#ifndef CONFIG_IP_NOSIOCRT
Definitely bogus, deleted.
> ========== IP_PIMSM ==========
> net/ipv4/ipmr.c:#define CONFIG_IP_PIMSM 1
This one isn't bogus, it is a shorthand and is set when
either CONFIG_IP_PIMSM_V1 or CONFIG_IP_PIMSM_V2 are set.
> ========== IP_ROUTE_PERVASIVE ==========
> net/ipv4/fib_semantics.c:#ifdef CONFIG_IP_ROUTE_PERVASIVE
This seems to be for an intended feature to allow control of
recursive gateway lookups, I'm not touching this one :-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: dead CONFIG_ variables: net/ipv4/
2007-05-29 20:10 ` David Miller
@ 2007-05-29 20:14 ` Robert P. J. Day
0 siblings, 0 replies; 4+ messages in thread
From: Robert P. J. Day @ 2007-05-29 20:14 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel
On Tue, 29 May 2007, David Miller wrote:
> From: "Robert P. J. Day" <rpjday@mindspring.com>
> Date: Wed, 2 May 2007 17:15:01 -0400 (EDT)
>
> >
> > again, this list contains some CONFIG_ variables that aren't
> > technically dead, but *really* should be renamed to not be confused
> > with Kconfig variables. there are, however, legitimately dead ones in
> > the following in places:
> >
> > $ ../dead_config.sh net/ipv4
> > ========== IP_FIB_TRIE_STATS ==========
> > net/ipv4/fib_trie.c:#undef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> > net/ipv4/fib_trie.c:#endif /* CONFIG_IP_FIB_TRIE_STATS */
>
> Robert Olsson uses this for statistics collection by turning
> that #undef there into a #define and other developers could
> use this too.
>
> Therefore I'm reluctant to remove this for now.
there's lots of that sort of thing in the kernel -- the only point i'd
make is that it seems typical to reserve the prefix "CONFIG_" strictly
for those variables that are set via Kconfig files. it just makes the
namespace cleaner, that's all. otherwise, that variable is going to
come up continually in any script like mine that's searching for
possible dead Kconfig variables.
> > ========== IP_PIMSM ==========
> > net/ipv4/ipmr.c:#define CONFIG_IP_PIMSM 1
as is this one, etc, etc.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-05-29 20:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-02 21:15 dead CONFIG_ variables: net/ipv4/ Robert P. J. Day
2007-05-03 3:23 ` Patrick McHardy
2007-05-29 20:10 ` David Miller
2007-05-29 20:14 ` Robert P. J. Day
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.