All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] KBUILD: Drop tty.h and isicom.h from include/linux/Kbuild.
Date: Fri, 04 May 2007 18:52:33 +0200	[thread overview]
Message-ID: <463B64D1.9080007@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705041242490.27723@localhost.localdomain>

Cc: Alan Cox

Robert P. J. Day napsal(a):
> Drop the entries for tty.h and isicom.h from the include/linux/Kbuild
> file, since "make headers_install" just generates empty files for
> them.
> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

Acked-by: Jiri Slaby <jirislaby@gmail.com> (isicom part)

Unsure for tty.h -- won't this break too much of apps' builds?

> ---
> 
> i've submitted a patch to do this at least twice before.  is there
> some reason those empty generated header are being so tenacious?
> 
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index 4ff0f57..63de91a 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -239,7 +239,6 @@ unifdef-y += ipv6_route.h
>  unifdef-y += isdn.h
>  unifdef-y += isdnif.h
>  unifdef-y += isdn_ppp.h
> -unifdef-y += isicom.h
>  unifdef-y += jbd.h
>  unifdef-y += joystick.h
>  unifdef-y += kdev_t.h
> @@ -320,7 +319,6 @@ unifdef-y += sysctl.h
>  unifdef-y += tcp.h
>  unifdef-y += time.h
>  unifdef-y += timex.h
> -unifdef-y += tty.h
>  unifdef-y += types.h
>  unifdef-y += udf_fs_i.h
>  unifdef-y += udp.h

regards,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E

  reply	other threads:[~2007-05-04 16:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-04 16:47 [PATCH] KBUILD: Drop tty.h and isicom.h from include/linux/Kbuild Robert P. J. Day
2007-05-04 16:52 ` Jiri Slaby [this message]
2007-05-04 17:02   ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=463B64D1.9080007@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.