* [PATCH] KBUILD: Drop tty.h and isicom.h from include/linux/Kbuild.
@ 2007-05-04 16:47 Robert P. J. Day
2007-05-04 16:52 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2007-05-04 16:47 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Andrew Morton, jirislaby
Drop the entries for tty.h and isicom.h from the include/linux/Kbuild
file, since "make headers_install" just generates empty files for
them.
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
---
i've submitted a patch to do this at least twice before. is there
some reason those empty generated header are being so tenacious?
diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index 4ff0f57..63de91a 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -239,7 +239,6 @@ unifdef-y += ipv6_route.h
unifdef-y += isdn.h
unifdef-y += isdnif.h
unifdef-y += isdn_ppp.h
-unifdef-y += isicom.h
unifdef-y += jbd.h
unifdef-y += joystick.h
unifdef-y += kdev_t.h
@@ -320,7 +319,6 @@ unifdef-y += sysctl.h
unifdef-y += tcp.h
unifdef-y += time.h
unifdef-y += timex.h
-unifdef-y += tty.h
unifdef-y += types.h
unifdef-y += udf_fs_i.h
unifdef-y += udp.h
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KBUILD: Drop tty.h and isicom.h from include/linux/Kbuild.
2007-05-04 16:47 [PATCH] KBUILD: Drop tty.h and isicom.h from include/linux/Kbuild Robert P. J. Day
@ 2007-05-04 16:52 ` Jiri Slaby
2007-05-04 17:02 ` Robert P. J. Day
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2007-05-04 16:52 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Linux Kernel Mailing List, Andrew Morton, Alan Cox
Cc: Alan Cox
Robert P. J. Day napsal(a):
> Drop the entries for tty.h and isicom.h from the include/linux/Kbuild
> file, since "make headers_install" just generates empty files for
> them.
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
Acked-by: Jiri Slaby <jirislaby@gmail.com> (isicom part)
Unsure for tty.h -- won't this break too much of apps' builds?
> ---
>
> i've submitted a patch to do this at least twice before. is there
> some reason those empty generated header are being so tenacious?
>
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index 4ff0f57..63de91a 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -239,7 +239,6 @@ unifdef-y += ipv6_route.h
> unifdef-y += isdn.h
> unifdef-y += isdnif.h
> unifdef-y += isdn_ppp.h
> -unifdef-y += isicom.h
> unifdef-y += jbd.h
> unifdef-y += joystick.h
> unifdef-y += kdev_t.h
> @@ -320,7 +319,6 @@ unifdef-y += sysctl.h
> unifdef-y += tcp.h
> unifdef-y += time.h
> unifdef-y += timex.h
> -unifdef-y += tty.h
> unifdef-y += types.h
> unifdef-y += udf_fs_i.h
> unifdef-y += udp.h
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KBUILD: Drop tty.h and isicom.h from include/linux/Kbuild.
2007-05-04 16:52 ` Jiri Slaby
@ 2007-05-04 17:02 ` Robert P. J. Day
0 siblings, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2007-05-04 17:02 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Linux Kernel Mailing List, Andrew Morton, Alan Cox
On Fri, 4 May 2007, Jiri Slaby wrote:
> Cc: Alan Cox
>
> Robert P. J. Day napsal(a):
> > Drop the entries for tty.h and isicom.h from the include/linux/Kbuild
> > file, since "make headers_install" just generates empty files for
> > them.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> Acked-by: Jiri Slaby <jirislaby@gmail.com> (isicom part)
>
> Unsure for tty.h -- won't this break too much of apps' builds?
good question, i'm not sure. should i submit those two as separate
patches or does your partial ACK already handle isicom.h?
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-04 17:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-04 16:47 [PATCH] KBUILD: Drop tty.h and isicom.h from include/linux/Kbuild Robert P. J. Day
2007-05-04 16:52 ` Jiri Slaby
2007-05-04 17:02 ` Robert P. J. Day
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.