All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@shadowen.org>
To: Shani Moideen <shani.moideen@wipro.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-janitors@lists.osdl.org
Subject: [KJ] Re: [KJ PATCH] Replacing memset(<addr>, 0,
Date: Tue, 08 May 2007 11:18:42 +0000	[thread overview]
Message-ID: <46405C92.1080003@shadowen.org> (raw)
In-Reply-To: <1178621156.3598.10.camel@shani-win>

Shani Moideen wrote:
> Hi,
> 
> Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in mm/memory.c.
> 
> Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
> ----
> 
> thanks.
> 
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index e7066e7..2780d07 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1505,7 +1505,7 @@ static inline void cow_user_page(struct page *dst, struct page *src, unsigned lo
>                  * zeroes.
>                  */
>                 if (__copy_from_user_inatomic(kaddr, uaddr, PAGE_SIZE))
> -                       memset(kaddr, 0, PAGE_SIZE);
> +                       clear_page(kaddr);
>                 kunmap_atomic(kaddr, KM_USER0);
>                 flush_dcache_page(dst);
>                 return;
> 
> 

This looks to be whitespace dammaged?

-apw

use tabs not spaces
PATCH: -:64:
FILE: b/mm/memory.c:1508:
+                       clear_page(kaddr);$

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Andy Whitcroft <apw@shadowen.org>
To: Shani Moideen <shani.moideen@wipro.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-janitors@lists.osdl.org
Subject: Re: [KJ PATCH] Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in mm/memory.c
Date: Tue, 08 May 2007 12:18:42 +0100	[thread overview]
Message-ID: <46405C92.1080003@shadowen.org> (raw)
In-Reply-To: <1178621156.3598.10.camel@shani-win>

Shani Moideen wrote:
> Hi,
> 
> Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in mm/memory.c.
> 
> Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
> ----
> 
> thanks.
> 
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index e7066e7..2780d07 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1505,7 +1505,7 @@ static inline void cow_user_page(struct page *dst, struct page *src, unsigned lo
>                  * zeroes.
>                  */
>                 if (__copy_from_user_inatomic(kaddr, uaddr, PAGE_SIZE))
> -                       memset(kaddr, 0, PAGE_SIZE);
> +                       clear_page(kaddr);
>                 kunmap_atomic(kaddr, KM_USER0);
>                 flush_dcache_page(dst);
>                 return;
> 
> 

This looks to be whitespace dammaged?

-apw

use tabs not spaces
PATCH: -:64:
FILE: b/mm/memory.c:1508:
+                       clear_page(kaddr);$


WARNING: multiple messages have this Message-ID (diff)
From: Andy Whitcroft <apw@shadowen.org>
To: Shani Moideen <shani.moideen@wipro.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-janitors@lists.osdl.org
Subject: Re: [KJ PATCH] Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in mm/memory.c
Date: Tue, 08 May 2007 12:18:42 +0100	[thread overview]
Message-ID: <46405C92.1080003@shadowen.org> (raw)
In-Reply-To: <1178621156.3598.10.camel@shani-win>

Shani Moideen wrote:
> Hi,
> 
> Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in mm/memory.c.
> 
> Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
> ----
> 
> thanks.
> 
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index e7066e7..2780d07 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1505,7 +1505,7 @@ static inline void cow_user_page(struct page *dst, struct page *src, unsigned lo
>                  * zeroes.
>                  */
>                 if (__copy_from_user_inatomic(kaddr, uaddr, PAGE_SIZE))
> -                       memset(kaddr, 0, PAGE_SIZE);
> +                       clear_page(kaddr);
>                 kunmap_atomic(kaddr, KM_USER0);
>                 flush_dcache_page(dst);
>                 return;
> 
> 

This looks to be whitespace dammaged?

-apw

use tabs not spaces
PATCH: -:64:
FILE: b/mm/memory.c:1508:
+                       clear_page(kaddr);$

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-05-08 11:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-08 10:45 [KJ PATCH] Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in mm/memory.c Shani Moideen
2007-05-08 10:57 ` [KJ] [KJ PATCH] Replacing memset(<addr>, 0, Shani Moideen
2007-05-08 10:45 ` [KJ PATCH] Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in mm/memory.c Shani Moideen
2007-05-08 11:18 ` Andy Whitcroft [this message]
2007-05-08 11:18   ` Andy Whitcroft
2007-05-08 11:18   ` Andy Whitcroft
2007-06-14 11:15 ` [KJ] [KJ PATCH] Replacing memset(<addr>,0,PAGE_SIZE) with Shani Moideen
2007-06-14 11:28 ` Shani Moideen
2007-06-14 11:32 ` Shani Moideen
2007-06-18  3:28 ` Shani Moideen
2007-06-18  3:35 ` Shani Moideen
2007-06-18  3:45 ` Shani Moideen
2007-06-18 13:03 ` Robert P. J. Day
  -- strict thread matches above, loose matches on Subject: below --
2007-05-08 10:50 [KJ PATCH] Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in kernel/kexec.c Shani Moideen
2007-05-08 11:02 ` [KJ] [KJ PATCH] Replacing memset(<addr>, 0, Shani Moideen
2007-05-08 11:10 ` [KJ] " Michael Tokarev
2007-05-08 11:10   ` [KJ PATCH] Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in kernel/kexec.c Michael Tokarev
2007-05-08 12:21   ` [KJ] Re: [KJ PATCH] Replacing memset(<addr>, 0, Pekka Enberg
2007-05-08 12:21     ` [KJ PATCH] Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in kernel/kexec.c Pekka Enberg
2007-05-08 17:13     ` [KJ] Re: [KJ PATCH] Replacing memset(<addr>, 0, Satyam Sharma
2007-05-08 17:13       ` [KJ PATCH] Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in kernel/kexec.c Satyam Sharma
2007-05-08 17:40       ` [KJ] Re: [KJ PATCH] Replacing memset(<addr>, 0, Eric W. Biederman
2007-05-08 17:40         ` [KJ PATCH] Replacing memset(<addr>,0,PAGE_SIZE) with clear_page() in kernel/kexec.c Eric W. Biederman
2007-06-18 12:51   ` [KJ] Re: [KJ PATCH] Replacing memset(<addr>, 0, QLogic Support
2007-07-10 19:28   ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46405C92.1080003@shadowen.org \
    --to=apw@shadowen.org \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shani.moideen@wipro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.