* [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c.
@ 2007-05-09 11:57 ` Shani Moideen
0 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-05-09 11:57 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel, kernel-janitors
Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in
arch/i386/mm/pageattr.c.
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/arch/i386/mm/pageattr.c b/arch/i386/mm/pageattr.c
index 412ebbd..12f7f14 100644
--- a/arch/i386/mm/pageattr.c
+++ b/arch/i386/mm/pageattr.c
@@ -45,7 +45,7 @@ static struct page *split_large_page(unsigned long address, pgprot_t prot,
pte_t *pbase;
spin_unlock_irq(&cpa_lock);
- base = alloc_pages(GFP_KERNEL, 0);
+ base = alloc_page(GFP_KERNEL);
spin_lock_irq(&cpa_lock);
if (!base)
return NULL;
--
Shani
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [KJ] [KJ PATCH] Replacing alloc_pages(gfp,
@ 2007-05-09 11:57 ` Shani Moideen
0 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-05-09 12:09 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel, kernel-janitors
Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in
arch/i386/mm/pageattr.c.
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/arch/i386/mm/pageattr.c b/arch/i386/mm/pageattr.c
index 412ebbd..12f7f14 100644
--- a/arch/i386/mm/pageattr.c
+++ b/arch/i386/mm/pageattr.c
@@ -45,7 +45,7 @@ static struct page *split_large_page(unsigned long address, pgprot_t prot,
pte_t *pbase;
spin_unlock_irq(&cpa_lock);
- base = alloc_pages(GFP_KERNEL, 0);
+ base = alloc_page(GFP_KERNEL);
spin_lock_irq(&cpa_lock);
if (!base)
return NULL;
--
Shani
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c.
@ 2007-05-09 11:57 ` Shani Moideen
0 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-05-09 11:57 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel, kernel-janitors
Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in
arch/i386/mm/pageattr.c.
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/arch/i386/mm/pageattr.c b/arch/i386/mm/pageattr.c
index 412ebbd..12f7f14 100644
--- a/arch/i386/mm/pageattr.c
+++ b/arch/i386/mm/pageattr.c
@@ -45,7 +45,7 @@ static struct page *split_large_page(unsigned long address, pgprot_t prot,
pte_t *pbase;
spin_unlock_irq(&cpa_lock);
- base = alloc_pages(GFP_KERNEL, 0);
+ base = alloc_page(GFP_KERNEL);
spin_lock_irq(&cpa_lock);
if (!base)
return NULL;
--
Shani
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp)
2007-05-09 11:57 ` [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c Shani Moideen
(?)
(?)
@ 2007-05-10 14:02 ` walter harms
-1 siblings, 0 replies; 24+ messages in thread
From: walter harms @ 2007-05-10 14:02 UTC (permalink / raw)
To: kernel-janitors
hi Shani,
i do not know if that is useful because
alloc_page(mask) is actualy a macro for alloc_pages(mask,0)
re,
wh
Shani Moideen wrote:
> Hi,
>
> Replacing alloc_pages(gfp,0) with alloc_page(gfp) in
> arch/i386/mm/pageattr.c.
>
> Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
> ----
>
> diff --git a/arch/i386/mm/pageattr.c b/arch/i386/mm/pageattr.c
> index 412ebbd..12f7f14 100644
> --- a/arch/i386/mm/pageattr.c
> +++ b/arch/i386/mm/pageattr.c
> @@ -45,7 +45,7 @@ static struct page *split_large_page(unsigned long address, pgprot_t prot,
> pte_t *pbase;
>
> spin_unlock_irq(&cpa_lock);
> - base = alloc_pages(GFP_KERNEL, 0);
> + base = alloc_page(GFP_KERNEL);
> spin_lock_irq(&cpa_lock);
> if (!base)
> return NULL;
>
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp)
2007-05-09 11:57 ` [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c Shani Moideen
` (2 preceding siblings ...)
(?)
@ 2007-05-10 16:40 ` Robert P. J. Day
-1 siblings, 0 replies; 24+ messages in thread
From: Robert P. J. Day @ 2007-05-10 16:40 UTC (permalink / raw)
To: kernel-janitors
On Thu, 10 May 2007, walter harms wrote:
>
> hi Shani,
> i do not know if that is useful because
> alloc_page(mask) is actualy a macro for alloc_pages(mask,0)
>
> re,
> wh
there's nothing wrong with that cleanup since that would appear to be
the very reason "alloc_page(mask)" exists -- to act as a short form.
however, i'd try to do this as a large-scale change rather than a
single instance at a time, if you want to take care of all of them.
rday
p.s. this is a change i documented quite some time ago:
http://fsdev.net/wiki/index.php?title=Memory_allocation
>
> Shani Moideen wrote:
> > Hi,
> >
> > Replacing alloc_pages(gfp,0) with alloc_page(gfp) in
> > arch/i386/mm/pageattr.c.
> >
> > Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
> > ----
> >
> > diff --git a/arch/i386/mm/pageattr.c b/arch/i386/mm/pageattr.c
> > index 412ebbd..12f7f14 100644
> > --- a/arch/i386/mm/pageattr.c
> > +++ b/arch/i386/mm/pageattr.c
> > @@ -45,7 +45,7 @@ static struct page *split_large_page(unsigned long address, pgprot_t prot,
> > pte_t *pbase;
> >
> > spin_unlock_irq(&cpa_lock);
> > - base = alloc_pages(GFP_KERNEL, 0);
> > + base = alloc_page(GFP_KERNEL);
> > spin_lock_irq(&cpa_lock);
> > if (!base)
> > return NULL;
> >
> >
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
>
--
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
====================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 24+ messages in thread
* [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pgtable.c.
@ 2007-05-09 12:00 ` Shani Moideen
0 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-05-09 12:00 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel, kernel-janitors
Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in
arch/i386/mm/pgtable.c.
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/arch/i386/mm/pgtable.c b/arch/i386/mm/pgtable.c
index fa0cfbd..5d2b0fb 100644
--- a/arch/i386/mm/pgtable.c
+++ b/arch/i386/mm/pgtable.c
@@ -191,9 +191,9 @@ struct page *pte_alloc_one(struct mm_struct *mm, unsigned long address)
struct page *pte;
#ifdef CONFIG_HIGHPTE
- pte = alloc_pages(GFP_KERNEL|__GFP_HIGHMEM|__GFP_REPEAT|__GFP_ZERO, 0);
+ pte = alloc_page(GFP_KERNEL|__GFP_HIGHMEM|__GFP_REPEAT|__GFP_ZERO);
#else
- pte = alloc_pages(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO, 0);
+ pte = alloc_page(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO);
#endif
return pte;
}
--
Shani
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [KJ] [KJ PATCH] Replacing alloc_pages(gfp,
@ 2007-05-09 12:00 ` Shani Moideen
0 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-05-09 12:12 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel, kernel-janitors
Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in
arch/i386/mm/pgtable.c.
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/arch/i386/mm/pgtable.c b/arch/i386/mm/pgtable.c
index fa0cfbd..5d2b0fb 100644
--- a/arch/i386/mm/pgtable.c
+++ b/arch/i386/mm/pgtable.c
@@ -191,9 +191,9 @@ struct page *pte_alloc_one(struct mm_struct *mm, unsigned long address)
struct page *pte;
#ifdef CONFIG_HIGHPTE
- pte = alloc_pages(GFP_KERNEL|__GFP_HIGHMEM|__GFP_REPEAT|__GFP_ZERO, 0);
+ pte = alloc_page(GFP_KERNEL|__GFP_HIGHMEM|__GFP_REPEAT|__GFP_ZERO);
#else
- pte = alloc_pages(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO, 0);
+ pte = alloc_page(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO);
#endif
return pte;
}
--
Shani
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pgtable.c.
@ 2007-05-09 12:00 ` Shani Moideen
0 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-05-09 12:00 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel, kernel-janitors
Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in
arch/i386/mm/pgtable.c.
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/arch/i386/mm/pgtable.c b/arch/i386/mm/pgtable.c
index fa0cfbd..5d2b0fb 100644
--- a/arch/i386/mm/pgtable.c
+++ b/arch/i386/mm/pgtable.c
@@ -191,9 +191,9 @@ struct page *pte_alloc_one(struct mm_struct *mm, unsigned long address)
struct page *pte;
#ifdef CONFIG_HIGHPTE
- pte = alloc_pages(GFP_KERNEL|__GFP_HIGHMEM|__GFP_REPEAT|__GFP_ZERO, 0);
+ pte = alloc_page(GFP_KERNEL|__GFP_HIGHMEM|__GFP_REPEAT|__GFP_ZERO);
#else
- pte = alloc_pages(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO, 0);
+ pte = alloc_page(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO);
#endif
return pte;
}
--
Shani
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/ipv4/ip_output.c.
2007-05-09 11:57 ` [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c Shani Moideen
@ 2007-06-12 4:10 ` Shani Moideen
-1 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-06-12 3:58 UTC (permalink / raw)
To: davem, kuznet, pekkas, jmorris, yoshfuji, kaber; +Cc: netdev, kernel-janitors
Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in
net/ipv4/ip_output.c.
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index d6427d9..f9a87f6 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -1003,7 +1003,7 @@ alloc_new_skb:
} else if (i < MAX_SKB_FRAGS) {
if (copy > PAGE_SIZE)
copy = PAGE_SIZE;
- page = alloc_pages(sk->sk_allocation, 0);
+ page = alloc_page(sk->sk_allocation);
if (page == NULL) {
err = -ENOMEM;
goto error;
Regards,
Shani
^ permalink raw reply related [flat|nested] 24+ messages in thread* [KJ] [KJ PATCH] Replacing alloc_pages(gfp,
@ 2007-06-12 4:10 ` Shani Moideen
0 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-06-12 4:10 UTC (permalink / raw)
To: davem, kuznet, pekkas, jmorris, yoshfuji, kaber; +Cc: netdev, kernel-janitors
Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in
net/ipv4/ip_output.c.
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index d6427d9..f9a87f6 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -1003,7 +1003,7 @@ alloc_new_skb:
} else if (i < MAX_SKB_FRAGS) {
if (copy > PAGE_SIZE)
copy = PAGE_SIZE;
- page = alloc_pages(sk->sk_allocation, 0);
+ page = alloc_page(sk->sk_allocation);
if (page = NULL) {
err = -ENOMEM;
goto error;
Regards,
Shani
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/ipv6/ip6_output.c
2007-05-09 11:57 ` [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c Shani Moideen
@ 2007-06-12 5:10 ` Shani Moideen
-1 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-06-12 4:58 UTC (permalink / raw)
To: davem, kuznet, pekkas, jmorris, yoshfuji; +Cc: netdev, kernel-janitors
Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/ipv6/ip6_output.c
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index f508171..1d27779 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -1291,7 +1291,7 @@ alloc_new_skb:
} else if(i < MAX_SKB_FRAGS) {
if (copy > PAGE_SIZE)
copy = PAGE_SIZE;
- page = alloc_pages(sk->sk_allocation, 0);
+ page = alloc_page(sk->sk_allocation);
if (page == NULL) {
err = -ENOMEM;
goto error;
Regards,
Shani
^ permalink raw reply related [flat|nested] 24+ messages in thread* [KJ] [KJ PATCH] Replacing alloc_pages(gfp,
@ 2007-06-12 5:10 ` Shani Moideen
0 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-06-12 5:10 UTC (permalink / raw)
To: davem, kuznet, pekkas, jmorris, yoshfuji; +Cc: netdev, kernel-janitors
Hi,
Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/ipv6/ip6_output.c
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index f508171..1d27779 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -1291,7 +1291,7 @@ alloc_new_skb:
} else if(i < MAX_SKB_FRAGS) {
if (copy > PAGE_SIZE)
copy = PAGE_SIZE;
- page = alloc_pages(sk->sk_allocation, 0);
+ page = alloc_page(sk->sk_allocation);
if (page = NULL) {
err = -ENOMEM;
goto error;
Regards,
Shani
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/core/skbuff.c
2007-05-09 11:57 ` [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c Shani Moideen
@ 2007-06-13 2:49 ` Shani Moideen
-1 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-06-13 2:37 UTC (permalink / raw)
To: jgarzik, akpm; +Cc: netdev, kernel-janitors
Replacing alloc_pages(gfp,0) with alloc_page(gfp)
in net/core/skbuff.c
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 1422573..b923181 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1805,7 +1805,7 @@ int skb_append_datato_frags(struct sock *sk, struct sk_buff *skb,
return -EFAULT;
/* allocate a new page for next frag */
- page = alloc_pages(sk->sk_allocation, 0);
+ page = alloc_page(sk->sk_allocation);
/* If alloc_page fails just return failure and caller will
* free previous allocated pages by doing kfree_skb()
--
Shani
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [KJ] [KJ PATCH] Replacing alloc_pages(gfp,
@ 2007-06-13 2:49 ` Shani Moideen
0 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-06-13 2:49 UTC (permalink / raw)
To: jgarzik, akpm; +Cc: netdev, kernel-janitors
Replacing alloc_pages(gfp,0) with alloc_page(gfp)
in net/core/skbuff.c
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 1422573..b923181 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1805,7 +1805,7 @@ int skb_append_datato_frags(struct sock *sk, struct sk_buff *skb,
return -EFAULT;
/* allocate a new page for next frag */
- page = alloc_pages(sk->sk_allocation, 0);
+ page = alloc_page(sk->sk_allocation);
/* If alloc_page fails just return failure and caller will
* free previous allocated pages by doing kfree_skb()
--
Shani
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/core/pktgen.c
2007-05-09 11:57 ` [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c Shani Moideen
@ 2007-06-13 2:54 ` Shani Moideen
-1 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-06-13 2:42 UTC (permalink / raw)
To: jgarzik, akpm; +Cc: netdev, kernel-janitors
Replacing alloc_pages(gfp,0) with alloc_page(gfp)
in net/core/pktgen.c
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index b92a322..2600c7f 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -2414,7 +2414,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,
i = 0;
while (datalen > 0) {
- struct page *page = alloc_pages(GFP_KERNEL, 0);
+ struct page *page = alloc_page(GFP_KERNEL);
skb_shinfo(skb)->frags[i].page = page;
skb_shinfo(skb)->frags[i].page_offset = 0;
skb_shinfo(skb)->frags[i].size =
@@ -2762,7 +2762,7 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev,
i = 0;
while (datalen > 0) {
- struct page *page = alloc_pages(GFP_KERNEL, 0);
+ struct page *page = alloc_page(GFP_KERNEL);
skb_shinfo(skb)->frags[i].page = page;
skb_shinfo(skb)->frags[i].page_offset = 0;
skb_shinfo(skb)->frags[i].size =
--
Shani
^ permalink raw reply related [flat|nested] 24+ messages in thread* [KJ] [KJ PATCH] Replacing alloc_pages(gfp,
@ 2007-06-13 2:54 ` Shani Moideen
0 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-06-13 2:54 UTC (permalink / raw)
To: jgarzik, akpm; +Cc: netdev, kernel-janitors
Replacing alloc_pages(gfp,0) with alloc_page(gfp)
in net/core/pktgen.c
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index b92a322..2600c7f 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -2414,7 +2414,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,
i = 0;
while (datalen > 0) {
- struct page *page = alloc_pages(GFP_KERNEL, 0);
+ struct page *page = alloc_page(GFP_KERNEL);
skb_shinfo(skb)->frags[i].page = page;
skb_shinfo(skb)->frags[i].page_offset = 0;
skb_shinfo(skb)->frags[i].size @@ -2762,7 +2762,7 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev,
i = 0;
while (datalen > 0) {
- struct page *page = alloc_pages(GFP_KERNEL, 0);
+ struct page *page = alloc_page(GFP_KERNEL);
skb_shinfo(skb)->frags[i].page = page;
skb_shinfo(skb)->frags[i].page_offset = 0;
skb_shinfo(skb)->frags[i].size
--
Shani
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp) in net/core/pktgen.c
2007-06-13 2:54 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, Shani Moideen
@ 2007-06-13 10:24 ` psr
-1 siblings, 0 replies; 24+ messages in thread
From: psr @ 2007-06-13 10:12 UTC (permalink / raw)
To: Shani Moideen; +Cc: jgarzik, akpm, netdev, kernel-janitors
On 6/13/07, Shani Moideen <shani.moideen@wipro.com> wrote:
>
> Replacing alloc_pages(gfp,0) with alloc_page(gfp)
> in net/core/pktgen.c
>
> Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
> ----
>
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index b92a322..2600c7f 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -2414,7 +2414,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,
>
> i = 0;
> while (datalen > 0) {
> - struct page *page = alloc_pages(GFP_KERNEL, 0);
> + struct page *page = alloc_page(GFP_KERNEL);
Does this makes any difference anyway? Both are same eventually?
What is the rational behind this? Can you please help me understanding this?
thanks
--pradeep
> skb_shinfo(skb)->frags[i].page = page;
> skb_shinfo(skb)->frags[i].page_offset = 0;
> skb_shinfo(skb)->frags[i].size =
> @@ -2762,7 +2762,7 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev,
>
> i = 0;
> while (datalen > 0) {
> - struct page *page = alloc_pages(GFP_KERNEL, 0);
> + struct page *page = alloc_page(GFP_KERNEL);
> skb_shinfo(skb)->frags[i].page = page;
> skb_shinfo(skb)->frags[i].page_offset = 0;
> skb_shinfo(skb)->frags[i].size =
>
> --
> Shani
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
>
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [KJ] [KJ PATCH] Replacing alloc_pages(gfp,
@ 2007-06-13 10:24 ` psr
0 siblings, 0 replies; 24+ messages in thread
From: psr @ 2007-06-13 10:24 UTC (permalink / raw)
To: Shani Moideen; +Cc: jgarzik, akpm, netdev, kernel-janitors
On 6/13/07, Shani Moideen <shani.moideen@wipro.com> wrote:
>
> Replacing alloc_pages(gfp,0) with alloc_page(gfp)
> in net/core/pktgen.c
>
> Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
> ----
>
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index b92a322..2600c7f 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -2414,7 +2414,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,
>
> i = 0;
> while (datalen > 0) {
> - struct page *page = alloc_pages(GFP_KERNEL, 0);
> + struct page *page = alloc_page(GFP_KERNEL);
Does this makes any difference anyway? Both are same eventually?
What is the rational behind this? Can you please help me understanding this?
thanks
--pradeep
> skb_shinfo(skb)->frags[i].page = page;
> skb_shinfo(skb)->frags[i].page_offset = 0;
> skb_shinfo(skb)->frags[i].size > @@ -2762,7 +2762,7 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev,
>
> i = 0;
> while (datalen > 0) {
> - struct page *page = alloc_pages(GFP_KERNEL, 0);
> + struct page *page = alloc_page(GFP_KERNEL);
> skb_shinfo(skb)->frags[i].page = page;
> skb_shinfo(skb)->frags[i].page_offset = 0;
> skb_shinfo(skb)->frags[i].size >
> --
> Shani
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp)
2007-06-13 10:24 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, psr
@ 2007-06-13 13:14 ` Robert P. J. Day
-1 siblings, 0 replies; 24+ messages in thread
From: Robert P. J. Day @ 2007-06-13 13:14 UTC (permalink / raw)
To: psr; +Cc: Shani Moideen, netdev, akpm, jgarzik, kernel-janitors
On Wed, 13 Jun 2007, psr wrote:
> On 6/13/07, Shani Moideen <shani.moideen@wipro.com> wrote:
> >
> > Replacing alloc_pages(gfp,0) with alloc_page(gfp)
> > in net/core/pktgen.c
> >
> > Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
> > ----
> >
> > diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> > index b92a322..2600c7f 100644
> > --- a/net/core/pktgen.c
> > +++ b/net/core/pktgen.c
> > @@ -2414,7 +2414,7 @@ static struct sk_buff *fill_packet_ipv4(struct
> > net_device *odev,
> >
> > i = 0;
> > while (datalen > 0) {
> > - struct page *page = alloc_pages(GFP_KERNEL, 0);
> > + struct page *page = alloc_page(GFP_KERNEL);
>
> Does this makes any difference anyway? Both are same eventually?
> What is the rational behind this? Can you please help me
> understanding this?
since this is one of the TO DO items i added to the list of things at
the wiki:
http://fsdev.net/wiki/index.php?title=Memory_allocation_cleanup
i'll just toss in my $0.02. if a short (more convenient) form of a
routine has been defined, it should be used. if you have no plans to
use it, it shouldn't have been defined in the first place.
in short, make a consistent decision and go with it.
rday
--
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
====================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp) in net/core/pktgen.c
@ 2007-06-13 13:14 ` Robert P. J. Day
0 siblings, 0 replies; 24+ messages in thread
From: Robert P. J. Day @ 2007-06-13 13:14 UTC (permalink / raw)
To: psr; +Cc: Shani Moideen, netdev, akpm, jgarzik, kernel-janitors
On Wed, 13 Jun 2007, psr wrote:
> On 6/13/07, Shani Moideen <shani.moideen@wipro.com> wrote:
> >
> > Replacing alloc_pages(gfp,0) with alloc_page(gfp)
> > in net/core/pktgen.c
> >
> > Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
> > ----
> >
> > diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> > index b92a322..2600c7f 100644
> > --- a/net/core/pktgen.c
> > +++ b/net/core/pktgen.c
> > @@ -2414,7 +2414,7 @@ static struct sk_buff *fill_packet_ipv4(struct
> > net_device *odev,
> >
> > i = 0;
> > while (datalen > 0) {
> > - struct page *page = alloc_pages(GFP_KERNEL, 0);
> > + struct page *page = alloc_page(GFP_KERNEL);
>
> Does this makes any difference anyway? Both are same eventually?
> What is the rational behind this? Can you please help me
> understanding this?
since this is one of the TO DO items i added to the list of things at
the wiki:
http://fsdev.net/wiki/index.php?title=Memory_allocation_cleanup
i'll just toss in my $0.02. if a short (more convenient) form of a
routine has been defined, it should be used. if you have no plans to
use it, it shouldn't have been defined in the first place.
in short, make a consistent decision and go with it.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp) in net/core/pktgen.c
2007-06-13 13:14 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp) in net/core/pktgen.c Robert P. J. Day
@ 2007-06-13 14:40 ` psr
-1 siblings, 0 replies; 24+ messages in thread
From: psr @ 2007-06-13 14:28 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Shani Moideen, netdev, akpm, jgarzik, kernel-janitors
On 6/13/07, Robert P. J. Day <rpjday@mindspring.com> wrote:
[snip]
> >
> > Does this makes any difference anyway? Both are same eventually?
> > What is the rational behind this? Can you please help me
> > understanding this?
>
> since this is one of the TO DO items i added to the list of things at
> the wiki:
>
> http://fsdev.net/wiki/index.php?title=Memory_allocation_cleanup
>
> i'll just toss in my $0.02. if a short (more convenient) form of a
> routine has been defined, it should be used. if you have no plans to
> use it, it shouldn't have been defined in the first place.
Oh... agreed
Thanks
--pradeep
>
> in short, make a consistent decision and go with it.
>
> rday
> --
> ========================================================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry
> Waterloo, Ontario, CANADA
>
> http://fsdev.net/wiki/index.php?title=Main_Page
> ========================================================================
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [KJ] [KJ PATCH] Replacing alloc_pages(gfp,
@ 2007-06-13 14:40 ` psr
0 siblings, 0 replies; 24+ messages in thread
From: psr @ 2007-06-13 14:40 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Shani Moideen, netdev, akpm, jgarzik, kernel-janitors
On 6/13/07, Robert P. J. Day <rpjday@mindspring.com> wrote:
[snip]
> >
> > Does this makes any difference anyway? Both are same eventually?
> > What is the rational behind this? Can you please help me
> > understanding this?
>
> since this is one of the TO DO items i added to the list of things at
> the wiki:
>
> http://fsdev.net/wiki/index.php?title=Memory_allocation_cleanup
>
> i'll just toss in my $0.02. if a short (more convenient) form of a
> routine has been defined, it should be used. if you have no plans to
> use it, it shouldn't have been defined in the first place.
Oh... agreed
Thanks
--pradeep
>
> in short, make a consistent decision and go with it.
>
> rday
> --
> ====================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry
> Waterloo, Ontario, CANADA
>
> http://fsdev.net/wiki/index.php?title=Main_Page
> ====================================
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 24+ messages in thread
* [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/core/sock.c
2007-05-09 11:57 ` [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c Shani Moideen
@ 2007-06-13 2:58 ` Shani Moideen
-1 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-06-13 2:46 UTC (permalink / raw)
To: jgarzik, akpm; +Cc: netdev, kernel-janitors
Replacing alloc_pages(gfp,0) with alloc_page(gfp)
in net/core/sock.c
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/net/core/sock.c b/net/core/sock.c
index 22183c2..25bb52b 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1193,7 +1193,7 @@ static struct sk_buff *sock_alloc_send_pskb(struct sock *sk,
struct page *page;
skb_frag_t *frag;
- page = alloc_pages(sk->sk_allocation, 0);
+ page = alloc_page(sk->sk_allocation);
if (!page) {
err = -ENOBUFS;
skb_shinfo(skb)->nr_frags = i;
--
Shani
^ permalink raw reply related [flat|nested] 24+ messages in thread* [KJ] [KJ PATCH] Replacing alloc_pages(gfp,
@ 2007-06-13 2:58 ` Shani Moideen
0 siblings, 0 replies; 24+ messages in thread
From: Shani Moideen @ 2007-06-13 2:58 UTC (permalink / raw)
To: jgarzik, akpm; +Cc: netdev, kernel-janitors
Replacing alloc_pages(gfp,0) with alloc_page(gfp)
in net/core/sock.c
Signed-off-by: Shani Moideen <shani.moideen@wipro.com>
----
diff --git a/net/core/sock.c b/net/core/sock.c
index 22183c2..25bb52b 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1193,7 +1193,7 @@ static struct sk_buff *sock_alloc_send_pskb(struct sock *sk,
struct page *page;
skb_frag_t *frag;
- page = alloc_pages(sk->sk_allocation, 0);
+ page = alloc_page(sk->sk_allocation);
if (!page) {
err = -ENOBUFS;
skb_shinfo(skb)->nr_frags = i;
--
Shani
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 24+ messages in thread
end of thread, other threads:[~2007-06-13 14:40 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-09 11:57 [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c Shani Moideen
2007-05-09 12:09 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, Shani Moideen
2007-05-09 11:57 ` [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pageattr.c Shani Moideen
2007-05-10 14:02 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp) walter harms
2007-05-10 16:40 ` Robert P. J. Day
-- strict thread matches above, loose matches on Subject: below --
2007-05-09 12:00 [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pgtable.c Shani Moideen
2007-05-09 12:12 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, Shani Moideen
2007-05-09 12:00 ` [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in arch/i386/mm/pgtable.c Shani Moideen
2007-06-12 3:58 [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/ipv4/ip_output.c Shani Moideen
2007-06-12 4:10 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, Shani Moideen
2007-06-12 4:58 [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/ipv6/ip6_output.c Shani Moideen
2007-06-12 5:10 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, Shani Moideen
2007-06-13 2:37 [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/core/skbuff.c Shani Moideen
2007-06-13 2:49 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, Shani Moideen
2007-06-13 2:42 [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/core/pktgen.c Shani Moideen
2007-06-13 2:54 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, Shani Moideen
2007-06-13 10:12 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp) in net/core/pktgen.c psr
2007-06-13 10:24 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, psr
2007-06-13 13:14 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp) Robert P. J. Day
2007-06-13 13:14 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, 0) with alloc_page(gfp) in net/core/pktgen.c Robert P. J. Day
2007-06-13 14:28 ` psr
2007-06-13 14:40 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, psr
2007-06-13 2:46 [KJ PATCH] Replacing alloc_pages(gfp,0) with alloc_page(gfp) in net/core/sock.c Shani Moideen
2007-06-13 2:58 ` [KJ] [KJ PATCH] Replacing alloc_pages(gfp, Shani Moideen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.