Re: [PATCH] Basic policy representation

[Joshua Brindle <method@manicmethod.com>]

Karl MacMillan wrote:
> On Tue, 2007-05-08 at 15:41 -0400, Karl MacMillan wrote:
>   
>> I actually prefer returning char instead - to me that is a common way to
>> indicate that the returned value has a limited range of values (2 in
>> this case). But maybe that is just the code bases I've worked on. I
>> don't care either way - this seems like a bike shed discussion . . .
>>
>>     
>
> On the other hand, the existing code (for things like sepol_bool) uses
> int for boolean values. So I'll change to using int everywhere.
> Ahh . . . the bike shed looks much nicer painted blue rather than green.
>   
Not to drag this mostly irrelevant discussion out longer but the setools 
guys have decided to move to using stdbool.h and proper bool types for 
all their boolean functions, is there a reason we can't do that? I was 
surprised to find out that setting a bool value to anything other than 0 
would cause it to be 1, so it really behaves like a boolean (strange.. 
I'm not use to C doing things the way you'd expect them to :P )

Also the bikeshed should be red.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.