From: "H. Peter Anvin" <hpa@zytor.com>
To: Satyam Sharma <satyam.sharma@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Johannes Stezenbach <js@linuxtv.org>,
Jesper Juhl <jesper.juhl@gmail.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Heikki Orsila <shdl@zakalwe.fi>,
jimmy bahuleyan <knight.camelot@gmail.com>,
Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: [PATCH] "volatile considered harmful", take 3
Date: Fri, 11 May 2007 22:34:13 -0700 [thread overview]
Message-ID: <464551D5.2050709@zytor.com> (raw)
In-Reply-To: <a781481a0705112021u7b6d32fcxb6318d7e2443c970@mail.gmail.com>
Satyam Sharma wrote:
>
>> + - Pointers to data structures in coherent memory which might be
>> modified
>> + by I/O devices can, sometimes, legitimately be volatile. A ring
>> buffer
>> + used by a network adapter, where that adapter changes pointers to
>> + indicate which descriptors have been processed, is an example of
>> this
>> + type of situation.
>
> is a legitimate use case for volatile is still not clear to me (I
> agree with Alan's
> comment in a previous thread that this seems to be a case where a memory
> barrier would be applicable^Wbetter, actually). I could be wrong here, so
> would be nice if Peter explains why volatile is legitimate here.
>
> Otherwise, it's fine with me.
>
I don't see why Alan's way is necessarily better; it should work but is
more heavy-handed as it's disabling *all* optimization such as loop
invariants across the barrier.
-hpa
next prev parent reply other threads:[~2007-05-12 5:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 17:36 [PATCH] "volatile considered harmful", take 3 Jonathan Corbet
2007-05-11 21:25 ` Jesper Juhl
2007-05-12 3:21 ` Satyam Sharma
2007-05-12 4:29 ` Jeff Garzik
2007-05-12 5:34 ` H. Peter Anvin [this message]
2007-05-12 5:41 ` H. Peter Anvin
2007-05-12 6:15 ` Satyam Sharma
2007-05-12 6:21 ` H. Peter Anvin
2007-05-12 7:02 ` Satyam Sharma
2007-05-12 7:13 ` H. Peter Anvin
2007-05-12 7:28 ` Satyam Sharma
2007-05-12 7:53 ` Stefan Richter
2007-05-12 11:51 ` Heikki Orsila
2007-05-12 18:06 ` H. Peter Anvin
2007-05-12 7:22 ` Stefan Richter
2007-05-12 7:33 ` jimmy bahuleyan
2007-05-12 7:45 ` Jeff Garzik
2007-05-12 19:17 ` Dr. David Alan Gilbert
[not found] <8jHg3-1T2-5@gated-at.bofh.it>
[not found] ` <8jQt5-7As-3@gated-at.bofh.it>
[not found] ` <8jSuQ-28J-21@gated-at.bofh.it>
[not found] ` <8jT7y-39x-9@gated-at.bofh.it>
2007-05-13 0:00 ` Bodo Eggert
2007-05-14 3:37 ` Satyam Sharma
2007-05-17 23:51 ` Bill Davidsen
2007-05-18 3:13 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464551D5.2050709@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=jesper.juhl@gmail.com \
--cc=js@linuxtv.org \
--cc=knight.camelot@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=satyam.sharma@gmail.com \
--cc=shdl@zakalwe.fi \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.