All of lore.kernel.org
 help / color / mirror / Atom feed
[parent not found: <200705161925.53410.rjw@sisk.pl>]
* [PATCH] Workaround for a PCI restoring bug
@ 2007-05-12 20:12 Lukas Hejtmanek
  2007-05-13  6:47 ` Andrew Morton
  0 siblings, 1 reply; 12+ messages in thread
From: Lukas Hejtmanek @ 2007-05-12 20:12 UTC (permalink / raw)
  To: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

Hello,

as of 2.6.21-git16, the bugs related to restoring PCI are still present. The
save pci function reads only -1 from the PCI config space and when restoring,
it messes up totaly most PCI devices. The attached patch is workaround only
until proper fix is found and included. Could it be included into the mainline
for now?

-- 
Lukáš Hejtmánek

[-- Attachment #2: pci.patch --]
[-- Type: text/x-diff, Size: 488 bytes --]

--- drivers/pci/pci.c.orig	2006-07-15 23:53:08.000000000 +0200
+++ drivers/pci/pci.c	2006-07-21 00:51:07.000000000 +0200
@@ -477,7 +477,7 @@
 	 */
 	for (i = 15; i >= 0; i--) {
 		pci_read_config_dword(dev, i * 4, &val);
-		if (val != dev->saved_config_space[i]) {
+		if (val != dev->saved_config_space[i] && dev->saved_config_space[i] != 0xffffffff) {
 			printk(KERN_DEBUG "PM: Writing back config space on "
 				"device %s at offset %x (was %x, writing %x)\n",
 				pci_name(dev), i,

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2007-05-17 22:26 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <fa.K6U9hglycxHd65x5b6pmUzJjdoA@ifi.uio.no>
2007-05-13  2:06 ` [PATCH] Workaround for a PCI restoring bug Robert Hancock
     [not found] <200705161925.53410.rjw@sisk.pl>
2007-05-17  6:14 ` Brown, Len
2007-05-17 20:50   ` Lukas Hejtmanek
2007-05-17 21:25     ` Rafael J. Wysocki
2007-05-17 22:24       ` Lukas Hejtmanek
2007-05-12 20:12 Lukas Hejtmanek
2007-05-13  6:47 ` Andrew Morton
2007-05-13  8:57   ` Lukas Hejtmanek
2007-05-13  9:11     ` Andrew Morton
2007-05-13 12:21       ` Lukas Hejtmanek
2007-05-13 18:59         ` Andrew Morton
2007-05-14 10:21           ` Lukas Hejtmanek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.