All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gregory Haskins" <ghaskins-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
To: <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"Dor Laor" <dor.laor-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 00/10] in-kernel APIC v3 (kernel side)
Date: Mon, 14 May 2007 08:37:59 -0400	[thread overview]
Message-ID: <46481FC0.BA47.005A.0@novell.com> (raw)
In-Reply-To: <64F9B87B6B770947A9F8391472E032160BC74642-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>

>>> On Sun, May 13, 2007 at 10:06 AM, in message
<64F9B87B6B770947A9F8391472E032160BC74642-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>,
"Dor Laor" <dor.laor-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote: 
>> >
>>> Superb results, when I run the old in-  kernel apic I got much higher
> idle
>>> cpu consumtion. I know that's vmenter-  vmexit latency was drastically
>>> improved but 0-  1% cpu consumption for winxp 32 bit sounds too good
> to be
>>> true.
>>> Are you sure an ACPI HAL is used in the guest? (can be checked by
>>> looking at the computer node in the device manager).
>>
>>I did a clean install and didn't change it over to StandardPC.  The
> Control
>>Panel says "ACPI Uniprocessor PC" or something like that (recalling
> from
>>memory right now).  As a third datapoint, I am seeing the TPR changing
>>rapidly (which I would expect 0 changes if the ACPI stuff was
> disabled).
> 
> Great, I was a little skeptical (sorry for that) 

No problem.

> since several months
> ago when I tested the in- kernel- apic the idle time was much worse. After
> talking today with Avi, he said his vmentry- exit latency drastically
> improved performance and even the qemu's apic can reach these figures.

Yeah.  At first I was psyched when I saw my code running at 0-1%, but then I ran trunk and saw its not all that different :(  The good news is that windows is performing pretty well now, regardless of my patch or not.  Thats good for KVM all around.

> I'm sure that with load, you implementation will achieve performance
> advantage.

In theory, we should be able to take advantage of all the light-exit gains we have made recently since that is the primary difference for windows+ACPI now.  This means the APIC change will have an increasing impact as we improve the VMEXIT times (both in HW and SW).  So even if it doesn't make a huge diff today, it will always be contributing more and more as we push the ball forward in other areas.

But I am not disappointed.  My primary motivation is functionality, not performance. ;)  I need to be able to inject interrupts to a guest from the kernel for the work I am doing.  If I also improve performance, great!



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

  parent reply	other threads:[~2007-05-14 12:37 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-10 12:46 [PATCH 00/10] in-kernel APIC v3 (kernel side) Gregory Haskins
     [not found] ` <20070510123831.10200.4769.stgit-sLgBBP33vUGnsjUZhwzVf9HuzzzSOjJt@public.gmane.org>
2007-05-10 12:46   ` [PATCH 01/10] KVM: Adds support for in-kernel mmio handlers Gregory Haskins
2007-05-10 12:46   ` [PATCH 02/10] KVM: VMX - fix interrupt checking on light-exit Gregory Haskins
2007-05-10 12:46   ` [PATCH 03/10] KVM: Add irqdevice object Gregory Haskins
2007-05-10 12:47   ` [PATCH 04/10] KVM: Adds ability to preempt an executing VCPU Gregory Haskins
2007-05-10 12:47   ` [PATCH 05/10] KVM: Adds ability to signal userspace using a file-descriptor Gregory Haskins
     [not found]     ` <20070510124706.10200.68571.stgit-sLgBBP33vUGnsjUZhwzVf9HuzzzSOjJt@public.gmane.org>
2007-05-13 13:00       ` Avi Kivity
     [not found]         ` <46470BF7.5080108-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-14 12:15           ` Gregory Haskins
     [not found]             ` <46481A61.BA47.005A.0-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
2007-05-14 12:22               ` Avi Kivity
     [not found]                 ` <46485488.2010608-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-14 14:00                   ` Gregory Haskins
     [not found]                     ` <46483320.BA47.005A.0-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
2007-05-14 14:42                       ` Avi Kivity
     [not found]                         ` <4648756D.5040001-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-14 17:18                           ` Gregory Haskins
2007-05-14 16:52                   ` Davide Libenzi
     [not found]                     ` <Pine.LNX.4.64.0705140948150.19682-GPJ85BhbkB8RepQJljzAVbITYcZ0+W3JAL8bYrjMMd8@public.gmane.org>
2007-05-14 17:12                       ` Avi Kivity
     [not found]                         ` <4648986B.9090403-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-14 17:15                           ` Davide Libenzi
     [not found]                             ` <Pine.LNX.4.64.0705141013310.19682-GPJ85BhbkB8RepQJljzAVbITYcZ0+W3JAL8bYrjMMd8@public.gmane.org>
2007-05-14 17:23                               ` Avi Kivity
     [not found]                                 ` <46489B12.8030807-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-14 19:01                                   ` Gregory Haskins
     [not found]                                     ` <464879A3.BA47.005A.0-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
2007-05-14 19:12                                       ` Davide Libenzi
     [not found]                                         ` <Pine.LNX.4.64.0705141207070.19682-GPJ85BhbkB8RepQJljzAVbITYcZ0+W3JAL8bYrjMMd8@public.gmane.org>
2007-05-14 20:18                                           ` Gregory Haskins
     [not found]                                             ` <46488BCD.BA47.005A.0-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
2007-05-14 21:32                                               ` Davide Libenzi
2007-05-10 12:47   ` [PATCH 06/10] KVM: Add support for in-kernel LAPIC model Gregory Haskins
2007-05-10 12:47   ` [PATCH 07/10] KVM: Adds support for real NMI injection on VMX processors Gregory Haskins
2007-05-10 12:47   ` [PATCH 08/10] KVM: Adds basic plumbing to support TPR shadow features Gregory Haskins
2007-05-10 12:47   ` [PATCH 09/10] KVM: Add statistics from interrupt subsystem Gregory Haskins
     [not found]     ` <20070510124726.10200.53053.stgit-sLgBBP33vUGnsjUZhwzVf9HuzzzSOjJt@public.gmane.org>
2007-05-14 11:17       ` Avi Kivity
2007-05-10 12:47   ` [PATCH 10/10] KVM: Adds support for TPR shadowing under VMX processors Gregory Haskins
2007-05-10 13:07   ` [PATCH 00/10] in-kernel APIC v3 (kernel side) Dor Laor
     [not found]     ` <64F9B87B6B770947A9F8391472E032160BBA66AF-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2007-05-10 13:20       ` Gregory Haskins
     [not found]         ` <4642E39D.BA47.005A.0-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
2007-05-13  8:00           ` Dor Laor
     [not found]             ` <64F9B87B6B770947A9F8391472E032160BC745D3-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2007-05-13 13:59               ` Gregory Haskins
     [not found]                 ` <4646E16D.BA47.005A.0-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
2007-05-13 14:06                   ` Dor Laor
     [not found]                     ` <64F9B87B6B770947A9F8391472E032160BC74642-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2007-05-14 12:37                       ` Gregory Haskins [this message]
     [not found]                         ` <46481FC0.BA47.005A.0-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
2007-05-14 13:04                           ` Dor Laor
2007-05-13 12:38           ` Avi Kivity
     [not found]             ` <464706BF.6000808-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-14 11:59               ` Gregory Haskins
     [not found]                 ` <464816AB.BA47.005A.0-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
2007-05-14 12:05                   ` Dor Laor
2007-05-14 12:14                   ` Avi Kivity
2007-05-10 13:32       ` Gregory Haskins
2007-05-13 13:10   ` Avi Kivity
     [not found]     ` <46470E58.2040208-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-14 12:23       ` Gregory Haskins
     [not found]         ` <46481C4B.BA47.005A.0-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
2007-05-14 12:24           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46481FC0.BA47.005A.0@novell.com \
    --to=ghaskins-et1tbqhtxzrqt0dzr+alfa@public.gmane.org \
    --cc=dor.laor-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.