All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ky Srinivasan" <ksrinivasan@novell.com>
To: Ian Campbell <Ian.Campbell@XenSource.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] PV driver compatibility patch
Date: Tue, 15 May 2007 11:26:31 -0600	[thread overview]
Message-ID: <4649A4B5.E57C.0030.0@novell.com> (raw)
In-Reply-To: <1179249116.26437.39.camel@localhost.localdomain>

Ian,

Ignore my earlier email. The sles10 sp1 code is based on older code and does not have the stuff you have in compat shim. I ran into this problem when trying to build a PV driver targeted against RHEL5 and ran into this problem.

Regards,

K. Y

>>> On Tue, May 15, 2007 at  1:11 PM, in message
<1179249116.26437.39.camel@localhost.localdomain>, Ian Campbell
<Ian.Campbell@XenSource.com> wrote: 
> Isn't there already enough compat shim in
> unmodified_drivers/linux- 2.6/compat- include/xen/platform- compat.h for
> this stuff?
> 
> xenbus_probe.c already has the required #include, what is the error you
> saw?
> 
> Ian.
> 
> On Tue, 2007- 05- 15 at 11:05 - 0600, Ky Srinivasan wrote:
>> This patch fixes compilation issues on 2.6.16 kernels.
>> 
>> Signed- off- by: K. Y. Srinivasan  <ksrinivasan@novell.com>
>> 
> 
> 
>> ---
>> linux- 2.6- xen- sparse/drivers/xen/xenbus/xenbus_probe.c      2007- 05- 14
>> 13:45:04.000000000 - 0400
>> +++
>> linux- 2.6- xen- sparse- new/drivers/xen/xenbus/xenbus_probe.c  2007- 05- 15
>> 10:55:31.000000000 - 0400
>> @@ - 67,8 +67,11 @@
>>  static unsigned long xen_store_mfn;
>>  
>>  extern struct mutex xenwatch_mutex;
>> -
>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,17)
>> +static struct notifier_block *xenstore_chain;
>> +#else
>>  static ATOMIC_NOTIFIER_HEAD(xenstore_chain);
>> +#endif

  reply	other threads:[~2007-05-15 17:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-15 17:05 [PATCH] PV driver compatibility patch Ky Srinivasan
2007-05-15 17:11 ` Ian Campbell
2007-05-15 17:26   ` Ky Srinivasan [this message]
2007-05-24 14:15 ` Keir Fraser
2007-05-24 14:35   ` Ky Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4649A4B5.E57C.0030.0@novell.com \
    --to=ksrinivasan@novell.com \
    --cc=Ian.Campbell@XenSource.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.