All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian King <brking@linux.vnet.ibm.com>
To: Mel Gorman <mel@skynet.ie>
Cc: linuxppc-dev@ozlabs.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Bob Picco <bob.picco@hp.com>
Subject: Re: PPC64 build breakage drivers/pci/hotplug/rpadlpar_sysfs.c
Date: Thu, 17 May 2007 08:37:41 -0500	[thread overview]
Message-ID: <464C5AA5.3090002@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070517104008.GA667@skynet.ie>

Mel Gorman wrote:
> On (16/05/07 09:30), Bob Picco didst pronounce:
>> bob.picco@hp.com
>> /usr/src/linux-2.6.22-rc1-mm1/drivers/pci/hotplug/rpadlpar_sysfs.c:132: error: unknown field `subsys' specified in initializer
>> /usr/src/linux-2.6.22-rc1-mm1/drivers/pci/hotplug/rpadlpar_sysfs.c:132: warning: initialization from incompatible pointer type
>> make[4]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1
>> make[3]: *** [drivers/pci/hotplug] Error 2
>> make[2]: *** [drivers/pci] Error 2
>> make[1]: *** [drivers] Error 2
>> make: *** [_all] Error 2
>>
> 
> This is showing up on TKO as well and Andy Whitcroft has kicked it
> around a bit as far as I know. He makes it build with this patch
> http://test.kernel.org/abat/88951/build/patches/update-sysfs-kset-initialisation-in-PPC64-DLPAR-IO-driver
> 
> However, my understand is that the driver is broken even though it builds
> but I don't recall why. I've added Andy to the CC

Al Viro posted a patch yesterday that fixes this:

http://ozlabs.org/pipermail/linuxppc-dev/2007-May/036222.html

It's in mainline now.

-Brian

WARNING: multiple messages have this Message-ID (diff)
From: Brian King <brking@linux.vnet.ibm.com>
To: Mel Gorman <mel@skynet.ie>
Cc: Bob Picco <bob.picco@hp.com>,
	linuxppc-dev@ozlabs.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: PPC64 build breakage drivers/pci/hotplug/rpadlpar_sysfs.c
Date: Thu, 17 May 2007 08:37:41 -0500	[thread overview]
Message-ID: <464C5AA5.3090002@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070517104008.GA667@skynet.ie>

Mel Gorman wrote:
> On (16/05/07 09:30), Bob Picco didst pronounce:
>> bob.picco@hp.com
>> /usr/src/linux-2.6.22-rc1-mm1/drivers/pci/hotplug/rpadlpar_sysfs.c:132: error: unknown field `subsys' specified in initializer
>> /usr/src/linux-2.6.22-rc1-mm1/drivers/pci/hotplug/rpadlpar_sysfs.c:132: warning: initialization from incompatible pointer type
>> make[4]: *** [drivers/pci/hotplug/rpadlpar_sysfs.o] Error 1
>> make[3]: *** [drivers/pci/hotplug] Error 2
>> make[2]: *** [drivers/pci] Error 2
>> make[1]: *** [drivers] Error 2
>> make: *** [_all] Error 2
>>
> 
> This is showing up on TKO as well and Andy Whitcroft has kicked it
> around a bit as far as I know. He makes it build with this patch
> http://test.kernel.org/abat/88951/build/patches/update-sysfs-kset-initialisation-in-PPC64-DLPAR-IO-driver
> 
> However, my understand is that the driver is broken even though it builds
> but I don't recall why. I've added Andy to the CC

Al Viro posted a patch yesterday that fixes this:

http://ozlabs.org/pipermail/linuxppc-dev/2007-May/036222.html

It's in mainline now.

-Brian

  reply	other threads:[~2007-05-17 13:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-16 13:30 Bob Picco
2007-05-16 13:30 ` Bob Picco
2007-05-16 16:43 ` your mail Linas Vepstas
2007-05-16 16:43   ` Linas Vepstas
2007-05-16 17:11   ` Olof Johansson
2007-05-16 17:11     ` Olof Johansson
2007-05-16 17:24     ` Bob Picco
2007-05-16 17:24       ` Bob Picco
2007-05-17 10:40 ` PPC64 build breakage drivers/pci/hotplug/rpadlpar_sysfs.c Mel Gorman
2007-05-17 10:40   ` Mel Gorman
2007-05-17 13:37   ` Brian King [this message]
2007-05-17 13:37     ` Brian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464C5AA5.3090002@linux.vnet.ibm.com \
    --to=brking@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=bob.picco@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mel@skynet.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.