Re: [PATCH] SM56 Modem in Asus A8J Notebook Series

Re: [PATCH] SM56 Modem in Asus A8J Notebook Series

[Christian Rothländer]

[-- Attachment #1.1: Type: text/plain, Size: 1259 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi there

It's support for the SI3054 Chip build into the Asus A8J Notebook Series.
In Windows it's called "Motorola SM56".

What do you mean with "sign-off"?
I'm pretty happy when it walks into upstream, so that the requests on my homepage about how to patch alsa to run that
modem are ceasing down.

Just a small issue is left. With the alsa driver buildin into 2.6.19 slmodem is working, with any newer one (either
standalone or buildin driver) we have a "hda-intel: invalid format_val, rate=9600, ch=1, format=2" error in dmesg. Seems
something has been broken on that step (probably 1.0.13 to 1.0.14?). Sadly I'm not able to tell right now which alsa was
included into 2.6.19. I'm trying to compare the files to get an idea what's wrong (#2799 and #2820 are reporting similar
problems).

Christian


Takashi Iwai wrote:
> Thanks, the patch looks good to me.
> Could you give a brief description of the patch and your sign-off to
> merge to the upstream?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGTbafYMBp7Qf+VpkRAgl1AJ4uWR1vVVE6APAMB2SQjcPmhByJpQCfdweP
vJZuXa7/0njBJ0h8vFWdUH0=
=Dbm9
-----END PGP SIGNATURE-----

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3839 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[PATCH] SM56 Modem in Asus A8J Notebook Series

[Christian Rothländer]

[-- Attachment #1.1.1: Type: text/plain, Size: 640 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi there

after I submitted the solution 5 month ago in the Bug system, I am trying it now directly.
Attached to this posting is the necessary patch to get this modem working with slmodemd.

The Patch is against alsa-driver-1.0.14rc4/alsa-kernel/pci/hda/patch_si3054.c

if included it's Bug #0002732, assigned to tiwai.

Greetings Christian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGTadQYMBp7Qf+VpkRAp8MAJ9lii0FA/lBZPRabFxWIiVVJnAh7wCdGEkk
fH0mFw4iOP3S9BHcTor3qVo=
=suhj
-----END PGP SIGNATURE-----

[-- Attachment #1.1.2: SM56.patch --]
[-- Type: text/plain, Size: 430 bytes --]

--- patch_si3054.c	2007-05-18 15:06:23.000000000 +0200
+++ patch_si3054.c	2007-05-18 15:06:56.000000000 +0200
@@ -305,6 +305,7 @@
  	{ .id = 0x10573055, .name = "Si3054", .patch = patch_si3054 },
  	{ .id = 0x10573057, .name = "Si3054", .patch = patch_si3054 },
  	{ .id = 0x10573155, .name = "Si3054", .patch = patch_si3054 },
+	{ .id = 0x15433155, .name = "Si3054", .patch = patch_si3054 }, /*Asus A8J Modem (SM56)*/
 	{}
 };
 

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3839 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] SM56 Modem in Asus A8J Notebook Series

[Takashi Iwai]

At Fri, 18 May 2007 15:17:05 +0200,
Christian Rothländer wrote:
> 
> Hi there
> 
> after I submitted the solution 5 month ago in the Bug system, I am trying it now directly.
> Attached to this posting is the necessary patch to get this modem working with slmodemd.
> 
> The Patch is against alsa-driver-1.0.14rc4/alsa-kernel/pci/hda/patch_si3054.c
> 
> if included it's Bug #0002732, assigned to tiwai.
> 
> Greetings Christian

Thanks, the patch looks good to me.
Could you give a brief description of the patch and your sign-off to
merge to the upstream?


thanks,

Takashi


> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.4 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFGTadQYMBp7Qf+VpkRAp8MAJ9lii0FA/lBZPRabFxWIiVVJnAh7wCdGEkk
> fH0mFw4iOP3S9BHcTor3qVo=
> =suhj
> -----END PGP SIGNATURE-----
> [1.1.2 SM56.patch <text/plain (7bit)>]
> --- patch_si3054.c	2007-05-18 15:06:23.000000000 +0200
> +++ patch_si3054.c	2007-05-18 15:06:56.000000000 +0200
> @@ -305,6 +305,7 @@
>   	{ .id = 0x10573055, .name = "Si3054", .patch = patch_si3054 },
>   	{ .id = 0x10573057, .name = "Si3054", .patch = patch_si3054 },
>   	{ .id = 0x10573155, .name = "Si3054", .patch = patch_si3054 },
> +	{ .id = 0x15433155, .name = "Si3054", .patch = patch_si3054 }, /*Asus A8J Modem (SM56)*/
>  	{}
>  };
>  
> [1.2 S/MIME Cryptographic Signature <application/x-pkcs7-signature (base64)>]
> 
> [2  <text/plain; us-ascii (7bit)>]
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] SM56 Modem in Asus A8J Notebook Series

[Christian Rothländer]

[-- Attachment #1.1: Type: text/plain, Size: 1695 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> > It's a process to merge to the upstream kernel.  We need to give a
> > kind of approval from the patch authors and contributors.
> > It consists of a line

ok .. something new for me  :-)
Here it goes:

Signed-off-by: Christian Rothlaender <christian@rothlaender.net>

================================================================
hda-codec - patch_si3045.c

This patch adds support for the ASUS A8J Series 56k Modem (Motorola SM56)

Signed-off-by: Christian Rothlaender <christian@rothlaender.net>

THE PATCH STARTS BELOW
================================================================


> Just a small issue is left. With the alsa driver buildin into 2.6.19
> slmodem is working, with any newer one (either
> standalone or buildin driver) we have a "hda-intel: invalid
> format_val, rate=9600, ch=1, format=2" error in dmesg. Seems
> something has been broken on that step (probably 1.0.13 to
> 1.0.14?). Sadly I'm not able to tell right now which alsa was
> included into 2.6.19. I'm trying to compare the files to get an idea
> what's wrong (#2799 and #2820 are reporting similar
> problems).
> >
> > This should have been fixed in the recent version.
> > The driver dropped the support of 9600HZ accidentally.

That's really good to hear. Can you close the Bug entry #2732 then?
(#2799 and #2820 can be closed too, if the 9600 Hz problem is solved)

So thanks a lot ...

Christian

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGTbwUYMBp7Qf+VpkRApyKAJ4xfBkrLiG1D7whZIV1CteUTRhFagCfd/LU
2jeMsy1MQ/WxX5A7P/iThjM=
=A9s6
-----END PGP SIGNATURE-----

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3839 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] SM56 Modem in Asus A8J Notebook Series

[Takashi Iwai]

At Fri, 18 May 2007 16:45:40 +0200,
Christian Rothländer wrote:
> 
> > > It's a process to merge to the upstream kernel.  We need to give a
> > > kind of approval from the patch authors and contributors.
> > > It consists of a line
> 
> ok .. something new for me  :-)
> Here it goes:
> 
> Signed-off-by: Christian Rothlaender <christian@rothlaender.net>
> 
> ================================================================
> hda-codec - patch_si3045.c
> 
> This patch adds support for the ASUS A8J Series 56k Modem (Motorola SM56)
> 
> Signed-off-by: Christian Rothlaender <christian@rothlaender.net>
> 
> THE PATCH STARTS BELOW
> ================================================================

Thanks.  I meant 'THE PATCH STARTS BELOW' as to paste the actual patch
content there :)  Also, the first line is the patch summary, which
explains the patch briefly.

Anyway, I applied your patch to ALSA HG tree now.
It should be included in the next 1.0.14 (hopefully final) release.

> 
> > Just a small issue is left. With the alsa driver buildin into 2.6.19
> > slmodem is working, with any newer one (either
> > standalone or buildin driver) we have a "hda-intel: invalid
> > format_val, rate=9600, ch=1, format=2" error in dmesg. Seems
> > something has been broken on that step (probably 1.0.13 to
> > 1.0.14?). Sadly I'm not able to tell right now which alsa was
> > included into 2.6.19. I'm trying to compare the files to get an idea
> > what's wrong (#2799 and #2820 are reporting similar
> > problems).
> > >
> > > This should have been fixed in the recent version.
> > > The driver dropped the support of 9600HZ accidentally.
> 
> That's really good to hear. Can you close the Bug entry #2732 then?
> (#2799 and #2820 can be closed too, if the 9600 Hz problem is solved)

OK, will do.

Thanks!


Takashi