From: Andrea Righi <righiandr@users.sourceforge.net>
To: rgooch@atnf.csiro.au
Cc: LKML <linux-kernel@vger.kernel.org>, qemu-devel@nongnu.org
Subject: 2.6.22-rc2: bug in i386 MTRR initialization
Date: Sat, 19 May 2007 16:09:35 +0200 (MEST) [thread overview]
Message-ID: <464F0515.80304@users.sourceforge.net> (raw)
BUG: at include/linux/slub_def.h:77 kmalloc_index()
[<c0168eb0>] get_slab+0x1d0/0x260
[<c0169056>] __kmalloc+0x16/0x70
[<c042b0ff>] sysenter_setup+0x6f/0x330
[<c010baed>] mtrr_bp_init+0xcd/0x270
[<c041a480>] unknown_bootoption+0x0/0x250
[<c041a480>] unknown_bootoption+0x0/0x250
[<c0423f78>] check_bugs+0x8/0x160
[<c01a644c>] proc_sys_init+0xc/0x30
[<c041a8ef>] start_kernel+0x21f/0x2b0
[<c041a480>] unknown_bootoption+0x0/0x250
=======================
Reproduced running 2.6.22-rc2 (using SLUB) in a virtual machine with qemu 0.9.0
+ kqemu 1.3.0pre11. It occurs only using "-kernel-kqemu" option (full
virtualization mode).
In this case mtrr is supported by the real cpu, but no mtrr range is found,
resulting in a kmalloc(0, GFP_KERNEL) in get_mtrr_state() and init_table().
I don't know if it's an incorrect behaviour of qemu in the mtrr emulation, but I
think it should be handled properly.
Signed-off-by: Andrea Righi <a.righi@cineca.it>
--- linux-2.6.22-rc2/arch/i386/kernel/cpu/mtrr/generic.c.orig 2007-05-19 15:55:24.000000000 +0200
+++ linux-2.6.22-rc2/arch/i386/kernel/cpu/mtrr/generic.c 2007-05-19 15:57:51.000000000 +0200
@@ -84,6 +84,9 @@ void get_mtrr_state(void)
struct mtrr_var_range *vrs;
unsigned lo, dummy;
+ if (!num_var_ranges)
+ return;
+
if (!mtrr_state.var_ranges) {
mtrr_state.var_ranges = kmalloc(num_var_ranges * sizeof (struct mtrr_var_range),
GFP_KERNEL);
--- linux-2.6.22-rc2/arch/i386/kernel/cpu/mtrr/main.c.orig 2007-05-19 15:55:12.000000000 +0200
+++ linux-2.6.22-rc2/arch/i386/kernel/cpu/mtrr/main.c 2007-05-19 15:55:42.000000000 +0200
@@ -120,6 +120,11 @@ static void __init init_table(void)
{
int i, max;
+ if (!num_var_ranges) {
+ printk(KERN_ERR "mtrr: no MTRR range found.\n");
+ return;
+ }
+
max = num_var_ranges;
if ((usage_table = kmalloc(max * sizeof *usage_table, GFP_KERNEL))
== NULL) {
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Righi <righiandr@users.sourceforge.net>
To: rgooch@atnf.csiro.au
Cc: LKML <linux-kernel@vger.kernel.org>, qemu-devel@nongnu.org
Subject: [Qemu-devel] 2.6.22-rc2: bug in i386 MTRR initialization
Date: Sat, 19 May 2007 16:09:35 +0200 (MEST) [thread overview]
Message-ID: <464F0515.80304@users.sourceforge.net> (raw)
BUG: at include/linux/slub_def.h:77 kmalloc_index()
[<c0168eb0>] get_slab+0x1d0/0x260
[<c0169056>] __kmalloc+0x16/0x70
[<c042b0ff>] sysenter_setup+0x6f/0x330
[<c010baed>] mtrr_bp_init+0xcd/0x270
[<c041a480>] unknown_bootoption+0x0/0x250
[<c041a480>] unknown_bootoption+0x0/0x250
[<c0423f78>] check_bugs+0x8/0x160
[<c01a644c>] proc_sys_init+0xc/0x30
[<c041a8ef>] start_kernel+0x21f/0x2b0
[<c041a480>] unknown_bootoption+0x0/0x250
=======================
Reproduced running 2.6.22-rc2 (using SLUB) in a virtual machine with qemu 0.9.0
+ kqemu 1.3.0pre11. It occurs only using "-kernel-kqemu" option (full
virtualization mode).
In this case mtrr is supported by the real cpu, but no mtrr range is found,
resulting in a kmalloc(0, GFP_KERNEL) in get_mtrr_state() and init_table().
I don't know if it's an incorrect behaviour of qemu in the mtrr emulation, but I
think it should be handled properly.
Signed-off-by: Andrea Righi <a.righi@cineca.it>
--- linux-2.6.22-rc2/arch/i386/kernel/cpu/mtrr/generic.c.orig 2007-05-19 15:55:24.000000000 +0200
+++ linux-2.6.22-rc2/arch/i386/kernel/cpu/mtrr/generic.c 2007-05-19 15:57:51.000000000 +0200
@@ -84,6 +84,9 @@ void get_mtrr_state(void)
struct mtrr_var_range *vrs;
unsigned lo, dummy;
+ if (!num_var_ranges)
+ return;
+
if (!mtrr_state.var_ranges) {
mtrr_state.var_ranges = kmalloc(num_var_ranges * sizeof (struct mtrr_var_range),
GFP_KERNEL);
--- linux-2.6.22-rc2/arch/i386/kernel/cpu/mtrr/main.c.orig 2007-05-19 15:55:12.000000000 +0200
+++ linux-2.6.22-rc2/arch/i386/kernel/cpu/mtrr/main.c 2007-05-19 15:55:42.000000000 +0200
@@ -120,6 +120,11 @@ static void __init init_table(void)
{
int i, max;
+ if (!num_var_ranges) {
+ printk(KERN_ERR "mtrr: no MTRR range found.\n");
+ return;
+ }
+
max = num_var_ranges;
if ((usage_table = kmalloc(max * sizeof *usage_table, GFP_KERNEL))
== NULL) {
next reply other threads:[~2007-05-19 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-19 14:09 Andrea Righi [this message]
2007-05-19 14:09 ` [Qemu-devel] 2.6.22-rc2: bug in i386 MTRR initialization Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464F0515.80304@users.sourceforge.net \
--to=righiandr@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rgooch@atnf.csiro.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.