[PATCH] removes mismatch section warnigs in sparc time.c file

[PATCH] removes mismatch section warnigs in sparc time.c file

[Krzysztof Helt]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

From: Krzysztof Helt <krzysztof.h1@wp.pl>

This patch removes mismatch section warnings in the sparc/kernel/time.c 
file.

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>

---
The patch diff-ed agains 2.6.22-rc2


[-- Attachment #2: time-init-warnings.diff --]
[-- Type: text/plain, Size: 875 bytes --]

diff -urp linux-2.6.21/arch/sparc/kernel/time.c linux-2.6.21.new/arch/sparc/kernel/time.c
--- linux-2.6.21/arch/sparc/kernel/time.c	2007-05-20 18:44:32.341445642 +0200
+++ linux-2.6.21.new/arch/sparc/kernel/time.c	2007-05-20 19:04:42.722421323 +0200
@@ -148,7 +148,7 @@ irqreturn_t timer_interrupt(int irq, voi
 }
 
 /* Kick start a stopped clock (procedure from the Sun NVRAM/hostid FAQ). */
-static void __init kick_start_clock(void)
+static void __devinit kick_start_clock(void)
 {
 	struct mostek48t02 *regs = (struct mostek48t02 *)mstk48t02_regs;
 	unsigned char sec;
@@ -223,7 +223,7 @@ static __inline__ int has_low_battery(vo
 	return (data1 == data2);	/* Was the write blocked? */
 }
 
-static void __init mostek_set_system_time(void)
+static void __devinit mostek_set_system_time(void)
 {
 	unsigned int year, mon, day, hour, min, sec;
 	struct mostek48t02 *mregs;

Re: [PATCH] removes mismatch section warnigs in sparc time.c file

[David Miller]

From: Krzysztof Helt <krzysztof.h1@wp.pl>
Date: Sun, 20 May 2007 19:11:25 +0200

> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> This patch removes mismatch section warnings in the sparc/kernel/time.c 
> file.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>

Why in the world do you have CONFIG HOTPLUG enabled on sparc32?
That's the only way I see that you could trigger this warning.
No hotplugging is possible with any device type at all
on that platform :-)

But of course the patch is correct so I'll apply this, thank
you.

Re: [PATCH] removes mismatch section warnigs in sparc time.c file

[Krzysztof Helt]

David Miller wrote:

> Why in the world do you have CONFIG HOTPLUG enabled on sparc32?
> That's the only way I see that you could trigger this warning.
> No hotplugging is possible with any device type at all
> on that platform :-)
> 

I have checked. The CONFIG_HOTPLUG is y by default and is selectable (visible option) only 
if CONFIG_EMBEDDED is set.

Simply, I cannot disable it with menuconfig so I never thought about it.

Regards,
Krzysztof