[PATCH] libnetfilter_conntrack bug in snprintf_xml.c

[PATCH] libnetfilter_conntrack bug in snprintf_xml.c

[Morten Isaksen]

The port numbers are wrong in the XML output.

Index: src/conntrack/snprintf_xml.c
===================================================================
--- src/conntrack/snprintf_xml.c        (revision 6832)
+++ src/conntrack/snprintf_xml.c        (working copy)
@@ -182,13 +182,13 @@
        case IPPROTO_SCTP:
                if (type == __ADDR_SRC) {
                        ret = snprintf(buf, len, "<sport>%u</sport>",
-                                      tuple->l4src.tcp.port);
+                                      htons(tuple->l4src.tcp.port));
                        if (ret == -1)
                                return -1;
                        buffer_size(ret, &size, &len);
                } else {
                        ret = snprintf(buf, len, "<dport>%u</dport>",
-                                      tuple->l4dst.tcp.port);
+                                      htons(tuple->l4dst.tcp.port));
                        if (ret == -1)
                                return -1;
                        buffer_size(ret, &size, &len);



Regards
Morten Isaksen
http://misak.dk/blog/

Re: [PATCH] libnetfilter_conntrack bug in snprintf_xml.c

[Pablo Neira Ayuso]

Morten Isaksen wrote:
> The port numbers are wrong in the XML output.
> 
> Index: src/conntrack/snprintf_xml.c
> ===================================================================
> --- src/conntrack/snprintf_xml.c        (revision 6832)
> +++ src/conntrack/snprintf_xml.c        (working copy)
> @@ -182,13 +182,13 @@
>         case IPPROTO_SCTP:
>                 if (type == __ADDR_SRC) {
>                         ret = snprintf(buf, len, "<sport>%u</sport>",
> -                                      tuple->l4src.tcp.port);
> +                                      htons(tuple->l4src.tcp.port));
                                          ^^^

Thanks for spotting this, I just committed a patch to fix this problem.
BTW, this should be ntohs, snprintf_default has the same stupid mistake.
Anyway this doesn't affect anything since ntohs and htons do the same :)

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris