From: Krzysztof Helt <krzysztof.h1@wp.pl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] THMC50 review
Date: Tue, 22 May 2007 18:03:12 +0000 [thread overview]
Message-ID: <4654832B.4060405@wp.pl> (raw)
In-Reply-To: <web-67221254@hhs.nl>
Jean Delvare wrote:
> On Mon, 21 May 2007 21:49:26 +0200, Goede, J.W.R. de wrote:
>> Actually keeping a queue that can be used with people which
>> have time to review sounds like a plan. I think we should
>> create a page for this at the trac wiki. Mark AFAIK you've
>> been collecting reviews, can you create such a page. (I can
>> do it myself but I don't have a list of everything that
>> needs reviewing).
>
> This certainly doesn't prevent you from creating such a page. If the
> list is incomplete, it can be completed later, by Mark or others.
>
The great thing would be to mark who is going to review the driver (after it is decided), so a contributor of the patch can see how far in the queue the driver is.
> Note that I am already trying to maintain
> http://www.lm-sensors.org/wiki/Devices
> with this information. If you search for "review" on this page, you
> should find most drivers waiting for a review, with a link to the
> latest version that was posted.
The information about the ADM1022 is not accurate. I have not tested the 2.4 kernel, but the thmc50 driver do not handle the adm1022 mode. It means that it works if the adm1022 is working as the pure thmc50 (which is default). This is not true for my motherboard. The adm1022 works in an extended mode (two external temperatures) and the 2.4 I used to create the 2.6 patch did not handle this. The result of incorrect mode wss the fan forced to full speed.
I may fix it.
Regards,
Krzysztof
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-05-22 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-21 19:49 [lm-sensors] THMC50 review Goede, J.W.R. de
2007-05-22 15:19 ` Jean Delvare
2007-05-22 18:03 ` Krzysztof Helt [this message]
2007-05-22 18:34 ` Juerg Haefliger
2007-05-27 18:14 ` Mark M. Hoffman
2007-05-28 16:40 ` Jean Delvare
2007-05-28 17:12 ` Jean Delvare
2007-05-28 17:22 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4654832B.4060405@wp.pl \
--to=krzysztof.h1@wp.pl \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.