[KJ] Anybody is working on this todo ?

[KJ] Anybody is working on this todo ?

[linux newbie]

[-- Attachment #1.1: Type: text/plain, Size: 962 bytes --]

Hello,

      I am a newbie . I would to start my kernal hacking by code cleanup. I
would like to do the following work.

-------------------------------------------------------------------------------
From: Greg KH

- delete all pci_find_* functions from the kernel tree. Instead of
pci_find_device use pci_get_device().

> Looking at pci.txt, it appears that if I use pci_get_device(), I will >
also need to use pci_dev_put().

also check using the proper shutdown callback.

- convert from pci_module_init to pci_register_driver

- don't do it for drivers that are 2.4 compatible
-----------------------------------------------------------------------------------------------------

    Right now my laptop is not ready with linux.. I hope I will get ready to
go soon (expecting within 2 or 3 days). Before that I just wanted to know
that Anybody is working on this job. If so, I am ready to help them out ...
otherwise have to take other job.

Thanks
newbie

[-- Attachment #1.2: Type: text/html, Size: 2052 bytes --]

[-- Attachment #2: Type: text/plain, Size: 187 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] Anybody is working on this todo ?

[Richard Knutsson]

linux newbie wrote:
>
> > Looking at pci.txt, it appears that if I use pci_get_device(), I 
> will > also need to use pci_dev_put().
>
> also check using the proper shutdown callback.
>
If you have not seen it already, there is a wiki: 
http://fsdev.net/wiki/index.php?title=Kernel_Janitor%27s_Todo_List
>
> - convert from pci_module_init to pci_register_driver
>
It has (finally) been completed (at least in the Linus' git-tree).

BTW 'newbie', it is much preferred if you use your real name, especially 
when you are going to be an author to patches. Or at least get a more 
unique alias.
We are all newbies in the beginning, you know. ;)

Happy hacking
Richard Knutsson

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] Anybody is working on this todo ?

[Randy Dunlap]

On Thu, 24 May 2007 19:55:02 +0200 Richard Knutsson wrote:

> linux newbie wrote:
> >
> > > Looking at pci.txt, it appears that if I use pci_get_device(), I 
> > will > also need to use pci_dev_put().
> >
> > also check using the proper shutdown callback.
> >
> If you have not seen it already, there is a wiki: 
> http://fsdev.net/wiki/index.php?title=Kernel_Janitor%27s_Todo_List
> >
> > - convert from pci_module_init to pci_register_driver
> >
> It has (finally) been completed (at least in the Linus' git-tree).

We need to have that marked as completed or removed, please...


> BTW 'newbie', it is much preferred if you use your real name, especially 
> when you are going to be an author to patches. Or at least get a more 
> unique alias.

Right.

> We are all newbies in the beginning, you know. ;)


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] Anybody is working on this todo ?

[Richard Knutsson]

Randy Dunlap wrote:
> On Thu, 24 May 2007 19:55:02 +0200 Richard Knutsson wrote:
>
>   
>> linux newbie wrote:
>>     
>>> - convert from pci_module_init to pci_register_driver
>>>
>>>       
>> It has (finally) been completed (at least in the Linus' git-tree).
>>     
>
> We need to have that marked as completed or removed, please...
>   
Done (guess you meant on http://kernelnewbies.org/KernelJanitors/Todo).

Richard Knutsson

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] Anybody is working on this todo ?

[Randy Dunlap]

On Thu, 24 May 2007 20:48:28 +0200 Richard Knutsson wrote:

> Randy Dunlap wrote:
> > On Thu, 24 May 2007 19:55:02 +0200 Richard Knutsson wrote:
> >
> >   
> >> linux newbie wrote:
> >>     
> >>> - convert from pci_module_init to pci_register_driver
> >>>
> >>>       
> >> It has (finally) been completed (at least in the Linus' git-tree).
> >>     
> >
> > We need to have that marked as completed or removed, please...
> >   
> Done (guess you meant on http://kernelnewbies.org/KernelJanitors/Todo).

Thanks, but what about the entry at fsdev.net ?
We don't want people starting on this project from there either...

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] Anybody is working on this todo ?

[Richard Knutsson]

Randy Dunlap wrote:
> On Thu, 24 May 2007 20:48:28 +0200 Richard Knutsson wrote:
>
>   
>> Randy Dunlap wrote:
>>     
>>> On Thu, 24 May 2007 19:55:02 +0200 Richard Knutsson wrote:
>>>
>>>   
>>>       
>>>> linux newbie wrote:
>>>>     
>>>>         
>>>>> - convert from pci_module_init to pci_register_driver
>>>>>
>>>>>       
>>>>>           
>>>> It has (finally) been completed (at least in the Linus' git-tree).
>>>>     
>>>>         
>>> We need to have that marked as completed or removed, please...
>>>   
>>>       
>> Done (guess you meant on http://kernelnewbies.org/KernelJanitors/Todo).
>>     
>
> Thanks, but what about the entry at fsdev.net ?
> We don't want people starting on this project from there either...
>   
I must be blind, can not find anything about pci_module_init. Please 
point me to it.
I removed an entry with it a month ago when the pci_module_init-removal 
patch got into mainline and have not seen anything about it since then.

Richard Knutsson


_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] Anybody is working on this todo ?

[Randy Dunlap]

On Thu, 24 May 2007 21:54:56 +0200 Richard Knutsson wrote:

> Randy Dunlap wrote:
> > On Thu, 24 May 2007 20:48:28 +0200 Richard Knutsson wrote:
> >
> >   
> >> Randy Dunlap wrote:
> >>     
> >>> On Thu, 24 May 2007 19:55:02 +0200 Richard Knutsson wrote:
> >>>
> >>>   
> >>>       
> >>>> linux newbie wrote:
> >>>>     
> >>>>         
> >>>>> - convert from pci_module_init to pci_register_driver
> >>>>>
> >>>>>       
> >>>>>           
> >>>> It has (finally) been completed (at least in the Linus' git-tree).
> >>>>     
> >>>>         
> >>> We need to have that marked as completed or removed, please...
> >>>   
> >>>       
> >> Done (guess you meant on http://kernelnewbies.org/KernelJanitors/Todo).
> >>     
> >
> > Thanks, but what about the entry at fsdev.net ?
> > We don't want people starting on this project from there either...
> >   
> I must be blind, can not find anything about pci_module_init. Please 
> point me to it.
> I removed an entry with it a month ago when the pci_module_init-removal 
> patch got into mainline and have not seen anything about it since then.

My bad.  I was looking too quickly and read pci_find_device() [at fsdev.net]
as pci_module_init().  Sorry about that.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] Anybody is working on this todo ?

[linux newbie]

[-- Attachment #1.1: Type: text/plain, Size: 1515 bytes --]

Hello All,

      Thanks for your reply  and suggestions.

      Is there any updated TODO list where i can choose some item ?.

Thanks
Prakash




On 5/25/07, Randy Dunlap <rdunlap@xenotime.net> wrote:
>
> On Thu, 24 May 2007 21:54:56 +0200 Richard Knutsson wrote:
>
> > Randy Dunlap wrote:
> > > On Thu, 24 May 2007 20:48:28 +0200 Richard Knutsson wrote:
> > >
> > >
> > >> Randy Dunlap wrote:
> > >>
> > >>> On Thu, 24 May 2007 19:55:02 +0200 Richard Knutsson wrote:
> > >>>
> > >>>
> > >>>
> > >>>> linux newbie wrote:
> > >>>>
> > >>>>
> > >>>>> - convert from pci_module_init to pci_register_driver
> > >>>>>
> > >>>>>
> > >>>>>
> > >>>> It has (finally) been completed (at least in the Linus' git-tree).
> > >>>>
> > >>>>
> > >>> We need to have that marked as completed or removed, please...
> > >>>
> > >>>
> > >> Done (guess you meant on http://kernelnewbies.org/KernelJanitors/Todo
> ).
> > >>
> > >
> > > Thanks, but what about the entry at fsdev.net ?
> > > We don't want people starting on this project from there either...
> > >
> > I must be blind, can not find anything about pci_module_init. Please
> > point me to it.
> > I removed an entry with it a month ago when the pci_module_init-removal
> > patch got into mainline and have not seen anything about it since then.
>
> My bad.  I was looking too quickly and read pci_find_device() [at
> fsdev.net]
> as pci_module_init().  Sorry about that.
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code
> ***
>

[-- Attachment #1.2: Type: text/html, Size: 2511 bytes --]

[-- Attachment #2: Type: text/plain, Size: 187 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] Anybody is working on this todo ?

[Robert P. J. Day]

On Thu, 24 May 2007, Richard Knutsson wrote:

> linux newbie wrote:
> >
> > > Looking at pci.txt, it appears that if I use pci_get_device(), I will >
> > also need to use pci_dev_put().
> >
> > also check using the proper shutdown callback.
> >
> If you have not seen it already, there is a wiki:
> http://fsdev.net/wiki/index.php?title=Kernel_Janitor%27s_Todo_List
> >
> > - convert from pci_module_init to pci_register_driver
> >
> It has (finally) been completed (at least in the Linus' git-tree).

in that case, feel free to edit the wiki and remove that entry.  no
sense leaving it hanging around.

rday
-- 
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
====================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] Anybody is working on this todo ?

[Robert P. J. Day]

On Thu, 24 May 2007, Richard Knutsson wrote:

> I must be blind, can not find anything about pci_module_init. Please point me
> to it.
> I removed an entry with it a month ago when the pci_module_init-removal patch
> got into mainline and have not seen anything about it since then.

the only thing at

http://fsdev.net/wiki/index.php?title=Kernel_Janitor%27s_Todo_List

related to PCI is the "cleanup of pci_find_device" under "Obsolete and
deprecated stuff".  is that still in progress?  other than that,
there's nothing else PCI-related that i can see.

rday
-- 
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
====================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors