From: Jeff Garzik <jeff@garzik.org>
To: Ayaz Abdulla <aabdulla@nvidia.com>
Cc: Manfred Spraul <manfred@colorfullife.com>,
Andrew Morton <akpm@osdl.org>, nedev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/4] forcedeth: add vitesse phy
Date: Thu, 24 May 2007 17:54:50 -0400 [thread overview]
Message-ID: <465609AA.8020906@garzik.org> (raw)
In-Reply-To: <465237D5.4050809@nvidia.com>
Ayaz Abdulla wrote:
> This patch adds errata support for the vitesse phy.
>
> Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
>
>
> ------------------------------------------------------------------------
>
> --- old/drivers/net/forcedeth.c 2007-05-01 15:30:53.000000000 -0400
> +++ new/drivers/net/forcedeth.c 2007-05-01 15:30:57.000000000 -0400
> @@ -550,6 +550,7 @@
> /* PHY defines */
> #define PHY_OUI_MARVELL 0x5043
> #define PHY_OUI_CICADA 0x03f1
> +#define PHY_OUI_VITESSE 0x01c1
> #define PHYID1_OUI_MASK 0x03ff
> #define PHYID1_OUI_SHFT 6
> #define PHYID2_OUI_MASK 0xfc00
> @@ -557,12 +558,29 @@
> #define PHYID2_MODEL_MASK 0x03f0
> #define PHY_MODEL_MARVELL_E3016 0x220
> #define PHY_MARVELL_E3016_INITMASK 0x0300
> -#define PHY_INIT1 0x0f000
> -#define PHY_INIT2 0x0e00
> -#define PHY_INIT3 0x01000
> -#define PHY_INIT4 0x0200
> -#define PHY_INIT5 0x0004
> -#define PHY_INIT6 0x02000
> +#define PHY_CICADA_INIT1 0x0f000
> +#define PHY_CICADA_INIT2 0x0e00
> +#define PHY_CICADA_INIT3 0x01000
> +#define PHY_CICADA_INIT4 0x0200
> +#define PHY_CICADA_INIT5 0x0004
> +#define PHY_CICADA_INIT6 0x02000
Please split this into two patches:
1) rename PHY_INIT symbols to PHY_CICADA_INIT
2) add vitesse phy errata workarounds
otherwise, looks OK
prev parent reply other threads:[~2007-05-24 21:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 0:22 [PATCH 1/4] forcedeth: add vitesse phy Ayaz Abdulla
2007-05-24 21:54 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465609AA.8020906@garzik.org \
--to=jeff@garzik.org \
--cc=aabdulla@nvidia.com \
--cc=akpm@osdl.org \
--cc=manfred@colorfullife.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.