All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manu Abraham <abraham.manu@gmail.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Grant Grundler <grundler@parisc-linux.org>,
	Greg KH <greg@kroah.com>,
	linux-pci@atrey.karlin.mff.cuni.cz,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: PCIE
Date: Mon, 28 May 2007 06:47:58 +0400	[thread overview]
Message-ID: <465A42DE.1030909@gmail.com> (raw)
In-Reply-To: <adahcpx1y89.fsf@cisco.com>

Roland Dreier wrote:
>  > > At least on my device (PCI ID 1131:7162) there is no MSI-X capability,
>  > > so that's not an option for you.  The current Linux implementation
>  > > does not support more than one MSI interrupt, so you just get one
>  > > interrupt with pci_enable_msi().
>  > 
>  > This would mean MSI or MSI-X ?  A bit confused now.
> 
> As I said, the device I have in my system:
> 
>     02:00.0 Multimedia controller: Philips Semiconductors Unknown device 7162
>             Subsystem: Animation Technologies Inc. Unknown device 0820
>             Flags: bus master, fast devsel, latency 0, IRQ 11
>             Memory at 90200000 (64-bit, non-prefetchable) [size=1M]
>             Capabilities: [40] Message Signalled Interrupts: Mask- 64bit+ Queue=0/5 Enable-
>             Capabilities: [50] Express Endpoint IRQ 0
>             Capabilities: [74] Power Management version 2
>             Capabilities: [80] Vendor Specific Information
> 
> ...has only an MSI capability (the "[40] Message Signalled Interrupts"
> line).  So MSI-X is not possible, since the device cannot do it.  And
> that means you can at most do pci_enable_msi().  The current Linux MSI
> support only handles a single interrupt, just like you get normally
> (no matter how many MSI interrupts a device can handle).  To get
> multiple interrupts from a single device under Linux, you must use
> MSI-X and pci_enable_msix -- but for this to work, your device must
> support MSI-X of course.
> 
> A device that supports both MSI and MSI-X would look like:
> 
>     0b:00.0 InfiniBand: Mellanox Technologies MT25204 [InfiniHost III Lx HCA] (rev 20)
>             Subsystem: Mellanox Technologies MT25204 [InfiniHost III Lx HCA]
>             Flags: bus master, fast devsel, latency 0, IRQ 16
>             Memory at fc600000 (64-bit, non-prefetchable) [size=1M]
>             Memory at d8800000 (64-bit, prefetchable) [size=8M]
>             Capabilities: [40] Power Management version 2
>             Capabilities: [48] Vital Product Data
>             Capabilities: [90] Message Signalled Interrupts: Mask- 64bit+ Queue=0/5 Enable-
>             Capabilities: [84] MSI-X: Enable- Mask- TabSize=32
>             Capabilities: [60] Express Endpoint IRQ 0
> 
> with both "Message Signalled Interrupts" and "MSI-X" capabilities.
> 

Thanks for the explanation.

> However, as I said before I think you shouldn't worry about MSI right
> now.  Since there are many systems where MSI doesn't work, you'll need
> to get the driver working with legacy (INTx) interrupts anyway.  And
> you seem to be in a bit over your head just doing that without adding
> the complexity of MSI on top, hence my recommendation to just focus on
> the basic driver.

True, compatibility would be important.

Thanks,
Manu


  reply	other threads:[~2007-05-28  2:48 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-23 12:15 PCIE Manu Abraham
2007-05-23 15:59 ` PCIE Greg KH
2007-05-23 20:59   ` PCIE Manu Abraham
2007-05-23 21:10     ` PCIE Roland Dreier
2007-05-23 22:11       ` PCIE Manu Abraham
2007-05-23 22:23         ` PCIE Roland Dreier
2007-05-23 23:03           ` PCIE Manu Abraham
2007-05-23 23:51             ` PCIE Roland Dreier
2007-05-24  0:07               ` PCIE Manu Abraham
2007-05-24 22:32               ` PCIE Manu Abraham
2007-05-25  3:25                 ` PCIE Roland Dreier
2007-05-26 15:03                   ` PCIE Manu Abraham
2007-05-26 18:28                     ` PCIE Grant Grundler
2007-05-26 19:27                       ` PCIE Manu Abraham
2007-05-28  1:15                         ` PCIE Roland Dreier
2007-05-28  1:25                           ` PCIE Manu Abraham
2007-05-28  2:04                           ` PCIE Manu Abraham
2007-05-28  2:24                             ` PCIE Roland Dreier
2007-05-28  2:47                               ` Manu Abraham [this message]
2007-05-26 22:49                     ` PCIE David Miller
2007-05-26 22:57                       ` PCIE Manu Abraham
2007-05-26 23:55                       ` PCIE Grant Grundler
2007-05-27  0:00                         ` PCIE David Miller
2007-05-27  0:16                           ` PCIE Grant Grundler
2007-05-27  0:30                             ` PCIE David Miller
2007-05-27  1:01                               ` PCIE Manu Abraham
2007-05-27  1:49                                 ` PCIE Grant Grundler
2007-05-27 20:28                                   ` PCIE Manu Abraham
2007-05-28  1:10                           ` PCIE Roland Dreier
2007-05-27  2:34                       ` PCIE H. Peter Anvin
2007-05-27  7:40                         ` PCIE David Miller
2007-05-27 20:31                           ` PCIE Manu Abraham
2007-05-28  1:05                         ` PCIE Roland Dreier
2007-05-28  1:03                       ` PCIE Roland Dreier
2007-05-28  2:54                         ` PCIE David Miller
2007-05-28  4:18                         ` PCIE Grant Grundler
2007-05-28  5:23                           ` PCIE H. Peter Anvin
2007-05-28  5:22                         ` PCIE H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465A42DE.1030909@gmail.com \
    --to=abraham.manu@gmail.com \
    --cc=greg@kroah.com \
    --cc=grundler@parisc-linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.