From: Jeff Garzik <jeff@garzik.org>
To: divy@chelsio.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
swise@opengridcomputing.com
Subject: Re: [PATCH 1/7] cxgb3 - Fix SGE page management
Date: Mon, 28 May 2007 18:34:06 -0400 [thread overview]
Message-ID: <465B58DE.1010308@garzik.org> (raw)
In-Reply-To: <20070526225947.12097.82363.stgit@localhost.localdomain>
divy@chelsio.com wrote:
> From: Divy Le Ray <divy@chelsio.com>
>
> Streamline page management on RX.
> Fix dma mappings.
>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
NAK #1: "streamline" is not a bug-fixes-only change, which is the only
type of change appropriate for 2.6.22-rc.
NAK #2: You should use the page_address(page) accessor rather than
creating a struct member in the same struct as your page, solely to
contain the virtual address.
next prev parent reply other threads:[~2007-05-28 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-26 22:59 [PATCH 1/7] cxgb3 - Fix SGE page management divy
2007-05-28 22:34 ` Jeff Garzik [this message]
2007-05-31 4:10 ` Divy Le Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465B58DE.1010308@garzik.org \
--to=jeff@garzik.org \
--cc=divy@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.