From: Divy Le Ray <divy@chelsio.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
swise@opengridcomputing.com
Subject: Re: [PATCH 1/7] cxgb3 - Fix SGE page management
Date: Wed, 30 May 2007 21:10:17 -0700 [thread overview]
Message-ID: <465E4AA9.70706@chelsio.com> (raw)
In-Reply-To: <465B58DE.1010308@garzik.org>
Jeff Garzik wrote:
> divy@chelsio.com wrote:
>> From: Divy Le Ray <divy@chelsio.com>
>>
>> Streamline page management on RX.
>> Fix dma mappings.
>>
>
> NAK #2: You should use the page_address(page) accessor rather than
> creating a struct member in the same struct as your page, solely to
> contain the virtual address.
Jeff,
The struct member caches the value of page_address(page) + current
offset for optimization purposes.
Divy
prev parent reply other threads:[~2007-05-31 4:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-26 22:59 [PATCH 1/7] cxgb3 - Fix SGE page management divy
2007-05-28 22:34 ` Jeff Garzik
2007-05-31 4:10 ` Divy Le Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465E4AA9.70706@chelsio.com \
--to=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.