From: Jeff Garzik <jeff@garzik.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: neilb@suse.de, Andrew Morton <akpm@linux-foundation.org>,
nfs@lists.sourceforge.net, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] NFSD: fix uninitialized variable
Date: Mon, 28 May 2007 23:19:21 -0400 [thread overview]
Message-ID: <465B9BB9.7060300@garzik.org> (raw)
In-Reply-To: <20070529030050.GB20631@fieldses.org>
J. Bruce Fields wrote:
> On Sun, May 27, 2007 at 06:34:42AM -0400, Jeff Garzik wrote:
>> Unlike many of the bogus warnings spewed by gcc, this one actually
>> complains about a real bug:
>
> No, the calls to posix_acl_valid() in nfs4_acl_posix_to_nfsv4() ensure
> that the passed-in acl has ACL_USER_OBJ, ACL_GROUP_OBJ, and ACL_OTHER
> entries, and hence that these fields will always be initialized.
OK
> But I don't want anyone else wasting their time on this. Should we cave
> in and add the initialization here just to shut up gcc? Or would a
> comment here help?
Given what you said above, I don't see gcc, on its best day, will ever
know enough to validate that that variable is indeed always initialized.
So I would vote for silencing it on those grounds.
Jeff
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
neilb@suse.de, nfs@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [NFS] [PATCH] NFSD: fix uninitialized variable
Date: Mon, 28 May 2007 23:19:21 -0400 [thread overview]
Message-ID: <465B9BB9.7060300@garzik.org> (raw)
In-Reply-To: <20070529030050.GB20631@fieldses.org>
J. Bruce Fields wrote:
> On Sun, May 27, 2007 at 06:34:42AM -0400, Jeff Garzik wrote:
>> Unlike many of the bogus warnings spewed by gcc, this one actually
>> complains about a real bug:
>
> No, the calls to posix_acl_valid() in nfs4_acl_posix_to_nfsv4() ensure
> that the passed-in acl has ACL_USER_OBJ, ACL_GROUP_OBJ, and ACL_OTHER
> entries, and hence that these fields will always be initialized.
OK
> But I don't want anyone else wasting their time on this. Should we cave
> in and add the initialization here just to shut up gcc? Or would a
> comment here help?
Given what you said above, I don't see gcc, on its best day, will ever
know enough to validate that that variable is indeed always initialized.
So I would vote for silencing it on those grounds.
Jeff
next prev parent reply other threads:[~2007-05-29 3:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 10:34 [PATCH] NFSD: fix uninitialized variable Jeff Garzik
2007-05-27 10:34 ` Jeff Garzik
2007-05-29 3:00 ` J. Bruce Fields
2007-05-29 3:00 ` [NFS] " J. Bruce Fields
2007-05-29 3:19 ` Jeff Garzik [this message]
2007-05-29 3:19 ` Jeff Garzik
2007-05-29 4:31 ` young dave
2007-05-29 7:29 ` Matt Keenan
2007-05-29 7:29 ` [NFS] " Matt Keenan
2007-05-29 8:32 ` young dave
2007-05-29 8:32 ` [NFS] " young dave
2007-05-29 19:52 ` J. Bruce Fields
2007-05-29 19:52 ` [NFS] " J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465B9BB9.7060300@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.