All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <J.Sixt@eudaptics.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 4/4] Don't link with libsocket in MINGW port
Date: Wed, 30 May 2007 14:01:26 +0200	[thread overview]
Message-ID: <465D6796.27B65043@eudaptics.com> (raw)
In-Reply-To: 1180492848275-git-send-email-pclouds@gmail.com

"Nguyễn Thái Ngọc Duy" wrote:
> 
> From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> 
> There is a check in configure.ac to determine if libc has function
> socket(). It is used to link with libsocket on SunOS.
> 
> On Windows, libc does not have socket() as well but it is provided
> by winsock, not libsocket. So don't link with libsocket if you are
> on Windows.

>  ifdef NEEDS_SOCKET
> +ifndef MINGW
>         EXTLIBS += -lsocket
>  endif
> +endif

This looks wrong. NEEDS_SOCKET is set in the architecture sections of
Makefile where necessary, but the MinGW section doesn't want it and
doesn't set it. If ./configure sets it, then you should fix
configure.ac, not work around in Makefile.

-- Hannes

PS: Appologies for the mangled name - this MUA is from the stone age.

  parent reply	other threads:[~2007-05-30 12:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <11804928354163-git-send-email-pclouds@gmail.com>
2007-05-30  6:51 ` [PATCH 0/4] Make MINGW port cross-compilable from Linux Johannes Sixt
2007-05-30 13:11   ` Johannes Schindelin
     [not found]     ` <fcaeb9bf0705300618s712be8auf29ba7bd3579bd16@mail.gmail.com>
2007-05-30 13:43       ` Johannes Schindelin
     [not found] ` <11804928381837-git-send-email-pclouds@gmail.com>
     [not found]   ` <1180492840102-git-send-email-pclouds@gmail.com>
     [not found]     ` <11804928463543-git-send-email-pclouds@gmail.com>
     [not found]       ` <1180492848275-git-send-email-pclouds@gmail.com>
2007-05-30 12:01         ` Johannes Sixt [this message]
2007-05-30 13:08           ` [PATCH 4/4] Don't link with libsocket in MINGW port Nguyen Thai Ngoc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465D6796.27B65043@eudaptics.com \
    --to=j.sixt@eudaptics.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.