* Re: [PATCH 0/4] Make MINGW port cross-compilable from Linux [not found] <11804928354163-git-send-email-pclouds@gmail.com> @ 2007-05-30 6:51 ` Johannes Sixt 2007-05-30 13:11 ` Johannes Schindelin [not found] ` <11804928381837-git-send-email-pclouds@gmail.com> 1 sibling, 1 reply; 5+ messages in thread From: Johannes Sixt @ 2007-05-30 6:51 UTC (permalink / raw) To: Nguyá» n Thái Ngá»c Duy; +Cc: git "Nguyá» n Thái Ngá»c Duy" wrote: > > The following patches allow to cross compile mingw port from Linux less painful. Thank you. Could you please push this to the mob branch? git push mob@repo.or.cz:/srv/git/git/mingw.git +mybranch:mob The series should be based on mingw.git's master branch (not devel)! -- Hannes ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/4] Make MINGW port cross-compilable from Linux 2007-05-30 6:51 ` [PATCH 0/4] Make MINGW port cross-compilable from Linux Johannes Sixt @ 2007-05-30 13:11 ` Johannes Schindelin [not found] ` <fcaeb9bf0705300618s712be8auf29ba7bd3579bd16@mail.gmail.com> 0 siblings, 1 reply; 5+ messages in thread From: Johannes Schindelin @ 2007-05-30 13:11 UTC (permalink / raw) To: Johannes Sixt Cc: Nguyá» n Thái Ngá»c Duy, git [-- Attachment #1: Type: TEXT/PLAIN, Size: 521 bytes --] Hi, On Wed, 30 May 2007, Johannes Sixt wrote: > "Nguyá» n Thái Ngá»c Duy" wrote: > > > > The following patches allow to cross compile mingw port from Linux less painful. > > Thank you. Could you please push this to the mob branch? > > git push mob@repo.or.cz:/srv/git/git/mingw.git +mybranch:mob > > The series should be based on mingw.git's master branch (not devel)! Is there any good reason why you do that in such a secretive manner? I have not seen this series on the list, just your replies. Ciao, Dscho ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <fcaeb9bf0705300618s712be8auf29ba7bd3579bd16@mail.gmail.com>]
* Re: [PATCH 0/4] Make MINGW port cross-compilable from Linux [not found] ` <fcaeb9bf0705300618s712be8auf29ba7bd3579bd16@mail.gmail.com> @ 2007-05-30 13:43 ` Johannes Schindelin 0 siblings, 0 replies; 5+ messages in thread From: Johannes Schindelin @ 2007-05-30 13:43 UTC (permalink / raw) To: Nguyen Thai Ngoc Duy; +Cc: Johannes Sixt, git [-- Attachment #1: Type: TEXT/PLAIN, Size: 1017 bytes --] Hi, On Wed, 30 May 2007, Nguyen Thai Ngoc Duy wrote: > On 5/30/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote: > > > > On Wed, 30 May 2007, Johannes Sixt wrote: > > > > > "Nguyễn Thái Ngọc Duy" wrote: > > > > > > > > The following patches allow to cross compile mingw port from Linux less > > painful. > > > > > > Thank you. Could you please push this to the mob branch? > > > > > > git push mob@repo.or.cz:/srv/git/git/mingw.git +mybranch:mob > > > > > > The series should be based on mingw.git's master branch (not devel)! > > > > Is there any good reason why you do that in such a secretive manner? I > > have not seen this series on the list, just your replies. > > It's vger that should be blamed, not me :) I sent the series to > Johannes Sixt and CC git@vger but they never came. That explains it. I notice that your mail did not come through again... Maybe vger should grow a facility where you can check _why_ a mail does not go through. Sort of frustrating otherwise. Ciao, Dscho ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <11804928381837-git-send-email-pclouds@gmail.com>]
[parent not found: <1180492840102-git-send-email-pclouds@gmail.com>]
[parent not found: <11804928463543-git-send-email-pclouds@gmail.com>]
[parent not found: <1180492848275-git-send-email-pclouds@gmail.com>]
* Re: [PATCH 4/4] Don't link with libsocket in MINGW port [not found] ` <1180492848275-git-send-email-pclouds@gmail.com> @ 2007-05-30 12:01 ` Johannes Sixt 2007-05-30 13:08 ` Nguyen Thai Ngoc Duy 0 siblings, 1 reply; 5+ messages in thread From: Johannes Sixt @ 2007-05-30 12:01 UTC (permalink / raw) To: Nguyá» n Thái Ngá»c Duy; +Cc: git "Nguyá» n Thái Ngá»c Duy" wrote: > > From: Nguyá» n Thái Ngá»c Duy <pclouds@gmail.com> > > There is a check in configure.ac to determine if libc has function > socket(). It is used to link with libsocket on SunOS. > > On Windows, libc does not have socket() as well but it is provided > by winsock, not libsocket. So don't link with libsocket if you are > on Windows. > ifdef NEEDS_SOCKET > +ifndef MINGW > EXTLIBS += -lsocket > endif > +endif This looks wrong. NEEDS_SOCKET is set in the architecture sections of Makefile where necessary, but the MinGW section doesn't want it and doesn't set it. If ./configure sets it, then you should fix configure.ac, not work around in Makefile. -- Hannes PS: Appologies for the mangled name - this MUA is from the stone age. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 4/4] Don't link with libsocket in MINGW port 2007-05-30 12:01 ` [PATCH 4/4] Don't link with libsocket in MINGW port Johannes Sixt @ 2007-05-30 13:08 ` Nguyen Thai Ngoc Duy 0 siblings, 0 replies; 5+ messages in thread From: Nguyen Thai Ngoc Duy @ 2007-05-30 13:08 UTC (permalink / raw) To: Johannes Sixt; +Cc: git On 5/30/07, Johannes Sixt <J.Sixt@eudaptics.com> wrote: > This looks wrong. NEEDS_SOCKET is set in the architecture sections of > Makefile where necessary, but the MinGW section doesn't want it and > doesn't set it. If ./configure sets it, then you should fix > configure.ac, not work around in Makefile. I did so because I didn't have SunOS to test so I'd rather not touch the code detecting NEEDS_SOCKET in configure.ac. How about this patch: diff --git a/configure.ac b/configure.ac index 4a12cb0..0516fdb 100644 --- a/configure.ac +++ b/configure.ac @@ -173,6 +173,12 @@ test -n "$NEEDS_LIBICONV" && LIBS="$LIBS -liconv" AC_CHECK_LIB([c], [socket], [NEEDS_SOCKET=], [NEEDS_SOCKET=YesPlease]) +if test "$NEEDS_SOCKET" = YesPlease; then # more check + AC_CHECK_LIB([socket], [socket], + [LIBSOCKET_HAS_SOCKET=], + [LIBSOCKET_HAS_SOCKET=1]) + test -n "$LIBSOCKET_HAS_SOCKET" && NEEDS_SOCKET= +fi AC_SUBST(NEEDS_SOCKET) test -n "$NEEDS_SOCKET" && LIBS="$LIBS -lsocket" If someone has a SunOS, please test the above patch. Thanks -- Duy ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-05-30 13:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <11804928354163-git-send-email-pclouds@gmail.com>
2007-05-30 6:51 ` [PATCH 0/4] Make MINGW port cross-compilable from Linux Johannes Sixt
2007-05-30 13:11 ` Johannes Schindelin
[not found] ` <fcaeb9bf0705300618s712be8auf29ba7bd3579bd16@mail.gmail.com>
2007-05-30 13:43 ` Johannes Schindelin
[not found] ` <11804928381837-git-send-email-pclouds@gmail.com>
[not found] ` <1180492840102-git-send-email-pclouds@gmail.com>
[not found] ` <11804928463543-git-send-email-pclouds@gmail.com>
[not found] ` <1180492848275-git-send-email-pclouds@gmail.com>
2007-05-30 12:01 ` [PATCH 4/4] Don't link with libsocket in MINGW port Johannes Sixt
2007-05-30 13:08 ` Nguyen Thai Ngoc Duy
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.