Re: [PATCH 1/3] hexdump: more output formatting

[Randy Dunlap <randy.dunlap@oracle.com>]

Christoph Lameter wrote:
> On Wed, 30 May 2007, Randy Dunlap wrote:
> 
>> Add an "ascii" output parameter.  This causes ASCII data output
>> following the hex data output.
> 
> The ascii output is not properly aligned. Its simply thrown in
> after the hex dump output. The last line of a multi line hexdump
> will have the ascii output moved to the left. Its not properly adjusted.

It was never a written requirement.  :)
but maybe it is now.

>> + *
>>   * E.g.:
>>   *   print_hex_dump(KERN_DEBUG, DUMP_PREFIX_ADDRESS, frame->data, frame->len);
> 
> ^^^ needs to be updated?

Yes, it does.


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***