Re: [PATCH 1/3] hexdump: more output formatting

[Randy Dunlap <randy.dunlap@oracle.com>]

Satyam Sharma wrote:
> On 5/31/07, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> Satyam Sharma wrote:
>> > On 5/31/07, Christoph Lameter <clameter@sgi.com> wrote:
>> >> On Thu, 31 May 2007, Satyam Sharma wrote:
>> >>
>> >> > Yes, you're right, but I was just wondering whether any users really
>> >> > cared enough about the rowsize and groupsize, also seeing that
>> >> > accommodating these two args leads to a lot of increase in code.
>> >>
>> >> Have two functions
>> >>
>> >> 1. A function that prints full lines with address and ascii
>> >>         This defaults to 16 bytes by default + ascii.
>> >>
>> >> hex_dump?
>> >>
>> >> 2. A function to convert a few bytes for use in other output.
>> >>
>> >> sprint_hex?
>> >
>> > Yes, or we could go the whole hog and have a total of 4 functions:
>> >
>> > (1) For users that want to use a short version, and are fine with
>> > the default values for the grouping / other parameters -- also have
>> > both the print_to_buffer/sprint_hex and print_to_console/hex_dump
>> > variants.
>> >
>> > (2) For users that care about these parameters, both the variants
>> > with the expanded arglist (the ones listed above in (1) would then
>> > just be inlines wrapping over these ones)
>> >
>> > Just that it would be nice if there is some simple (with short arglist)
>> > function that works well-enough for most people that everyone would
>> > be able to adopt/use quickly.
>>
>> Satyam, you sound like you need something to do, so please grep the
>> kernel tree for /hexdump/, /hex_dump/, /dump_hex/, /dumphex/, and
>> other such variants and help me add some callers for lib/hexdump.c.
>> That way we can see what parameters it really needs.
> 
> Sure, I'll get started on this, then! :-)

Great!  oh, there's also dumpmem, dump_mem, memdump, mem_dump, etc.  :)

Thanks.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***