From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 06/20] usb: host: xhci-plat: Add support for the Armada 38x
Date: Tue, 06 May 2014 14:21:55 +0200 [thread overview]
Message-ID: <4660313.evfclGtT1x@wuerfel> (raw)
In-Reply-To: <20140506141023.715b932d@skate>
On Tuesday 06 May 2014 14:10:23 Thomas Petazzoni wrote:
> On Tue, 06 May 2014 13:57:44 +0200, Arnd Bergmann wrote:
>
> > > Please limit this driver to mvebu arch and compile testing, i.e.
> > >
> > > depends on ARCH_MVEBU || COMPILE_TEST
> >
> > I think it actually needs a dependency on MVEBU_MBUS.
>
> That's not what we do for any of the other drivers that use the
> MVEBU_MBUS functions.
Fair enough. I guess using ARCH_MVEBU as the dependency works as well
because it implies MVEBU_MBUS. However, you can't use COMPILE_TEST
then because the driver itself needs the interfaces provided by MBUS.
It could be
depends on ARCH_MVEBU || (MVEBU_MBUS && COMPILE_TEST)
to describe the dependency most accurately.
> > You probably need something like
> >
> > depends on MVEBU_MBUS=y || (MVEBU_MBUS=m && USB_XHCI=m)
>
> MVEBU_MBUS is a bool, so there is no way is can be =m.
Yes, that helps.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Mathias Nyman
<mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Bartlomiej Zolnierkiewicz
<b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Nadav Haklai <nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Ezequiel Garcia
<ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Tawfik Bayouk <tawfik-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3 06/20] usb: host: xhci-plat: Add support for the Armada 38x
Date: Tue, 06 May 2014 14:21:55 +0200 [thread overview]
Message-ID: <4660313.evfclGtT1x@wuerfel> (raw)
In-Reply-To: <20140506141023.715b932d@skate>
On Tuesday 06 May 2014 14:10:23 Thomas Petazzoni wrote:
> On Tue, 06 May 2014 13:57:44 +0200, Arnd Bergmann wrote:
>
> > > Please limit this driver to mvebu arch and compile testing, i.e.
> > >
> > > depends on ARCH_MVEBU || COMPILE_TEST
> >
> > I think it actually needs a dependency on MVEBU_MBUS.
>
> That's not what we do for any of the other drivers that use the
> MVEBU_MBUS functions.
Fair enough. I guess using ARCH_MVEBU as the dependency works as well
because it implies MVEBU_MBUS. However, you can't use COMPILE_TEST
then because the driver itself needs the interfaces provided by MBUS.
It could be
depends on ARCH_MVEBU || (MVEBU_MBUS && COMPILE_TEST)
to describe the dependency most accurately.
> > You probably need something like
> >
> > depends on MVEBU_MBUS=y || (MVEBU_MBUS=m && USB_XHCI=m)
>
> MVEBU_MBUS is a bool, so there is no way is can be =m.
Yes, that helps.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
linux-usb@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Mathias Nyman <mathias.nyman@intel.com>,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Nadav Haklai <nadavh@marvell.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Rob Herring <robh+dt@kernel.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Grant Likely <grant.likely@linaro.org>,
Tawfik Bayouk <tawfik@marvell.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v3 06/20] usb: host: xhci-plat: Add support for the Armada 38x
Date: Tue, 06 May 2014 14:21:55 +0200 [thread overview]
Message-ID: <4660313.evfclGtT1x@wuerfel> (raw)
In-Reply-To: <20140506141023.715b932d@skate>
On Tuesday 06 May 2014 14:10:23 Thomas Petazzoni wrote:
> On Tue, 06 May 2014 13:57:44 +0200, Arnd Bergmann wrote:
>
> > > Please limit this driver to mvebu arch and compile testing, i.e.
> > >
> > > depends on ARCH_MVEBU || COMPILE_TEST
> >
> > I think it actually needs a dependency on MVEBU_MBUS.
>
> That's not what we do for any of the other drivers that use the
> MVEBU_MBUS functions.
Fair enough. I guess using ARCH_MVEBU as the dependency works as well
because it implies MVEBU_MBUS. However, you can't use COMPILE_TEST
then because the driver itself needs the interfaces provided by MBUS.
It could be
depends on ARCH_MVEBU || (MVEBU_MBUS && COMPILE_TEST)
to describe the dependency most accurately.
> > You probably need something like
> >
> > depends on MVEBU_MBUS=y || (MVEBU_MBUS=m && USB_XHCI=m)
>
> MVEBU_MBUS is a bool, so there is no way is can be =m.
Yes, that helps.
Arnd
next prev parent reply other threads:[~2014-05-06 12:21 UTC|newest]
Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 0:13 [PATCH v3 00/20] USB support for Armada 38x and Armada 375 Gregory CLEMENT
2014-05-06 0:13 ` Gregory CLEMENT
2014-05-06 0:13 ` [PATCH v3 01/20] usb: ehci-orion: Fix clock reference leaking Gregory CLEMENT
2014-05-06 0:13 ` Gregory CLEMENT
2014-05-06 0:13 ` Gregory CLEMENT
2014-05-06 14:30 ` Alan Stern
2014-05-06 14:30 ` Alan Stern
2014-05-06 14:30 ` Alan Stern
2014-05-07 9:38 ` Thomas Petazzoni
2014-05-07 9:38 ` Thomas Petazzoni
2014-05-07 9:38 ` Thomas Petazzoni
2014-05-06 0:13 ` [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support Gregory CLEMENT
2014-05-06 0:13 ` Gregory CLEMENT
2014-05-06 0:13 ` Gregory CLEMENT
2014-05-06 13:33 ` Andrew Lunn
2014-05-06 13:33 ` Andrew Lunn
2014-05-07 9:40 ` Thomas Petazzoni
2014-05-07 9:40 ` Thomas Petazzoni
2014-05-07 9:40 ` Thomas Petazzoni
2014-05-07 13:21 ` Andrew Lunn
2014-05-07 13:21 ` Andrew Lunn
2014-05-07 13:56 ` Thomas Petazzoni
2014-05-07 13:56 ` Thomas Petazzoni
2014-05-06 0:13 ` [PATCH v3 03/20] usb: host: xhci-plat: Sort the headers in alphabetic order Gregory CLEMENT
2014-05-06 0:13 ` Gregory CLEMENT
2014-05-06 0:13 ` Gregory CLEMENT
2014-05-06 0:13 ` [PATCH v3 04/20] usb: xhci: add a platform-private field Gregory CLEMENT
2014-05-06 0:13 ` Gregory CLEMENT
2014-05-06 0:13 ` Gregory CLEMENT
2014-05-06 15:40 ` Felipe Balbi
2014-05-06 15:40 ` Felipe Balbi
2014-05-06 15:40 ` Felipe Balbi
2014-05-06 0:14 ` [PATCH v3 05/20] usb: host: xhci-plat: Add clocks support Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 3:00 ` Felipe Balbi
2014-05-06 3:00 ` Felipe Balbi
2014-05-06 3:00 ` Felipe Balbi
2014-05-06 13:41 ` Jason Cooper
2014-05-06 13:41 ` Jason Cooper
2014-05-07 12:26 ` Thomas Petazzoni
2014-05-07 12:26 ` Thomas Petazzoni
2014-05-07 12:26 ` Thomas Petazzoni
2014-05-06 0:14 ` [PATCH v3 06/20] usb: host: xhci-plat: Add support for the Armada 38x Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 11:34 ` Bartlomiej Zolnierkiewicz
2014-05-06 11:34 ` Bartlomiej Zolnierkiewicz
2014-05-06 11:34 ` Bartlomiej Zolnierkiewicz
2014-05-06 11:57 ` Arnd Bergmann
2014-05-06 11:57 ` Arnd Bergmann
2014-05-06 11:57 ` Arnd Bergmann
2014-05-06 12:10 ` Thomas Petazzoni
2014-05-06 12:10 ` Thomas Petazzoni
2014-05-06 12:10 ` Thomas Petazzoni
2014-05-06 12:21 ` Arnd Bergmann [this message]
2014-05-06 12:21 ` Arnd Bergmann
2014-05-06 12:21 ` Arnd Bergmann
2014-05-06 12:42 ` Thomas Petazzoni
2014-05-06 12:42 ` Thomas Petazzoni
2014-05-06 12:42 ` Thomas Petazzoni
2014-05-06 15:39 ` Felipe Balbi
2014-05-06 15:39 ` Felipe Balbi
2014-05-06 15:39 ` Felipe Balbi
2014-05-07 10:23 ` Thomas Petazzoni
2014-05-07 10:23 ` Thomas Petazzoni
2014-05-07 10:23 ` Thomas Petazzoni
2014-05-07 15:10 ` Felipe Balbi
2014-05-07 15:10 ` Felipe Balbi
2014-05-07 15:10 ` Felipe Balbi
2014-05-07 15:14 ` Thomas Petazzoni
2014-05-07 15:14 ` Thomas Petazzoni
2014-05-07 15:14 ` Thomas Petazzoni
2014-05-06 0:14 ` [PATCH v3 07/20] xhci-platform: Add a new controller using xhci: " Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 08/20] ARM: mvebu: Add Device Tree description of xHCI hosts on " Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 13:42 ` Andrew Lunn
2014-05-06 13:42 ` Andrew Lunn
2014-05-06 0:14 ` [PATCH v3 09/20] ARM: mvebu: Add Device Tree description of the EHCI host " Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 10/20] ARM: mvebu: Add USB3 support for " Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 11/20] ARM: configs: Add usb_xhci_mvebu to mvebu_v7_defconfig Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 12/20] ARM: configs: Add usb_xhci_mvebu to multi_v7_defconfig Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 13:46 ` Jason Cooper
2014-05-06 13:46 ` Jason Cooper
2014-05-06 0:14 ` [PATCH v3 13/20] usb: host: xhci-plat: Add support for the Armada 375 Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 14/20] xhci-platform: Add a new controller using xHCI: " Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 15/20] ARM: mvebu: Add Device Tree description of USB cluster controller on " Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 16/20] dt: binding: Armada 375 USB cluster Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 17/20] phy: Add support for USB cluster on the Armada 375 SoC Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 11:37 ` Bartlomiej Zolnierkiewicz
2014-05-06 11:37 ` Bartlomiej Zolnierkiewicz
2014-05-07 12:50 ` Thomas Petazzoni
2014-05-07 12:50 ` Thomas Petazzoni
2014-05-07 12:50 ` Thomas Petazzoni
2014-05-06 13:54 ` Andrew Lunn
2014-05-06 13:54 ` Andrew Lunn
2014-05-07 12:52 ` Thomas Petazzoni
2014-05-07 12:52 ` Thomas Petazzoni
2014-05-07 12:52 ` Thomas Petazzoni
2014-05-06 20:53 ` Ezequiel Garcia
2014-05-06 20:53 ` Ezequiel Garcia
2014-05-07 12:55 ` Thomas Petazzoni
2014-05-07 12:55 ` Thomas Petazzoni
2014-05-07 12:55 ` Thomas Petazzoni
2014-05-06 0:14 ` [PATCH v3 18/20] ARM: mvebu: Add USB3 support for Armada 375 Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 19/20] ARM: mvebu: Add Device Tree description of the xHCI host on " Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 20/20] ARM: mvebu: Add Device Tree description of the EHCI " Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-06 0:14 ` Gregory CLEMENT
2014-05-07 8:33 ` [PATCH v3 00/20] USB support for Armada 38x and " Hans de Goede
2014-05-07 9:21 ` Sebastian Hesselbarth
2014-05-07 9:21 ` Sebastian Hesselbarth
2014-05-07 9:21 ` Sebastian Hesselbarth
2014-05-07 9:48 ` Hans de Goede
2014-05-07 9:48 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4660313.evfclGtT1x@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.